From: Felipe Balbi <me@felipebalbi.com>
To: David Brownell <david-b@pacbell.net>
Cc: OMAP <linux-omap@vger.kernel.org>
Subject: Re: [patch 2.6.29-rc8-omap] twl4030 power scripts, initsection fixups
Date: Sat, 14 Mar 2009 12:57:00 +0200 [thread overview]
Message-ID: <20090314105659.GA8832@gandalf> (raw)
In-Reply-To: <200903131825.52114.david-b@pacbell.net>
On Fri, Mar 13, 2009 at 06:25:52PM -0700, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Remove section mismatch warnings from twl4030 power script
> declaration ... unfortunately, this use-once data can't live
> in initdata sections (or initconst) until some driver stacks
> (starting with I2C) have better support for non-hotpluggable
> componentry.
should you update this with the following ?
diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index d9d1655..1f246e8 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -66,7 +66,7 @@ static u8 triton_next_free_address = 0x2b;
#define KEY_1 0xC0
#define KEY_2 0x0C
-static int __init twl4030_write_script_byte(u8 address, u8 byte)
+static int twl4030_write_script_byte(u8 address, u8 byte)
{
int err;
@@ -78,7 +78,7 @@ static int __init twl4030_write_script_byte(u8 address, u8 byte)
return err;
}
-static int __init twl4030_write_script_ins(u8 address, u16 pmb_message,
+static int twl4030_write_script_ins(u8 address, u16 pmb_message,
u8 delay, u8 next)
{
int err = 0;
@@ -92,7 +92,7 @@ static int __init twl4030_write_script_ins(u8 address, u16 pmb_message,
return err;
}
-static int __init twl4030_write_script(u8 address, struct twl4030_ins *script,
+static int twl4030_write_script(u8 address, struct twl4030_ins *script,
int len)
{
int err = 0;
@@ -113,7 +113,7 @@ static int __init twl4030_write_script(u8 address, struct twl4030_ins *script,
return err;
}
-static int __init config_wakeup3_sequence(u8 address)
+static int config_wakeup3_sequence(u8 address)
{
int err = 0;
@@ -131,7 +131,7 @@ static int __init config_wakeup3_sequence(u8 address)
return err;
}
-static int __init config_wakeup12_sequence(u8 address)
+static int config_wakeup12_sequence(u8 address)
{
int err = 0;
@@ -162,7 +162,7 @@ static int __init config_wakeup12_sequence(u8 address)
return err;
}
-static int __init config_sleep_sequence(u8 address)
+static int config_sleep_sequence(u8 address)
{
int err = 0;
@@ -184,7 +184,7 @@ static int __init config_sleep_sequence(u8 address)
return err;
}
-static int __init config_warmreset_sequence(u8 address)
+static int config_warmreset_sequence(u8 address)
{
int err = 0;
@@ -219,7 +219,7 @@ static int __init config_warmreset_sequence(u8 address)
return err;
}
-static int __init load_triton_script(struct twl4030_script *tscript)
+static int load_triton_script(struct twl4030_script *tscript)
{
u8 address = triton_next_free_address;
int err;
@@ -245,7 +245,7 @@ static int __init load_triton_script(struct twl4030_script *tscript)
return err;
}
-void __init twl4030_power_init(struct twl4030_power_data *triton2_scripts)
+void twl4030_power_init(struct twl4030_power_data *triton2_scripts)
{
int err = 0;
int i;
--
balbi
next prev parent reply other threads:[~2009-03-14 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 1:25 [patch 2.6.29-rc8-omap] twl4030 power scripts, initsection fixups David Brownell
2009-03-14 10:57 ` Felipe Balbi [this message]
2009-03-14 19:00 ` David Brownell
2009-03-16 0:24 ` Felipe Balbi
2009-03-16 21:11 ` David Brownell
2009-03-16 21:32 ` Felipe Balbi
2009-03-16 21:41 ` Felipe Balbi
2009-03-16 21:46 ` Felipe Balbi
2009-03-16 21:52 ` [PATCH] " Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090314105659.GA8832@gandalf \
--to=me@felipebalbi.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox