From: David Brownell <david-b@pacbell.net>
To: me@felipebalbi.com
Cc: OMAP <linux-omap@vger.kernel.org>
Subject: Re: [patch 2.6.29-rc8-omap] twl4030 power scripts, initsection fixups
Date: Sat, 14 Mar 2009 12:00:53 -0700 [thread overview]
Message-ID: <200903141200.53768.david-b@pacbell.net> (raw)
In-Reply-To: <20090314105659.GA8832@gandalf>
On Saturday 14 March 2009, Felipe Balbi wrote:
> >
> > Remove section mismatch warnings from twl4030 power script
> > declaration ... unfortunately, this use-once data can't live
> > in initdata sections (or initconst) until some driver stacks
> > (starting with I2C) have better support for non-hotpluggable
> > componentry.
>
> should you update this with the following ?
I didn't see any section mismatch warnings from this goofage. ;)
But, yes this looks wrong too. Resend with your s-o-b ...
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -66,7 +66,7 @@ static u8 triton_next_free_address = 0x2b;
> #define KEY_1 0xC0
> #define KEY_2 0x0C
>
> -static int __init twl4030_write_script_byte(u8 address, u8 byte)
> +static int twl4030_write_script_byte(u8 address, u8 byte)
> {
> int err;
>
> ... deleted similar changes ...
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-14 19:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 1:25 [patch 2.6.29-rc8-omap] twl4030 power scripts, initsection fixups David Brownell
2009-03-14 10:57 ` Felipe Balbi
2009-03-14 19:00 ` David Brownell [this message]
2009-03-16 0:24 ` Felipe Balbi
2009-03-16 21:11 ` David Brownell
2009-03-16 21:32 ` Felipe Balbi
2009-03-16 21:41 ` Felipe Balbi
2009-03-16 21:46 ` Felipe Balbi
2009-03-16 21:52 ` [PATCH] " Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903141200.53768.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox