From: Tony Lindgren <tony@atomide.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: rmk+kernel@arm.linux.org.uk, linux-omap@vger.kernel.org,
Linux-arm <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH] ARM: OMAP2: possible division by 0
Date: Wed, 18 Mar 2009 15:03:22 -0700 [thread overview]
Message-ID: <20090318220321.GH29546@atomide.com> (raw)
In-Reply-To: <49BF8CEC.1000901@gmail.com>
* Roel Kluin <roel.kluin@gmail.com> [090317 04:50]:
> In linus' git tree the functions can be found at:
> vi arch/arm/mach-omap2/usb-tusb6010.c +200 - tusb6010_platform_retime()
> vi arch/arm/mach-omap2/gpmc.c +94 - gpmc_get_fclk_period()
> vi arch/arm/mach-omap2/usb-tusb6010.c +53 - tusb_set_async_mode()
> vi arch/arm/mach-omap2/usb-tusb6010.c +111 - tusb_set_sync_mode()
>
> is -ENODEV appropriate when sysclk_ps == 0?
>
> This was found by code analysis, please review.
> ------------------------------>8-------------8<---------------------------------
> gpmc_get_fclk_period() may return 0 when gpmc_l3_clk is not enabled. This is
> not checked in tusb6010_platform_retime() nor in tusb_set_async_mode() it
> seems. In tusb_set_sync_mode() this may result in a division by zero.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Looks like a valid fix to me. I'll add it to omap-fixes queue.
To me it sounds like there's no urgent need to get this integrated
as we're missing most of the omap2 PM still.
Tony
> ---
> diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
> index 15e5090..8df55f4 100644
> --- a/arch/arm/mach-omap2/usb-tusb6010.c
> +++ b/arch/arm/mach-omap2/usb-tusb6010.c
> @@ -187,7 +187,7 @@ int tusb6010_platform_retime(unsigned is_refclk)
> unsigned sysclk_ps;
> int status;
>
> - if (!refclk_psec)
> + if (!refclk_psec || sysclk_ps == 0)
> return -ENODEV;
>
> sysclk_ps = is_refclk ? refclk_psec : TUSB6010_OSCCLK_60;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-03-18 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 11:43 [PATCH] ARM: OMAP2: possible division by 0 Roel Kluin
2009-03-18 22:01 ` [APPLIED] " Tony Lindgren
2009-03-18 22:03 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318220321.GH29546@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox