From: Jarkko Nikula <jarkko.nikula@nokia.com>
To: "Nurkkala Eero.An (EXT-Offcode/Oulu)" <ext-Eero.Nurkkala@nokia.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCHv2] OMAP: McBSP: Always maintain McBSP fclk while active
Date: Thu, 19 Mar 2009 14:29:13 +0200 [thread overview]
Message-ID: <20090319142913.fa051504.jarkko.nikula@nokia.com> (raw)
In-Reply-To: <12373758621770-git-send-email-ext-eero.nurkkala@nokia.com>
On Wed, 18 Mar 2009 12:31:02 +0100
"Nurkkala Eero.An (EXT-Offcode/Oulu)" <ext-Eero.Nurkkala@nokia.com>
wrote:
> From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
>
> McBSP fclk must be maintained for the duration of
> audio playback or recording. Otherwise the fclk
> may get autogated when the PER96M clk is no longer
> required by other modules. This results in audio
> activity being hang. Also, if the McBSP is run
> as a slave, it is possible that words are
> randomly missed from the playback. Fix all this
> phenomenom by enabling the McBSP fclk
> clockactivity bit for the entire active duration
> of the McBSP usage.
>
> Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
> ---
...
> w = OMAP_MCBSP_READ(mcbsp->io_base, SYSCON);
> - w &= ~(ENAWAKEUP | SIDLEMODE(0x03));
> - w |= (ENAWAKEUP | SIDLEMODE(0x02));
> + w &= ~(ENAWAKEUP | SIDLEMODE(0x03) | CLOCKACTIVITY
> (0x03));
> + w |= (ENAWAKEUP | SIDLEMODE(0x02) | CLOCKACTIVITY
> (0x02));
Based on updated TRM info:
http://marc.info/?l=linux-omap&m=123674373120880&w=2
Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>
next prev parent reply other threads:[~2009-03-19 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 11:31 [PATCHv2] OMAP: McBSP: Always maintain McBSP fclk while active ext-eero.nurkkala
2009-03-19 12:29 ` Jarkko Nikula [this message]
2009-03-26 22:47 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319142913.fa051504.jarkko.nikula@nokia.com \
--to=jarkko.nikula@nokia.com \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox