public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: David Brownell <david-b@pacbell.net>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: Don't warn user about expected behaviour in mmc-twl4030
Date: Fri, 3 Apr 2009 17:26:52 -0700	[thread overview]
Message-ID: <20090404002652.GF8840@atomide.com> (raw)
In-Reply-To: <20090331210019.GA12304@sirena.org.uk>

* Mark Brown <broonie@sirena.org.uk> [090331 14:00]:
> On Mon, Mar 30, 2009 at 01:53:43PM -0700, David Brownell wrote:
> 
> > So when are you going to fix the regulator docs to report that:
> 
> > 	ALL regulator consumers must start by enabling and
> > 	then disabling the regulator.
> 
> The documention should not be changed to say that since only consumers
> that need the regulator to be off at startup should do this, and then
> probably only if they find that it is already enabled.
> 
> Other consumers do not need to do this.  Consumers that want to enable a
> regulator at startup can do so directly.  Consumers that don't need a
> specific state (for example, because they are able to share the
> regulator and don't need it enabling) should just leave it alone.

Maybe you guys have gone back and forth on this option too.. But what
if we have something in regulator_init_data that would tell the
regulator to reset the regulator on init? That could be then be
then disabled with some cmdline option if needed for debugging or
while booting from other operating systems etc.

I've applied Mark's patch to l-o, I guess now I need to start sorting
out what we need to mainline for twl4030-mmc.c for this -rc :)

Regards,

Tony

  reply	other threads:[~2009-04-04  0:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-30 19:15 [PATCH] OMAP: Don't warn user about expected behaviour in mmc-twl4030 Mark Brown
2009-03-30 20:53 ` David Brownell
2009-03-31 21:00   ` Mark Brown
2009-04-04  0:26     ` Tony Lindgren [this message]
2009-04-04  0:40       ` Mark Brown
2009-04-04  1:03     ` David Brownell
2009-04-06 15:56       ` Mark Brown
2009-04-04  0:24 ` [APPLIED] [PATCH] OMAP: Don&#39;t warn user about expected behaviour in Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090404002652.GF8840@atomide.com \
    --to=tony@atomide.com \
    --cc=broonie@sirena.org.uk \
    --cc=david-b@pacbell.net \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox