From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org,
Adrian Hunter <adrian.hunter@nokia.com>,
Pierre Ossman <drzeus@drzeus.cx>
Subject: [PATCH] mmc: Fix compile for omap_hsmmc.c (Re: New build error?)
Date: Tue, 7 Apr 2009 17:13:27 -0700 [thread overview]
Message-ID: <20090408001325.GG23823@atomide.com> (raw)
In-Reply-To: <20090407195524.GA10619@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
* Russell King - ARM Linux <linux@arm.linux.org.uk> [090407 12:55]:
> Caused by: 4a694dc915c9a223044ce21fc0d99e63facd1d64
>
> omap_hsmmc: Fix response type for busy after response
>
> Error:
>
> drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
> drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'
>
> Please submit a fix to Pierre for this, thanks.
Thanks for notifying about this. Pierre, here's a fix for this.
Tony
[-- Attachment #2: hsmmc-fix-compile.patch --]
[-- Type: text/x-diff, Size: 945 bytes --]
>From 880d2674e036b566f5596bef1b45911508cd37a1 Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Tue, 7 Apr 2009 17:04:33 -0700
Subject: [PATCH] mmc: Fix compile for omap_hsmmc.c
This fixes the issue noted by Russell King:
drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'
This got broken by 4a694dc915c9a223044ce21fc0d99e63facd1d64.
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index a752788..d765df2 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -298,7 +298,6 @@ mmc_omap_xfer_done(struct mmc_omap_host *host, struct mmc_data *data)
struct mmc_request *mrq = host->mrq;
host->mrq = NULL;
- mmc_omap_fclk_lazy_disable(host);
mmc_request_done(host->mmc, mrq);
return;
}
next prev parent reply other threads:[~2009-04-08 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 19:55 New build error? Russell King - ARM Linux
2009-04-08 0:13 ` Tony Lindgren [this message]
2009-04-08 18:41 ` [PATCH] mmc: Fix compile for omap_hsmmc.c (Re: New build error?) Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408001325.GG23823@atomide.com \
--to=tony@atomide.com \
--cc=adrian.hunter@nokia.com \
--cc=drzeus@drzeus.cx \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox