[PATCH] OMAP3: lessen amount of noisy messages

[PATCH] OMAP3: lessen amount of noisy messages

[Artem Bityutskiy]

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Date: Thu, 9 Apr 2009 17:15:47 +0300
Subject: [PATCH] OMAP3: lessen amount of noisy messages

On our system we see the following messages:

Disabling unused clock "gpt2_ick"
Disabling unused clock "gpt3_ick"
Disabling unused clock "gpt4_ick"
Disabling unused clock "gpt5_ick"
Disabling unused clock "gpt6_ick"
Disabling unused clock "gpt7_ick"
Disabling unused clock "gpt8_ick"
Disabling unused clock "gpt9_ick"
Disabling unused clock "gpio2_dbck"
Disabling unused clock "gpio3_dbck"
Disabling unused clock "gpio4_dbck"
Disabling unused clock "gpio5_dbck"
Disabling unused clock "gpio6_dbck"
Disabling unused clock "gpt9_fck"
Disabling unused clock "gpt8_fck"
Disabling unused clock "gpt7_fck"
Disabling unused clock "gpt6_fck"
Disabling unused clock "gpt5_fck"
Disabling unused clock "gpt4_fck"
Disabling unused clock "gpt3_fck"
Disabling unused clock "gpt2_fck"
Disabling unused clock "wdt2_ick"
Disabling unused clock "wdt2_fck"
Disabling unused clock "gpio1_dbck"
Disabling unused clock "rng_ick"
Disabling unused clock "ssi_ick"
Disabling unused clock "gpt10_ick"
Disabling unused clock "gpt11_ick"
Disabling unused clock "uart1_ick"
Disabling unused clock "uart2_ick"
Disabling unused clock "usbtll_ick"
Disabling unused clock "ssi_ssr_fck"
Disabling unused clock "uart1_fck"
Disabling unused clock "uart2_fck"
Disabling unused clock "usbtll_fck"
Disabling unused clock "ts_fck"
Disabling unused clock "cpefuse_fck"
Disabling unused clock "gpt11_fck"
Disabling unused clock "gpt10_fck"
Disabling unused clock "dpll5_ck"
Disabling unused clock "dpll4_m6x2_ck"
Disabling unused clock "dpll4_m5x2_ck"
Disabling unused clock "dpll3_m3x2_ck"
Disabling unused clock "sys_clkout1"

The messages have KERN_INFO level and if you have serial
console, they normally go there. I do not think it is good
idea to print that much stuff there. Moreover, messages
are not properly prefixed and for mortals it is not
immeadietly clear where they come from.

Let's give them debugging level instead.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 arch/arm/mach-omap2/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index 4247a15..2f254bf 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -1035,7 +1035,7 @@ void omap2_clk_disable_unused(struct clk *clk)
 	if ((regval32 & (1 << clk->enable_bit)) == v)
 		return;
 
-	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
+	pr_debug("Disabling unused clock \"%s\"\n", clk->name);
 	if (cpu_is_omap34xx()) {
 		omap2_clk_enable(clk);
 		omap2_clk_disable(clk);
-- 
1.6.0.6

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Artem Bityutskiy]

Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> Date: Thu, 9 Apr 2009 17:15:47 +0300
> Subject: [PATCH] OMAP3: lessen amount of noisy messages
> 
> On our system we see the following messages:
> 
> Disabling unused clock "gpt2_ick"
> Disabling unused clock "gpt3_ick"
> Disabling unused clock "gpt4_ick"
> Disabling unused clock "gpt5_ick"
> Disabling unused clock "gpt6_ick"
> Disabling unused clock "gpt7_ick"
> Disabling unused clock "gpt8_ick"
> Disabling unused clock "gpt9_ick"
> Disabling unused clock "gpio2_dbck"
> Disabling unused clock "gpio3_dbck"
> Disabling unused clock "gpio4_dbck"
> Disabling unused clock "gpio5_dbck"
> Disabling unused clock "gpio6_dbck"
> Disabling unused clock "gpt9_fck"
> Disabling unused clock "gpt8_fck"
> Disabling unused clock "gpt7_fck"
> Disabling unused clock "gpt6_fck"
> Disabling unused clock "gpt5_fck"
> Disabling unused clock "gpt4_fck"
> Disabling unused clock "gpt3_fck"
> Disabling unused clock "gpt2_fck"
> Disabling unused clock "wdt2_ick"
> Disabling unused clock "wdt2_fck"
> Disabling unused clock "gpio1_dbck"
> Disabling unused clock "rng_ick"
> Disabling unused clock "ssi_ick"
> Disabling unused clock "gpt10_ick"
> Disabling unused clock "gpt11_ick"
> Disabling unused clock "uart1_ick"
> Disabling unused clock "uart2_ick"
> Disabling unused clock "usbtll_ick"
> Disabling unused clock "ssi_ssr_fck"
> Disabling unused clock "uart1_fck"
> Disabling unused clock "uart2_fck"
> Disabling unused clock "usbtll_fck"
> Disabling unused clock "ts_fck"
> Disabling unused clock "cpefuse_fck"
> Disabling unused clock "gpt11_fck"
> Disabling unused clock "gpt10_fck"
> Disabling unused clock "dpll5_ck"
> Disabling unused clock "dpll4_m6x2_ck"
> Disabling unused clock "dpll4_m5x2_ck"
> Disabling unused clock "dpll3_m3x2_ck"
> Disabling unused clock "sys_clkout1"
> 
> The messages have KERN_INFO level and if you have serial
> console, they normally go there. I do not think it is good
> idea to print that much stuff there. Moreover, messages
> are not properly prefixed and for mortals it is not
> immeadietly clear where they come from.
> 
> Let's give them debugging level instead.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Hi, what is the destiny of this patch?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Kim Kyuwon]

Hi Artem,

Personally, I like your patch :)

Regards,
Kyuwon

On Wed, Apr 15, 2009 at 9:22 PM, Artem Bityutskiy <dedekind@yandex.ru> wrote:
> Artem Bityutskiy wrote:
>>
>> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>> Date: Thu, 9 Apr 2009 17:15:47 +0300
>> Subject: [PATCH] OMAP3: lessen amount of noisy messages
>>
>> On our system we see the following messages:
>>
>> Disabling unused clock "gpt2_ick"
>> Disabling unused clock "gpt3_ick"
>> Disabling unused clock "gpt4_ick"
>> Disabling unused clock "gpt5_ick"
>> Disabling unused clock "gpt6_ick"
>> Disabling unused clock "gpt7_ick"
>> Disabling unused clock "gpt8_ick"
>> Disabling unused clock "gpt9_ick"
>> Disabling unused clock "gpio2_dbck"
>> Disabling unused clock "gpio3_dbck"
>> Disabling unused clock "gpio4_dbck"
>> Disabling unused clock "gpio5_dbck"
>> Disabling unused clock "gpio6_dbck"
>> Disabling unused clock "gpt9_fck"
>> Disabling unused clock "gpt8_fck"
>> Disabling unused clock "gpt7_fck"
>> Disabling unused clock "gpt6_fck"
>> Disabling unused clock "gpt5_fck"
>> Disabling unused clock "gpt4_fck"
>> Disabling unused clock "gpt3_fck"
>> Disabling unused clock "gpt2_fck"
>> Disabling unused clock "wdt2_ick"
>> Disabling unused clock "wdt2_fck"
>> Disabling unused clock "gpio1_dbck"
>> Disabling unused clock "rng_ick"
>> Disabling unused clock "ssi_ick"
>> Disabling unused clock "gpt10_ick"
>> Disabling unused clock "gpt11_ick"
>> Disabling unused clock "uart1_ick"
>> Disabling unused clock "uart2_ick"
>> Disabling unused clock "usbtll_ick"
>> Disabling unused clock "ssi_ssr_fck"
>> Disabling unused clock "uart1_fck"
>> Disabling unused clock "uart2_fck"
>> Disabling unused clock "usbtll_fck"
>> Disabling unused clock "ts_fck"
>> Disabling unused clock "cpefuse_fck"
>> Disabling unused clock "gpt11_fck"
>> Disabling unused clock "gpt10_fck"
>> Disabling unused clock "dpll5_ck"
>> Disabling unused clock "dpll4_m6x2_ck"
>> Disabling unused clock "dpll4_m5x2_ck"
>> Disabling unused clock "dpll3_m3x2_ck"
>> Disabling unused clock "sys_clkout1"
>>
>> The messages have KERN_INFO level and if you have serial
>> console, they normally go there. I do not think it is good
>> idea to print that much stuff there. Moreover, messages
>> are not properly prefixed and for mortals it is not
>> immeadietly clear where they come from.
>>
>> Let's give them debugging level instead.
>>
>> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
> Hi, what is the destiny of this patch?
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Paul Walmsley]

On Wed, 15 Apr 2009, Artem Bityutskiy wrote:

> Artem Bityutskiy wrote:
> > From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> > Date: Thu, 9 Apr 2009 17:15:47 +0300
> > Subject: [PATCH] OMAP3: lessen amount of noisy messages
> > 
> > On our system we see the following messages:
> > 
> > Disabling unused clock "gpt2_ick"
> > Disabling unused clock "gpt3_ick"
> > Disabling unused clock "gpt4_ick"
> > Disabling unused clock "gpt5_ick"
> > Disabling unused clock "gpt6_ick"
> > Disabling unused clock "gpt7_ick"
> > Disabling unused clock "gpt8_ick"
> > Disabling unused clock "gpt9_ick"
> > Disabling unused clock "gpio2_dbck"
> > Disabling unused clock "gpio3_dbck"
> > Disabling unused clock "gpio4_dbck"
> > Disabling unused clock "gpio5_dbck"
> > Disabling unused clock "gpio6_dbck"
> > Disabling unused clock "gpt9_fck"
> > Disabling unused clock "gpt8_fck"
> > Disabling unused clock "gpt7_fck"
> > Disabling unused clock "gpt6_fck"
> > Disabling unused clock "gpt5_fck"
> > Disabling unused clock "gpt4_fck"
> > Disabling unused clock "gpt3_fck"
> > Disabling unused clock "gpt2_fck"
> > Disabling unused clock "wdt2_ick"
> > Disabling unused clock "wdt2_fck"
> > Disabling unused clock "gpio1_dbck"
> > Disabling unused clock "rng_ick"
> > Disabling unused clock "ssi_ick"
> > Disabling unused clock "gpt10_ick"
> > Disabling unused clock "gpt11_ick"
> > Disabling unused clock "uart1_ick"
> > Disabling unused clock "uart2_ick"
> > Disabling unused clock "usbtll_ick"
> > Disabling unused clock "ssi_ssr_fck"
> > Disabling unused clock "uart1_fck"
> > Disabling unused clock "uart2_fck"
> > Disabling unused clock "usbtll_fck"
> > Disabling unused clock "ts_fck"
> > Disabling unused clock "cpefuse_fck"
> > Disabling unused clock "gpt11_fck"
> > Disabling unused clock "gpt10_fck"
> > Disabling unused clock "dpll5_ck"
> > Disabling unused clock "dpll4_m6x2_ck"
> > Disabling unused clock "dpll4_m5x2_ck"
> > Disabling unused clock "dpll3_m3x2_ck"
> > Disabling unused clock "sys_clkout1"
> > 
> > The messages have KERN_INFO level and if you have serial
> > console, they normally go there. I do not think it is good
> > idea to print that much stuff there. Moreover, messages
> > are not properly prefixed and for mortals it is not
> > immeadietly clear where they come from.
> > 
> > Let's give them debugging level instead.
> > 
> > Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> 
> Hi, what is the destiny of this patch?

Hello Artem,

stil thinking about it.  These messages have made it easy to catch bugs 
with the PM code in the past (e.g., sad2d).  Making them debug-level will 
require booting a kernel with clock debugging specifically 
compiled in.  So I wonder if there might be a better way to deal with 
these...


- Paul

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Artem Bityutskiy]

Hi,

On Wed, 2009-04-15 at 09:22 -0600, Paul Walmsley wrote:
> stil thinking about it.  These messages have made it easy to catch bugs 
> with the PM code in the past (e.g., sad2d).  Making them debug-level will 
> require booting a kernel with clock debugging specifically 
> compiled in.  So I wonder if there might be a better way to deal with 
> these...

Yeah, I see your concern. I'm your user, and from my perspective this is
an excessive output to slow serial line.

If you do not want re-compilation, I may send a different patch
like this:

-	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
+	printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name);

in which case you would not loose the messages, but the messages
would not go to the serial line.

And then you would be able to get them from:

a) dmesg
b) syslog
c) console, just like currently, if you add "ignore_loglevel" kernel
   boot option (Documentation/kernel-parameters.txt)

Would this be better? Here is the patch, just in case.
--

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Subject: [PATCH] OMAP3: lessen amount of noisy messages

On our system we see the following messages:

Disabling unused clock "gpt2_ick"
Disabling unused clock "gpt3_ick"
Disabling unused clock "gpt4_ick"
Disabling unused clock "gpt5_ick"
Disabling unused clock "gpt6_ick"
Disabling unused clock "gpt7_ick"
Disabling unused clock "gpt8_ick"
Disabling unused clock "gpt9_ick"
Disabling unused clock "gpio2_dbck"
Disabling unused clock "gpio3_dbck"
Disabling unused clock "gpio4_dbck"
Disabling unused clock "gpio5_dbck"
Disabling unused clock "gpio6_dbck"
Disabling unused clock "gpt9_fck"
Disabling unused clock "gpt8_fck"
Disabling unused clock "gpt7_fck"
Disabling unused clock "gpt6_fck"
Disabling unused clock "gpt5_fck"
Disabling unused clock "gpt4_fck"
Disabling unused clock "gpt3_fck"
Disabling unused clock "gpt2_fck"
Disabling unused clock "wdt2_ick"
Disabling unused clock "wdt2_fck"
Disabling unused clock "gpio1_dbck"
Disabling unused clock "rng_ick"
Disabling unused clock "ssi_ick"
Disabling unused clock "gpt10_ick"
Disabling unused clock "gpt11_ick"
Disabling unused clock "uart1_ick"
Disabling unused clock "uart2_ick"
Disabling unused clock "usbtll_ick"
Disabling unused clock "ssi_ssr_fck"
Disabling unused clock "uart1_fck"
Disabling unused clock "uart2_fck"
Disabling unused clock "usbtll_fck"
Disabling unused clock "ts_fck"
Disabling unused clock "cpefuse_fck"
Disabling unused clock "gpt11_fck"
Disabling unused clock "gpt10_fck"
Disabling unused clock "dpll5_ck"
Disabling unused clock "dpll4_m6x2_ck"
Disabling unused clock "dpll4_m5x2_ck"
Disabling unused clock "dpll3_m3x2_ck"
Disabling unused clock "sys_clkout1"

The messages have KERN_INFO level and if you have serial
console, they normally go there. I do not think it is good
idea to print that much stuff there. Moreover, messages
are not properly prefixed and for mortals it is not
immeadietly clear where they come from.

Let's give them debugging level instead.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 arch/arm/mach-omap2/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index 4247a15..c4169ee 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -1035,7 +1035,7 @@ void omap2_clk_disable_unused(struct clk *clk)
 	if ((regval32 & (1 << clk->enable_bit)) == v)
 		return;
 
-	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
+	printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name);
 	if (cpu_is_omap34xx()) {
 		omap2_clk_enable(clk);
 		omap2_clk_disable(clk);
-- 
1.6.0.6

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Artem Bityutskiy]

Artem Bityutskiy wrote:
> Disabling unused clock "gpt2_ick"
> Disabling unused clock "gpt3_ick"
> Disabling unused clock "gpt4_ick"
> Disabling unused clock "gpt5_ick"
> Disabling unused clock "gpt6_ick"
> Disabling unused clock "gpt7_ick"
> Disabling unused clock "gpt8_ick"
> Disabling unused clock "gpt9_ick"
> Disabling unused clock "gpio2_dbck"
> Disabling unused clock "gpio3_dbck"
> Disabling unused clock "gpio4_dbck"
> Disabling unused clock "gpio5_dbck"
> Disabling unused clock "gpio6_dbck"
> Disabling unused clock "gpt9_fck"
> Disabling unused clock "gpt8_fck"
> Disabling unused clock "gpt7_fck"
> Disabling unused clock "gpt6_fck"
> Disabling unused clock "gpt5_fck"
> Disabling unused clock "gpt4_fck"
> Disabling unused clock "gpt3_fck"
> Disabling unused clock "gpt2_fck"
> Disabling unused clock "wdt2_ick"
> Disabling unused clock "wdt2_fck"
> Disabling unused clock "gpio1_dbck"
> Disabling unused clock "rng_ick"
> Disabling unused clock "ssi_ick"
> Disabling unused clock "gpt10_ick"
> Disabling unused clock "gpt11_ick"
> Disabling unused clock "uart1_ick"
> Disabling unused clock "uart2_ick"
> Disabling unused clock "usbtll_ick"
> Disabling unused clock "ssi_ssr_fck"
> Disabling unused clock "uart1_fck"
> Disabling unused clock "uart2_fck"
> Disabling unused clock "usbtll_fck"
> Disabling unused clock "ts_fck"
> Disabling unused clock "cpefuse_fck"
> Disabling unused clock "gpt11_fck"
> Disabling unused clock "gpt10_fck"
> Disabling unused clock "dpll5_ck"
> Disabling unused clock "dpll4_m6x2_ck"
> Disabling unused clock "dpll4_m5x2_ck"
> Disabling unused clock "dpll3_m3x2_ck"
> Disabling unused clock "sys_clkout1"
> 
> The messages have KERN_INFO level and if you have serial
> console, they normally go there. I do not think it is good
> idea to print that much stuff there. Moreover, messages
> are not properly prefixed and for mortals it is not
> immeadietly clear where they come from.
> 
> Let's give them debugging level instead.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> ---
>  arch/arm/mach-omap2/clock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
> index 4247a15..c4169ee 100644
> --- a/arch/arm/mach-omap2/clock.c
> +++ b/arch/arm/mach-omap2/clock.c
> @@ -1035,7 +1035,7 @@ void omap2_clk_disable_unused(struct clk *clk)
>  	if ((regval32 & (1 << clk->enable_bit)) == v)
>  		return;
>  
> -	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
> +	printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name);
>  	if (cpu_is_omap34xx()) {
>  		omap2_clk_enable(clk);
>  		omap2_clk_disable(clk);

Few notes. I'm just trying to clean up our system, because
it prints too much to serial line. The clocks prints are
not very bad, but I still find them a little bit excessive.
Thus, suggested a patch.

But if you think PM is in a stage when it still needs
some debugging printing, I'm not going to insist, of course.
You could do this later, when stuff is more stable.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Tony Lindgren]

* Artem Bityutskiy <dedekind@yandex.ru> [090415 09:06]:
> Artem Bityutskiy wrote:
>> Disabling unused clock "gpt2_ick"
>> Disabling unused clock "gpt3_ick"
>> Disabling unused clock "gpt4_ick"
>> Disabling unused clock "gpt5_ick"
>> Disabling unused clock "gpt6_ick"
>> Disabling unused clock "gpt7_ick"
>> Disabling unused clock "gpt8_ick"
>> Disabling unused clock "gpt9_ick"
>> Disabling unused clock "gpio2_dbck"
>> Disabling unused clock "gpio3_dbck"
>> Disabling unused clock "gpio4_dbck"
>> Disabling unused clock "gpio5_dbck"
>> Disabling unused clock "gpio6_dbck"
>> Disabling unused clock "gpt9_fck"
>> Disabling unused clock "gpt8_fck"
>> Disabling unused clock "gpt7_fck"
>> Disabling unused clock "gpt6_fck"
>> Disabling unused clock "gpt5_fck"
>> Disabling unused clock "gpt4_fck"
>> Disabling unused clock "gpt3_fck"
>> Disabling unused clock "gpt2_fck"
>> Disabling unused clock "wdt2_ick"
>> Disabling unused clock "wdt2_fck"
>> Disabling unused clock "gpio1_dbck"
>> Disabling unused clock "rng_ick"
>> Disabling unused clock "ssi_ick"
>> Disabling unused clock "gpt10_ick"
>> Disabling unused clock "gpt11_ick"
>> Disabling unused clock "uart1_ick"
>> Disabling unused clock "uart2_ick"
>> Disabling unused clock "usbtll_ick"
>> Disabling unused clock "ssi_ssr_fck"
>> Disabling unused clock "uart1_fck"
>> Disabling unused clock "uart2_fck"
>> Disabling unused clock "usbtll_fck"
>> Disabling unused clock "ts_fck"
>> Disabling unused clock "cpefuse_fck"
>> Disabling unused clock "gpt11_fck"
>> Disabling unused clock "gpt10_fck"
>> Disabling unused clock "dpll5_ck"
>> Disabling unused clock "dpll4_m6x2_ck"
>> Disabling unused clock "dpll4_m5x2_ck"
>> Disabling unused clock "dpll3_m3x2_ck"
>> Disabling unused clock "sys_clkout1"
>>
>> The messages have KERN_INFO level and if you have serial
>> console, they normally go there. I do not think it is good
>> idea to print that much stuff there. Moreover, messages
>> are not properly prefixed and for mortals it is not
>> immeadietly clear where they come from.
>>
>> Let's give them debugging level instead.
>>
>> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>> ---
>>  arch/arm/mach-omap2/clock.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
>> index 4247a15..c4169ee 100644
>> --- a/arch/arm/mach-omap2/clock.c
>> +++ b/arch/arm/mach-omap2/clock.c
>> @@ -1035,7 +1035,7 @@ void omap2_clk_disable_unused(struct clk *clk)
>>  	if ((regval32 & (1 << clk->enable_bit)) == v)
>>  		return;
>>  -	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
>> +	printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name);
>>  	if (cpu_is_omap34xx()) {
>>  		omap2_clk_enable(clk);
>>  		omap2_clk_disable(clk);
>
> Few notes. I'm just trying to clean up our system, because
> it prints too much to serial line. The clocks prints are
> not very bad, but I still find them a little bit excessive.
> Thus, suggested a patch.
>
> But if you think PM is in a stage when it still needs
> some debugging printing, I'm not going to insist, of course.
> You could do this later, when stuff is more stable.

These lines have been very informative when the boot fails
mysteriously. But I'd be fine seeing it only if debug is
specified in cmdline.

Tony

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Paul Walmsley]

Hi Artem,

On Wed, 15 Apr 2009, Artem Bityutskiy wrote:

> If you do not want re-compilation, I may send a different patch
> like this:
> 
> -	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
> +	printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name);
> 
> in which case you would not loose the messages, but the messages
> would not go to the serial line.

Yes, that patch is fine.  I'll add that to the omap-clock-upstream branch.


- Paul

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Kevin Hilman]

Artem Bityutskiy <dedekind@infradead.org> writes:

> Hi,
>
> On Wed, 2009-04-15 at 09:22 -0600, Paul Walmsley wrote:
>> stil thinking about it.  These messages have made it easy to catch bugs 
>> with the PM code in the past (e.g., sad2d).  Making them debug-level will 
>> require booting a kernel with clock debugging specifically 
>> compiled in.  So I wonder if there might be a better way to deal with 
>> these...
>
> Yeah, I see your concern. I'm your user, and from my perspective this is
> an excessive output to slow serial line.
>
> If you do not want re-compilation, I may send a different patch
> like this:
>
> -	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
> +	printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name);
>
> in which case you would not loose the messages, but the messages
> would not go to the serial line.
>

I prefer this method as well since i can see them simply by adding
debug to the cmdline.

Kevin

Re: [PATCH] OMAP3: lessen amount of noisy messages

[Artem Bityutskiy]

Kevin Hilman wrote:
> Artem Bityutskiy <dedekind@infradead.org> writes:
> 
>> Hi,
>>
>> On Wed, 2009-04-15 at 09:22 -0600, Paul Walmsley wrote:
>>> stil thinking about it.  These messages have made it easy to catch bugs 
>>> with the PM code in the past (e.g., sad2d).  Making them debug-level will 
>>> require booting a kernel with clock debugging specifically 
>>> compiled in.  So I wonder if there might be a better way to deal with 
>>> these...
>> Yeah, I see your concern. I'm your user, and from my perspective this is
>> an excessive output to slow serial line.
>>
>> If you do not want re-compilation, I may send a different patch
>> like this:
>>
>> -	printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name);
>> +	printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name);
>>
>> in which case you would not loose the messages, but the messages
>> would not go to the serial line.
>>
> 
> I prefer this method as well since i can see them simply by adding
> debug to the cmdline.
> 

Fine with me, thanks for looking at this.


-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html