n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[Kalle Valo]

Hello,

I'm trying to compile n800 kernel with latest linux-omap tree. First I
got strange build error:

arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':
arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'
arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a cast
arch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'
arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':
arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast

Adding include <linux/slab.h> made it go away but then I got this:

In file included from arch/arm/mach-omap2/clock24xx.c:46:
arch/arm/mach-omap2/clock24xx.h:1801: error: 'secure_32k_ck' undeclared here (not in a function)

Any hints?

The latest commit I have is:

commit 8e58316ba38aa6ffd53e2ada59142ad40cf47744
Merge: 1232332 0932667
Author: Tony Lindgren <tony@atomide.com>
Date:   Wed Apr 15 11:22:24 2009 -0700

    Merge branch 'omap-pool'

-- 
Kalle Valo

Re: n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[green]

[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]

Kalle Valo wrote at 2009-04-17 14:44 -0600:
> I'm trying to compile n800 kernel with latest linux-omap tree. First I
> got strange build error:

Here too, on n810.

> arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':
> arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'
> arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a cast
> arch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'
> arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':
> arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast

I see nearly the same:

arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_epoll_wait’:
arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function ‘kmalloc’
arch/arm/kernel/sys_oabi-compat.c:288: error: ‘GFP_KERNEL’ undeclared (first use in this function)
arch/arm/kernel/sys_oabi-compat.c:288: error: (Each undeclared identifier is reported only once
arch/arm/kernel/sys_oabi-compat.c:288: error: for each function it appears in.)
arch/arm/kernel/sys_oabi-compat.c:288: warning: assignment makes pointer from integer without a cast
arch/arm/kernel/sys_oabi-compat.c:301: error: implicit declaration of function ‘kfree’
arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_semtimedop’:
arch/arm/kernel/sys_oabi-compat.c:324: error: ‘GFP_KERNEL’ undeclared (first use in this function)
arch/arm/kernel/sys_oabi-compat.c:324: warning: assignment makes pointer from integer without a cast

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[Kalle Valo]

green <greenfreedom10@gmail.com> writes:

> Kalle Valo wrote at 2009-04-17 14:44 -0600:
>
>> arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':
>> arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'
>> arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a cast
>> arch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'
>> arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':
>> arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast
>
> I see nearly the same:
>
> arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_epoll_wait’:
> arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function ‘kmalloc’
> arch/arm/kernel/sys_oabi-compat.c:288: error: ‘GFP_KERNEL’ undeclared (first use in this function)

I think that's the same error. Most probably my tree was dirty and
that's the line numbers are different.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[green]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

Kalle Valo wrote at 2009-04-19 09:58 -0600:
> green <greenfreedom10@gmail.com> writes:
> 
> > Kalle Valo wrote at 2009-04-17 14:44 -0600:
> >
> >> arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':
> >> arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'
> >> arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a cast
> >> arch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'
> >> arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':
> >> arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast
> >
> > I see nearly the same:
> >
> > arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_epoll_wait’:
> > arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function ‘kmalloc’
> > arch/arm/kernel/sys_oabi-compat.c:288: error: ‘GFP_KERNEL’ undeclared (first use in this function)
> 
> I think that's the same error. Most probably my tree was dirty and
> that's the line numbers are different.

I was noticing the 'GFP_KERNEL' undeclared error rather than the line numbers.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[Tony Lindgren]

* green <greenfreedom10@gmail.com> [090419 18:43]:
> Kalle Valo wrote at 2009-04-19 09:58 -0600:
> > green <greenfreedom10@gmail.com> writes:
> > 
> > > Kalle Valo wrote at 2009-04-17 14:44 -0600:
> > >
> > >> arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':
> > >> arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'
> > >> arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a cast
> > >> arch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'
> > >> arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':
> > >> arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast
> > >
> > > I see nearly the same:
> > >
> > > arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_epoll_wait’:
> > > arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function ‘kmalloc’
> > > arch/arm/kernel/sys_oabi-compat.c:288: error: ‘GFP_KERNEL’ undeclared (first use in this function)
> > 
> > I think that's the same error. Most probably my tree was dirty and
> > that's the line numbers are different.
> 
> I was noticing the 'GFP_KERNEL' undeclared error rather than the line numbers.

Looks like the above is fixed by cbb55092a674bcfd9774637a06d0f1511763aa2c,
I'll git cherry-pick that one.

The secure_32k_ck is still undefined though.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[Paul Walmsley]

Hi Kalle,

On Fri, 17 Apr 2009, Kalle Valo wrote:

> In file included from arch/arm/mach-omap2/clock24xx.c:46:
> arch/arm/mach-omap2/clock24xx.h:1801: error: 'secure_32k_ck' undeclared here (not in a function)
>
> Any hints?

This is a bug in the version of fa9ef57a1efdd4e7c41a42db71d99b9b69e9b356 I 
pushed.  The new clock definition in clock24xx.h for "secure_32k_fck" 
should be for "secure_32k_ck".  Just talked with Tony about this; he's 
going to re-pull a fixed version of that patch today.

Thanks for the find,

- Paul

Re: n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[Paul Walmsley]

On Mon, 20 Apr 2009, Paul Walmsley wrote:

> On Fri, 17 Apr 2009, Kalle Valo wrote:
> 
> > In file included from arch/arm/mach-omap2/clock24xx.c:46:
> > arch/arm/mach-omap2/clock24xx.h:1801: error: 'secure_32k_ck' undeclared here (not in a function)
> >
> > Any hints?
> 
> This is a bug in the version of fa9ef57a1efdd4e7c41a42db71d99b9b69e9b356 I 
> pushed.  The new clock definition in clock24xx.h for "secure_32k_fck" 
> should be for "secure_32k_ck".  Just talked with Tony about this; he's 
> going to re-pull a fixed version of that patch today.

Here's the patch BTW:

- Paul


Index: linux-omap-2.6/arch/arm/mach-omap2/clock24xx.h
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/clock24xx.h	2009-04-20 10:42:21.000000000 -0700
+++ linux-omap-2.6/arch/arm/mach-omap2/clock24xx.h	2009-04-20 10:46:09.000000000 -0700
@@ -625,8 +625,8 @@ static struct clk func_32k_ck = {
 	.clkdm_name	= "wkup_clkdm",
 };
 
-static struct clk secure_32k_fck = {
-	.name		= "secure_32k_fck",
+static struct clk secure_32k_ck = {
+	.name		= "secure_32k_ck",
 	.ops		= &clkops_null,
 	.rate		= 32768,
 	.flags		= RATE_FIXED,

[APPLIED] n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[Tony Lindgren]

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Initial commit ID (Likely to change): dc1ac9cea15e3317badd0fdece931926413f6759

PatchWorks
http://patchwork.kernel.org/patch/19037/

Git
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=dc1ac9cea15e3317badd0fdece931926413f6759

Re: n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

[Kalle Valo]

Paul Walmsley <paul@pwsan.com> writes:

> Hi Kalle,

Hi Paul,

sorry for a late answer.

> On Fri, 17 Apr 2009, Kalle Valo wrote:
>
>> arch/arm/mach-omap2/clock24xx.h:1801: error: 'secure_32k_ck'
>> undeclared here (not in a function)
>>
>> Any hints?
>
> This is a bug in the version of fa9ef57a1efdd4e7c41a42db71d99b9b69e9b356 I 
> pushed.  The new clock definition in clock24xx.h for "secure_32k_fck" 
> should be for "secure_32k_ck".  Just talked with Tony about this; he's 
> going to re-pull a fixed version of that patch today.

I updated to latest linux-omap (commit 55b1274c). It now compiles and
boots on N800. 

Thank you for fixing this.

-- 
Kalle Valo