From: David Brownell <david-b@pacbell.net>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, lrg@slimlogic.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator core: fix double-free in regulator_register() error path
Date: Tue, 28 Apr 2009 02:32:56 -0700 [thread overview]
Message-ID: <200904280232.56329.david-b@pacbell.net> (raw)
In-Reply-To: <20090428081646.GC20027@rakim.wolfsonmicro.main>
On Tuesday 28 April 2009, Mark Brown wrote:
> > For the record, that "incomplete constraints" message is bogus.
> > On that board, VAUX3 has a complete set of constraints: it may
> > only emit 2.8V.
>
> It's not VAUX3 that it's saying has incomplete constraints, it's the
> board as a whole - if the constraints for the board were fully specified
No; driver support != constraint. Only one of the
issues is packaged as a "constraint".
> (and the core had been told about it) then it would power off VAUX3 at
> that point.
>
> > Mark and/or Liam ... you might want to fix that diagnostic, to
> > avoid leading more developers astray!
>
> Probably shove a "board has" in there or something I guess.
How about: "VAUX3 board support is incomplete".
That's accurate.
A comment there might suggest constraints and
driver support as two common issues ... I'd not
be surprised to see a few more idioms pop up.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-04-28 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 11:28 [PATCH] regulator core: fix double-free in regulator_register() error path Paul Walmsley
2009-04-25 22:11 ` David Brownell
2009-04-26 4:53 ` Paul Walmsley
2009-04-28 3:08 ` David Brownell
2009-04-28 8:16 ` Mark Brown
2009-04-28 9:32 ` David Brownell [this message]
2009-04-28 11:00 ` Mark Brown
2009-04-28 11:47 ` David Brownell
2009-04-28 12:47 ` Mark Brown
2009-04-26 9:23 ` Mark Brown
2009-04-27 11:40 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904280232.56329.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox