From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] regulator core: fix double-free in regulator_register() error path Date: Tue, 28 Apr 2009 09:16:46 +0100 Message-ID: <20090428081646.GC20027@rakim.wolfsonmicro.main> References: <200904272008.50268.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:44018 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760192AbZD1IQs (ORCPT ); Tue, 28 Apr 2009 04:16:48 -0400 Content-Disposition: inline In-Reply-To: <200904272008.50268.david-b@pacbell.net> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: David Brownell Cc: Paul Walmsley , linux-omap@vger.kernel.org, lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org On Mon, Apr 27, 2009 at 08:08:50PM -0700, David Brownell wrote: > On Saturday 25 April 2009, Paul Walmsley wrote: > > For the 3430SDP users out there, this patch also fixes the boot hang after > > "regulator_init_complete: incomplete constraints, leaving VAUX3 on" > > on that device. > For the record, that "incomplete constraints" message is bogus. > On that board, VAUX3 has a complete set of constraints: it may > only emit 2.8V. It's not VAUX3 that it's saying has incomplete constraints, it's the board as a whole - if the constraints for the board were fully specified (and the core had been told about it) then it would power off VAUX3 at that point. > Mark and/or Liam ... you might want to fix that diagnostic, to > avoid leading more developers astray! Probably shove a "board has" in there or something I guess.