From: Jarkko Nikula <jhnikula@gmail.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: sDMA: Correct the the omap_request_dma_chain() signature
Date: Wed, 29 Apr 2009 22:08:04 +0300 [thread overview]
Message-ID: <20090429220804.2d130ceb.jhnikula@gmail.com> (raw)
In-Reply-To: <1241006956-29268-1-git-send-email-santosh.shilimkar@ti.com>
On Wed, 29 Apr 2009 17:39:16 +0530
Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
> Original OMAP DMA chaining design has chain_id as one of the callback
> parameters. The below patch broke the desing.
> http://git.omapzoom.org/?p=repo/omapkernel.git;a=commitdiff;h=538528de0cb256f65716ab2e9613d9e920f97fe2
> Now callback returns logical channel number and not chain_id.
> Hence the signature of the omap_request_dma_chain() functions needs
> to be corrected to avoid any confusion.
>
> More details are on this email thread :
> http://marc.info/?l=linux-omap&m=122961071931459&w=2
>
Thanks! And this thread where I promised to send a patch but never done
it...
http://marc.info/?l=linux-omap&m=122770291205164&w=2
Two comments:
"Now callback returns logical channel number and not chain_id. "
You mean callback gets lch instead of chain_id as an argument?
Change also kernel-doc function comment for omap_request_dma_chain.
I.e. those comment lines few lines before the function itself.
--
Jarkko
next prev parent reply other threads:[~2009-04-29 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 12:09 [PATCH] OMAP: sDMA: Correct the the omap_request_dma_chain() signature Santosh Shilimkar
2009-04-29 19:08 ` Jarkko Nikula [this message]
2009-04-30 4:32 ` Shilimkar, Santosh
2009-04-30 4:48 ` Shilimkar, Santosh
[not found] ` <bd7b27490904300146p17cb127asf2013cc3f0840a26@mail.gmail.com>
2009-04-30 9:18 ` Shilimkar, Santosh
[not found] ` <bd7b27490904300236q458b8198x200a976b9941dc10@mail.gmail.com>
2009-04-30 9:44 ` Shilimkar, Santosh
2009-05-13 10:12 ` Shilimkar, Santosh
2009-05-18 21:26 ` [APPLIED] [PATCH] OMAP: sDMA: Correct the the Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090429220804.2d130ceb.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox