From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] onenand_init: Allow disabling sync read and write based on flags, v2 (Re: [PATCH 1/4] onenand init: Rename board-n800-flash.c to gpmc-onenand.c) Date: Mon, 4 May 2009 08:59:24 -0700 Message-ID: <20090504155922.GR12986@atomide.com> References: <65231.192.168.10.89.1241415407.squirrel@dbdmail.itg.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:50660 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757611AbZEDP71 (ORCPT ); Mon, 4 May 2009 11:59:27 -0400 Content-Disposition: inline In-Reply-To: <65231.192.168.10.89.1241415407.squirrel@dbdmail.itg.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: vimal singh Cc: dedekind@infradead.org, linux-omap@vger.kernel.org, adrian.hunter@nokia.com, Tony Lindgren * vimal singh [090503 22:36]: > > > On Fri, May 1, 2009 at 11:08 PM, Tony Lindgren wrote: > > * Tony Lindgren [090430 11:56]: > >> * Tony Lindgren [090430 07:06]: > >> > * vimal singh [090429 23:33]: > >> > > 'gpmc-onenand.c' is still confusing name. This is not going to used in > >> > > all boards anyway. > >> > > >> > Why do you think this cannot be used for all boards? > >> > > >> > The GPMC timings are totally based on the onenand chip features. > >> > >> And these two patches make omap3430sdp to work with the gpmc-onenand > >> code. Sync mode does not work, but it seems like it was never enabled > >> for sdp anyways. > >> > >> Similar patch should work for other boards too. > > > > Setting the sync_write depends on flags and processor, not just flags. > > Here's a fixed version of this patch. > OK, these both patches seems good to me... OK, thanks for looking. > Earlier I was in impression that this patch series is basically to remove > board-*-flash.c files. Since in 3430sdp boards we find out 'CS' number for > flash devices dynamically in different versions of boards. So, I was confused. Well looks like those functions are used for at least few boards, so we could have functions like gpmc_probe_onenand() and gpmc_probe_nor() functions that could be called from board-*.c files. That way we could have generic gpmc-onenand.c and gpmc-nor.c, and still do the necessary probe logic in the board-*.c files. Regards, Tony