public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Kalle Valo <kalle.valo@iki.fi>,
	Jarkko Nikula <jarkko.nikula@nokia.com>,
	linux-omap@vger.kernel.org, Roel Kluin <roel.kluin@gmail.com>
Subject: Re: [PATCH] ARM: OMAP: Fix tusb6010 init error and compilation warning
Date: Tue, 12 May 2009 10:42:46 -0700	[thread overview]
Message-ID: <20090512174246.GR5593@atomide.com> (raw)
In-Reply-To: <20090507081749.97749b2e.jhnikula@gmail.com>

* Jarkko Nikula <jhnikula@gmail.com> [090506 22:16]:
> On Thu, 23 Apr 2009 20:06:39 +0300
> Kalle Valo <kalle.valo@iki.fi> wrote:
> 
> > Jarkko Nikula <jarkko.nikula@nokia.com> writes:
> > 
> > > Fix "tusb6010 init error 5, -19" and compilation warning from
> > > function tusb6010_platform_retime "warning: 'sysclk_ps' is used
> > > uninitialized in this function".
> > >
> > > I suppose commit c094ba34b8f780885d029ce3c2715a194b780e5d was meant
> > > to test for zero fclk_ps instead of sysclk_ps.
> > 
> > I was suffering exactly this problem and this patch fixed it. Now usb
> > network works again, thanks a lot for fixing this!
> > 
> > > Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> > > Cc: Roel Kluin <roel.kluin@gmail.com>
> > 
> > Tested-by: Kalle Valo <kalle.valo@iki.fi>
> > 
> Ping? This patch was a fix for 2.6.30-rcX.

Sorry for the delay. Pushed and added to omap-fixes, so we should
still get this in.

Regards,

Tony

  reply	other threads:[~2009-05-12 17:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23  6:30 [PATCH] ARM: OMAP: Fix tusb6010 init error and compilation warning Jarkko Nikula
2009-04-23 17:06 ` Kalle Valo
2009-05-07  5:17   ` Jarkko Nikula
2009-05-12 17:42     ` Tony Lindgren [this message]
2009-05-12 17:35 ` [APPLIED] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090512174246.GR5593@atomide.com \
    --to=tony@atomide.com \
    --cc=jarkko.nikula@nokia.com \
    --cc=jhnikula@gmail.com \
    --cc=kalle.valo@iki.fi \
    --cc=linux-omap@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox