From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Patch "REMOVE OMAP LEGACY CODE: Reset mach-omap1/board-*.c files to mainline" breaks nokia770 Date: Wed, 13 May 2009 18:44:14 -0700 Message-ID: <20090514014413.GE5593@atomide.com> References: <20090514004651.77342rqoq5tz86ww@lidskialf.net> <20090514002335.GA9538@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:63432 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754181AbZENBoR (ORCPT ); Wed, 13 May 2009 21:44:17 -0400 Content-Disposition: inline In-Reply-To: <20090514002335.GA9538@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: ext Andrew de Quincey , "linux-omap@vger.kernel.org" * Felipe Balbi [090513 17:33]: > On Thu, May 14, 2009 at 01:46:51AM +0200, ext Andrew de Quincey wrote: > > Hi, I've just discovered that the patch at: > > > > http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commitdiff;h=3eae3ea7c443fc4330574dffea65b6f2f53a2574 > > > > Breaks the nokia770's framebuffer as it removes the platform data for > > the HWA742 LCD controller. > > > > As the patch says "Patches against the mainline tree are welcome to > > add back the missing functionality if needed!", I'm happy to do this. > > > > However, since I'm fairly new to the linux-omap project, is simply > > extracting the removed nokia770 code and generating a patch against > > the mainline kernel sufficient? or is there a newer style of some sort > > that should be adopted for this? > > You can start by generating the new patch against mainline and running > scripts/checkpatch.pl, then you should probably find out if there are > any API changes and stuff like that. Then send the patch to lkml ccing > linux-omap and let's see what comments do you get from those guys :-) Please change the code to pass the struct clock to drivers/video/omap/hwa742.c in hwa742_platform_data. The hw742.c can just do standard clk_enable/disable there. Otherwise we won't be able to get this missing part to the mainline kernel. Regards, Tony