Re: [PATCH 3/6] omap iommu: omap3 iommu device registration

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Sat, May 16, 2009 at 12:38:23PM +0300, Felipe Contreras wrote:
> On Sat, May 16, 2009 at 12:20 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Tue, May 05, 2009 at 03:47:00PM +0300, Hiroshi DOYU wrote:
> >> +static struct resource omap3_iommu_res[] = {
> >> +     { /* Camera ISP MMU */
> >> +             .start          = OMAP3_MMU1_BASE,
> >> +             .end            = OMAP3_MMU1_BASE + MMU_REG_SIZE - 1,
> >> +             .flags          = IORESOURCE_MEM,
> >> +     },
> >> +     {
> >> +             .start          = OMAP3_MMU1_IRQ,
> >> +             .flags          = IORESOURCE_IRQ,
> >> +     },
> >> +     { /* IVA2.2 MMU */
> >> +             .start          = OMAP3_MMU2_BASE,
> >> +             .end            = OMAP3_MMU2_BASE + MMU_REG_SIZE - 1,
> >> +             .flags          = IORESOURCE_MEM,
> >> +     },
> >> +     {
> >> +             .start          = OMAP3_MMU2_IRQ,
> >> +             .flags          = IORESOURCE_IRQ,
> >> +     },
> >> +};
> >> +#define NR_IOMMU_RES (ARRAY_SIZE(omap3_iommu_res) / 2)
> >
> > This looks all very convoluted.  Why not do something like:
> >
> > static unsigned long iommu_base[] = {
> >        OMAP3_MMU1_BASE,
> >        OMAP3_MMU2_BASE,
> > };
> >
> > static int iommu_irq[] = {
> >        OMAP3_MMU1_IRQ,
> >        OMAP3_MMU2_IRQ,
> > };
> 
> All your comments are pretty similar to my reorganize patch:
> http://marc.info/?l=linux-omap&m=124172711303076&w=2

... which hasn't been posted to linux-arm-kernel, and so I won't see it.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html