From: Tony Lindgren <tony@atomide.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org
Subject: Re: [RESUBMIT][PATCH 3/7 v2] OMAP4: Update common omap platform headers.
Date: Tue, 19 May 2009 14:18:18 -0700 [thread overview]
Message-ID: <20090519211818.GI19742@atomide.com> (raw)
In-Reply-To: <1242739907-12487-1-git-send-email-santosh.shilimkar@ti.com>
* Santosh Shilimkar <santosh.shilimkar@ti.com> [090519 06:32]:
> (patch is rebased on 2.6.30-rc6. The older version was based on 2.6.30-rc2)
>
> This patch updates the common platform headers files for OMAP4430.
> On OMAP4, GIC is used instead of INTC, hence all the private peripheral
> interrupts are shifted by an offset of 32. So if the hardcoding is not
> done for IRQ lines in drivers, then this change won't impact any driver.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/plat-omap/include/mach/clock.h | 8 ++-
> arch/arm/plat-omap/include/mach/common.h | 1 +
> arch/arm/plat-omap/include/mach/control.h | 7 +-
> arch/arm/plat-omap/include/mach/debug-macro.S | 2 +-
> arch/arm/plat-omap/include/mach/dma.h | 1 +
> arch/arm/plat-omap/include/mach/entry-macro.S | 46 ++++++++++++-
> arch/arm/plat-omap/include/mach/io.h | 37 ++++++++++
> arch/arm/plat-omap/include/mach/irqs.h | 89 +++++++++++++++++++++++++
> arch/arm/plat-omap/include/mach/memory.h | 3 +-
> arch/arm/plat-omap/include/mach/serial.h | 16 ++++-
> 10 files changed, 198 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/mach/clock.h b/arch/arm/plat-omap/include/mach/clock.h
> index 073a2c5..058a808 100644
> --- a/arch/arm/plat-omap/include/mach/clock.h
> +++ b/arch/arm/plat-omap/include/mach/clock.h
> @@ -22,7 +22,8 @@ struct clkops {
> void (*disable)(struct clk *);
> };
>
> -#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
> +#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3) || \
> + defined(CONFIG_ARCH_OMAP4)
>
> struct clksel_rate {
> u32 val;
> @@ -51,7 +52,7 @@ struct dpll_data {
> u8 max_divider;
> u32 max_tolerance;
> u16 max_multiplier;
> -# if defined(CONFIG_ARCH_OMAP3)
> +# if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
> u8 modes;
> void __iomem *autoidle_reg;
> void __iomem *idlest_reg;
Please get rid of the extra spaces in the #if defined above while at it.
Regards,
Tony
prev parent reply other threads:[~2009-05-19 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 13:31 [RESUBMIT][PATCH 3/7 v2] OMAP4: Update common omap platform headers Santosh Shilimkar
2009-05-19 21:18 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519211818.GI19742@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox