* [PATCH v3 0/3] Support for OMAP3 Zoom2 board @ 2009-05-15 21:20 Mikkel Christensen 2009-05-15 21:20 ` [PATCH v3 1/3] OMAP3:zoom2: Add support " Mikkel Christensen 2009-05-15 22:34 ` [PATCH v3 0/3] Support " Kevin Hilman 0 siblings, 2 replies; 16+ messages in thread From: Mikkel Christensen @ 2009-05-15 21:20 UTC (permalink / raw) To: linux-omap; +Cc: Mikkel Christensen The following patch series adds support for Zoom2 board. This is a new version made after comments from Kevin Hilman. An external debug board is included for console and LAN. For details refer to this site: http://www.logicpd.com/products/development-kits/texas-instruments-zoom%E2%84%A2-omap34x-ii-mdp Future work: - SMSC911x NFS mount problem - Low level debug uart need to use debug board TI wiki with FAQs on getting this board booting: https://omapzoom.org/gf/project/omapzoom/wiki/?pagename=GettingStartedWithZoomII_AKA_OMAP34XII_MDP Diffstat: configs/omap3_zoom2_defconfig | 1211 ++++++++++++++++++++++++++++++++++++ mach-omap2/Kconfig | 5 mach-omap2/Makefile | 4 mach-omap2/board-zoom2-debugboard.c | 161 ++++ mach-omap2/board-zoom2.c | 107 +++ 5 files changed, 1487 insertions(+), 1 deletion(-) ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-15 21:20 [PATCH v3 0/3] Support for OMAP3 Zoom2 board Mikkel Christensen @ 2009-05-15 21:20 ` Mikkel Christensen 2009-05-15 21:20 ` [PATCH v3 2/3] OMAP3:zoom2: Defconfig for " Mikkel Christensen 2009-05-18 21:22 ` [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 " Tony Lindgren 2009-05-15 22:34 ` [PATCH v3 0/3] Support " Kevin Hilman 1 sibling, 2 replies; 16+ messages in thread From: Mikkel Christensen @ 2009-05-15 21:20 UTC (permalink / raw) To: linux-omap; +Cc: Mikkel Christensen, Vikram Pandita This patch creates the minimal OMAP3 Zoom2 board support. Signed-off-by: Mikkel Christensen <mlc@ti.com> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> --- arch/arm/mach-omap2/board-zoom2-debugboard.c | 161 ++++++++++++++++++++++++++ arch/arm/mach-omap2/board-zoom2.c | 107 +++++++++++++++++ 2 files changed, 268 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-omap2/board-zoom2-debugboard.c create mode 100644 arch/arm/mach-omap2/board-zoom2.c diff --git a/arch/arm/mach-omap2/board-zoom2-debugboard.c b/arch/arm/mach-omap2/board-zoom2-debugboard.c new file mode 100644 index 0000000..e5686e8 --- /dev/null +++ b/arch/arm/mach-omap2/board-zoom2-debugboard.c @@ -0,0 +1,161 @@ +/* + * Copyright (C) 2009 Texas Instruments Inc. + * Mikkel Christensen <mlc@ti.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/serial_8250.h> +#include <linux/smsc911x.h> + +#include <mach/gpio.h> +#include <mach/gpmc.h> + +#define ZOOM2_SMSC911X_CS 7 +#define ZOOM2_SMSC911X_GPIO 158 +#define ZOOM2_QUADUART_CS 3 +#define ZOOM2_QUADUART_GPIO 102 +#define QUART_CLK 1843200 +#define DEBUG_BASE 0x08000000 +#define ZOOM2_ETHR_START DEBUG_BASE + +static struct resource zoom2_smsc911x_resources[] = { + [0] = { + .start = ZOOM2_ETHR_START, + .end = ZOOM2_ETHR_START + SZ_4K, + .flags = IORESOURCE_MEM, + }, + [1] = { + .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL, + }, +}; + +static struct smsc911x_platform_config zoom2_smsc911x_config = { + .irq_polarity = SMSC911X_IRQ_POLARITY_ACTIVE_LOW, + .irq_type = SMSC911X_IRQ_TYPE_OPEN_DRAIN, + .flags = SMSC911X_USE_32BIT, + .phy_interface = PHY_INTERFACE_MODE_MII, +}; + +static struct platform_device zoom2_smsc911x_device = { + .name = "smsc911x", + .id = -1, + .num_resources = ARRAY_SIZE(zoom2_smsc911x_resources), + .resource = zoom2_smsc911x_resources, + .dev = { + .platform_data = &zoom2_smsc911x_config, + }, +}; + +static inline void __init zoom2_init_smsc911x(void) +{ + int eth_cs; + unsigned long cs_mem_base; + int eth_gpio = 0; + + eth_cs = ZOOM2_SMSC911X_CS; + + if (gpmc_cs_request(eth_cs, SZ_16M, &cs_mem_base) < 0) { + printk(KERN_ERR "Failed to request GPMC mem for smsc911x\n"); + return; + } + + zoom2_smsc911x_resources[0].start = cs_mem_base + 0x0; + zoom2_smsc911x_resources[0].end = cs_mem_base + 0xff; + + eth_gpio = ZOOM2_SMSC911X_GPIO; + + zoom2_smsc911x_resources[1].start = OMAP_GPIO_IRQ(eth_gpio); + + if (gpio_request(eth_gpio, "smsc911x irq") < 0) { + printk(KERN_ERR "Failed to request GPIO%d for smsc911x IRQ\n", + eth_gpio); + return; + } + gpio_direction_input(eth_gpio); +} + +static struct plat_serial8250_port serial_platform_data[] = { + { + .mapbase = 0x10000000, + .irq = OMAP_GPIO_IRQ(102), + .flags = UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ, + .iotype = UPIO_MEM, + .regshift = 1, + .uartclk = QUART_CLK, + }, { + .flags = 0 + } +}; + +static struct platform_device zoom2_debugboard_serial_device = { + .name = "serial8250", + .id = PLAT8250_DEV_PLATFORM1, + .dev = { + .platform_data = serial_platform_data, + }, +}; + +static inline void __init zoom2_init_quaduart(void) +{ + int quart_cs; + unsigned long cs_mem_base; + int quart_gpio = 0; + + quart_cs = ZOOM2_QUADUART_CS; + + if (gpmc_cs_request(quart_cs, SZ_1M, &cs_mem_base) < 0) { + printk(KERN_ERR "Failed to request GPMC mem" + "for Quad UART(TL16CP754C)\n"); + return; + } + + quart_gpio = ZOOM2_QUADUART_GPIO; + + if (gpio_request(quart_gpio, "TL16CP754C GPIO") < 0) { + printk(KERN_ERR "Failed to request GPIO%d for TL16CP754C\n", + quart_gpio); + return; + } + gpio_direction_input(quart_gpio); +} + +static inline int omap_zoom2_debugboard_detect(void) +{ + int debug_board_detect = 0; + + debug_board_detect = ZOOM2_SMSC911X_GPIO; + + if (gpio_request(debug_board_detect, "Zoom2 debug board detect") < 0) { + printk(KERN_ERR "Failed to request GPIO%d for Zoom2 debug" + "board detect\n", debug_board_detect); + return 0; + } + gpio_direction_input(debug_board_detect); + + if (!gpio_get_value(debug_board_detect)) { + gpio_free(debug_board_detect); + return 0; + } + return 1; +} + +static struct platform_device *zoom2_devices[] __initdata = { + &zoom2_smsc911x_device, + &zoom2_debugboard_serial_device, +}; + +static int __init omap_zoom2_debugboard_init(void) +{ + if (!omap_zoom2_debugboard_detect()) + return 0; + + zoom2_init_smsc911x(); + zoom2_init_quaduart(); + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); +} +arch_initcall(omap_zoom2_debugboard_init); diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c new file mode 100644 index 0000000..5a656b3 --- /dev/null +++ b/arch/arm/mach-omap2/board-zoom2.c @@ -0,0 +1,107 @@ +/* + * Copyright (C) 2009 Texas Instruments Inc. + * Mikkel Christensen <mlc@ti.com> + * + * Modified from mach-omap2/board-ldp.c + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/platform_device.h> +#include <linux/i2c/twl4030.h> + +#include <asm/mach-types.h> +#include <asm/mach/arch.h> + +#include <mach/gpio.h> +#include <mach/common.h> +#include <mach/usb.h> + +#include "mmc-twl4030.h" + +static void __init omap_zoom2_init_irq(void) +{ + omap2_init_common_hw(NULL); + omap_init_irq(); + omap_gpio_init(); +} + +static struct omap_uart_config zoom2_uart_config __initdata = { + .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)), +}; + +static struct omap_board_config_kernel zoom2_config[] __initdata = { + { OMAP_TAG_UART, &zoom2_uart_config }, +}; + +static struct twl4030_gpio_platform_data zoom2_gpio_data = { + .gpio_base = OMAP_MAX_GPIO_LINES, + .irq_base = TWL4030_GPIO_IRQ_BASE, + .irq_end = TWL4030_GPIO_IRQ_END, +}; + +static struct twl4030_platform_data zoom2_twldata = { + .irq_base = TWL4030_IRQ_BASE, + .irq_end = TWL4030_IRQ_END, + + /* platform_data for children goes here */ + .gpio = &zoom2_gpio_data, +}; + +static struct i2c_board_info __initdata zoom2_i2c_boardinfo[] = { + { + I2C_BOARD_INFO("twl4030", 0x48), + .flags = I2C_CLIENT_WAKE, + .irq = INT_34XX_SYS_NIRQ, + .platform_data = &zoom2_twldata, + }, +}; + +static int __init omap_i2c_init(void) +{ + omap_register_i2c_bus(1, 2600, zoom2_i2c_boardinfo, + ARRAY_SIZE(zoom2_i2c_boardinfo)); + omap_register_i2c_bus(2, 400, NULL, 0); + omap_register_i2c_bus(3, 400, NULL, 0); + return 0; +} + +static struct twl4030_hsmmc_info mmc[] __initdata = { + { + .mmc = 1, + .wires = 4, + .gpio_cd = -EINVAL, + .gpio_wp = -EINVAL, + }, + {} /* Terminator */ +}; + +static void __init omap_zoom2_init(void) +{ + omap_i2c_init(); + omap_board_config = zoom2_config; + omap_board_config_size = ARRAY_SIZE(zoom2_config); + omap_serial_init(); + twl4030_mmc_init(mmc); + usb_musb_init(); +} + +static void __init omap_zoom2_map_io(void) +{ + omap2_set_globals_343x(); + omap2_map_common_io(); +} + +MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board") + .phys_io = 0x48000000, + .io_pg_offst = ((0xd8000000) >> 18) & 0xfffc, + .boot_params = 0x80000100, + .map_io = omap_zoom2_map_io, + .init_irq = omap_zoom2_init_irq, + .init_machine = omap_zoom2_init, + .timer = &omap_timer, +MACHINE_END -- 1.5.4.3 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 2/3] OMAP3:zoom2: Defconfig for Zoom2 board 2009-05-15 21:20 ` [PATCH v3 1/3] OMAP3:zoom2: Add support " Mikkel Christensen @ 2009-05-15 21:20 ` Mikkel Christensen 2009-05-15 21:20 ` [PATCH v3 3/3] OMAP3:zoom2: Makefile and Kconfig " Mikkel Christensen 2009-05-18 21:22 ` [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 " Tony Lindgren 1 sibling, 1 reply; 16+ messages in thread From: Mikkel Christensen @ 2009-05-15 21:20 UTC (permalink / raw) To: linux-omap; +Cc: Mikkel Christensen, Vikram Pandita This patch adds OMAP3 Zoom2 board defconfig. Signed-off-by: Mikkel Christensen <mlc@ti.com> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> --- arch/arm/configs/omap3_zoom2_defconfig | 1211 ++++++++++++++++++++++++++++++++ 1 files changed, 1211 insertions(+), 0 deletions(-) create mode 100644 arch/arm/configs/omap3_zoom2_defconfig diff --git a/arch/arm/configs/omap3_zoom2_defconfig b/arch/arm/configs/omap3_zoom2_defconfig new file mode 100644 index 0000000..213fe9c --- /dev/null +++ b/arch/arm/configs/omap3_zoom2_defconfig @@ -0,0 +1,1211 @@ +# +# Automatically generated make config: don't edit +# Linux kernel version: 2.6.27-rc5 +# Fri Oct 10 11:49:41 2008 +# +CONFIG_ARM=y +CONFIG_SYS_SUPPORTS_APM_EMULATION=y +CONFIG_GENERIC_GPIO=y +CONFIG_GENERIC_TIME=y +CONFIG_GENERIC_CLOCKEVENTS=y +CONFIG_MMU=y +# CONFIG_NO_IOPORT is not set +CONFIG_GENERIC_HARDIRQS=y +CONFIG_STACKTRACE_SUPPORT=y +CONFIG_HAVE_LATENCYTOP_SUPPORT=y +CONFIG_LOCKDEP_SUPPORT=y +CONFIG_TRACE_IRQFLAGS_SUPPORT=y +CONFIG_HARDIRQS_SW_RESEND=y +CONFIG_GENERIC_IRQ_PROBE=y +CONFIG_RWSEM_GENERIC_SPINLOCK=y +# CONFIG_ARCH_HAS_ILOG2_U32 is not set +# CONFIG_ARCH_HAS_ILOG2_U64 is not set +CONFIG_GENERIC_HWEIGHT=y +CONFIG_GENERIC_CALIBRATE_DELAY=y +CONFIG_ARCH_SUPPORTS_AOUT=y +CONFIG_ZONE_DMA=y +CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ=y +CONFIG_VECTORS_BASE=0xffff0000 +CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" + +# +# General setup +# +CONFIG_EXPERIMENTAL=y +CONFIG_BROKEN_ON_SMP=y +CONFIG_INIT_ENV_ARG_LIMIT=32 +CONFIG_LOCALVERSION="" +CONFIG_LOCALVERSION_AUTO=y +CONFIG_SWAP=y +CONFIG_SYSVIPC=y +CONFIG_SYSVIPC_SYSCTL=y +CONFIG_BSD_PROCESS_ACCT=y +# CONFIG_BSD_PROCESS_ACCT_V3 is not set +# CONFIG_IKCONFIG is not set +CONFIG_LOG_BUF_SHIFT=14 +# CONFIG_CGROUPS is not set +CONFIG_GROUP_SCHED=y +CONFIG_FAIR_GROUP_SCHED=y +# CONFIG_RT_GROUP_SCHED is not set +CONFIG_USER_SCHED=y +# CONFIG_CGROUP_SCHED is not set +CONFIG_SYSFS_DEPRECATED=y +CONFIG_SYSFS_DEPRECATED_V2=y +# CONFIG_RELAY is not set +# CONFIG_NAMESPACES is not set +CONFIG_BLK_DEV_INITRD=y +CONFIG_INITRAMFS_SOURCE="" +CONFIG_CC_OPTIMIZE_FOR_SIZE=y +CONFIG_SYSCTL=y +CONFIG_EMBEDDED=y +CONFIG_UID16=y +# CONFIG_SYSCTL_SYSCALL is not set +CONFIG_KALLSYMS=y +# CONFIG_KALLSYMS_ALL is not set +CONFIG_KALLSYMS_EXTRA_PASS=y +CONFIG_HOTPLUG=y +CONFIG_PRINTK=y +CONFIG_BUG=y +CONFIG_ELF_CORE=y +CONFIG_COMPAT_BRK=y +CONFIG_BASE_FULL=y +CONFIG_FUTEX=y +CONFIG_ANON_INODES=y +CONFIG_EPOLL=y +CONFIG_SIGNALFD=y +CONFIG_TIMERFD=y +CONFIG_EVENTFD=y +CONFIG_SHMEM=y +CONFIG_VM_EVENT_COUNTERS=y +CONFIG_SLAB=y +# CONFIG_SLUB is not set +# CONFIG_SLOB is not set +# CONFIG_PROFILING is not set +# CONFIG_MARKERS is not set +CONFIG_HAVE_OPROFILE=y +# CONFIG_KPROBES is not set +# CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is not set +# CONFIG_HAVE_IOREMAP_PROT is not set +CONFIG_HAVE_KPROBES=y +CONFIG_HAVE_KRETPROBES=y +# CONFIG_HAVE_ARCH_TRACEHOOK is not set +# CONFIG_HAVE_DMA_ATTRS is not set +# CONFIG_USE_GENERIC_SMP_HELPERS is not set +CONFIG_HAVE_CLK=y +CONFIG_PROC_PAGE_MONITOR=y +CONFIG_HAVE_GENERIC_DMA_COHERENT=y +CONFIG_SLABINFO=y +CONFIG_RT_MUTEXES=y +# CONFIG_TINY_SHMEM is not set +CONFIG_BASE_SMALL=0 +CONFIG_MODULES=y +# CONFIG_MODULE_FORCE_LOAD is not set +CONFIG_MODULE_UNLOAD=y +# CONFIG_MODULE_FORCE_UNLOAD is not set +CONFIG_MODVERSIONS=y +CONFIG_MODULE_SRCVERSION_ALL=y +CONFIG_KMOD=y +CONFIG_BLOCK=y +# CONFIG_LBD is not set +# CONFIG_BLK_DEV_IO_TRACE is not set +# CONFIG_LSF is not set +# CONFIG_BLK_DEV_BSG is not set +# CONFIG_BLK_DEV_INTEGRITY is not set + +# +# IO Schedulers +# +CONFIG_IOSCHED_NOOP=y +CONFIG_IOSCHED_AS=y +CONFIG_IOSCHED_DEADLINE=y +CONFIG_IOSCHED_CFQ=y +CONFIG_DEFAULT_AS=y +# CONFIG_DEFAULT_DEADLINE is not set +# CONFIG_DEFAULT_CFQ is not set +# CONFIG_DEFAULT_NOOP is not set +CONFIG_DEFAULT_IOSCHED="anticipatory" +CONFIG_CLASSIC_RCU=y + +# +# System Type +# +# CONFIG_ARCH_AAEC2000 is not set +# CONFIG_ARCH_INTEGRATOR is not set +# CONFIG_ARCH_REALVIEW is not set +# CONFIG_ARCH_VERSATILE is not set +# CONFIG_ARCH_AT91 is not set +# CONFIG_ARCH_CLPS7500 is not set +# CONFIG_ARCH_CLPS711X is not set +# CONFIG_ARCH_EBSA110 is not set +# CONFIG_ARCH_EP93XX is not set +# CONFIG_ARCH_FOOTBRIDGE is not set +# CONFIG_ARCH_NETX is not set +# CONFIG_ARCH_H720X is not set +# CONFIG_ARCH_IMX is not set +# CONFIG_ARCH_IOP13XX is not set +# CONFIG_ARCH_IOP32X is not set +# CONFIG_ARCH_IOP33X is not set +# CONFIG_ARCH_IXP23XX is not set +# CONFIG_ARCH_IXP2000 is not set +# CONFIG_ARCH_IXP4XX is not set +# CONFIG_ARCH_L7200 is not set +# CONFIG_ARCH_KIRKWOOD is not set +# CONFIG_ARCH_KS8695 is not set +# CONFIG_ARCH_NS9XXX is not set +# CONFIG_ARCH_LOKI is not set +# CONFIG_ARCH_MV78XX0 is not set +# CONFIG_ARCH_MXC is not set +# CONFIG_ARCH_ORION5X is not set +# CONFIG_ARCH_PNX4008 is not set +# CONFIG_ARCH_PXA is not set +# CONFIG_ARCH_RPC is not set +# CONFIG_ARCH_SA1100 is not set +# CONFIG_ARCH_S3C2410 is not set +# CONFIG_ARCH_SHARK is not set +# CONFIG_ARCH_LH7A40X is not set +# CONFIG_ARCH_DAVINCI is not set +CONFIG_ARCH_OMAP=y +# CONFIG_ARCH_MSM7X00A is not set + +# +# TI OMAP Implementations +# +CONFIG_ARCH_OMAP_OTG=y +# CONFIG_ARCH_OMAP1 is not set +# CONFIG_ARCH_OMAP2 is not set +CONFIG_ARCH_OMAP3=y + +# +# OMAP Feature Selections +# +# CONFIG_OMAP_DEBUG_POWERDOMAIN is not set +# CONFIG_OMAP_DEBUG_CLOCKDOMAIN is not set +# CONFIG_OMAP_RESET_CLOCKS is not set +CONFIG_OMAP_MUX=y +CONFIG_OMAP_MUX_DEBUG=y +CONFIG_OMAP_MUX_WARNINGS=y +CONFIG_OMAP_MCBSP=y +# CONFIG_OMAP_MPU_TIMER is not set +CONFIG_OMAP_32K_TIMER=y +CONFIG_OMAP_32K_TIMER_HZ=128 +CONFIG_OMAP_DM_TIMER=y +# CONFIG_OMAP_LL_DEBUG_UART1 is not set +# CONFIG_OMAP_LL_DEBUG_UART2 is not set +CONFIG_OMAP_LL_DEBUG_UART3=y +CONFIG_OMAP_SERIAL_WAKE=y +CONFIG_ARCH_OMAP34XX=y +CONFIG_ARCH_OMAP3430=y + +# +# OMAP Board Type +# +# CONFIG_MACH_OMAP3_BEAGLE is not set +# CONFIG_MACH_OMAP_LDP is not set +CONFIG_MACH_OMAP_ZOOM2=y +# CONFIG_MACH_OVERO is not set + +# +# Boot options +# + +# +# Power management +# + +# +# Processor Type +# +CONFIG_CPU_32=y +CONFIG_CPU_32v6K=y +CONFIG_CPU_V7=y +CONFIG_CPU_32v7=y +CONFIG_CPU_ABRT_EV7=y +CONFIG_CPU_PABRT_IFAR=y +CONFIG_CPU_CACHE_V7=y +CONFIG_CPU_CACHE_VIPT=y +CONFIG_CPU_COPY_V6=y +CONFIG_CPU_TLB_V7=y +CONFIG_CPU_HAS_ASID=y +CONFIG_CPU_CP15=y +CONFIG_CPU_CP15_MMU=y + +# +# Processor Features +# +CONFIG_ARM_THUMB=y +# CONFIG_ARM_THUMBEE is not set +# CONFIG_CPU_ICACHE_DISABLE is not set +# CONFIG_CPU_DCACHE_DISABLE is not set +# CONFIG_CPU_BPREDICT_DISABLE is not set +CONFIG_HAS_TLS_REG=y +# CONFIG_OUTER_CACHE is not set + +# +# Bus support +# +# CONFIG_PCI_SYSCALL is not set +# CONFIG_ARCH_SUPPORTS_MSI is not set +# CONFIG_PCCARD is not set + +# +# Kernel Features +# +CONFIG_TICK_ONESHOT=y +CONFIG_NO_HZ=y +CONFIG_HIGH_RES_TIMERS=y +CONFIG_GENERIC_CLOCKEVENTS_BUILD=y +# CONFIG_PREEMPT is not set +CONFIG_HZ=128 +CONFIG_AEABI=y +CONFIG_OABI_COMPAT=y +CONFIG_ARCH_FLATMEM_HAS_HOLES=y +# CONFIG_ARCH_DISCONTIGMEM_ENABLE is not set +CONFIG_SELECT_MEMORY_MODEL=y +CONFIG_FLATMEM_MANUAL=y +# CONFIG_DISCONTIGMEM_MANUAL is not set +# CONFIG_SPARSEMEM_MANUAL is not set +CONFIG_FLATMEM=y +CONFIG_FLAT_NODE_MEM_MAP=y +# CONFIG_SPARSEMEM_STATIC is not set +# CONFIG_SPARSEMEM_VMEMMAP_ENABLE is not set +CONFIG_PAGEFLAGS_EXTENDED=y +CONFIG_SPLIT_PTLOCK_CPUS=4 +# CONFIG_RESOURCES_64BIT is not set +CONFIG_ZONE_DMA_FLAG=1 +CONFIG_BOUNCE=y +CONFIG_VIRT_TO_BUS=y +# CONFIG_LEDS is not set +CONFIG_ALIGNMENT_TRAP=y + +# +# Boot options +# +CONFIG_ZBOOT_ROM_TEXT=0x0 +CONFIG_ZBOOT_ROM_BSS=0x0 +CONFIG_CMDLINE="root=/dev/nfs nfsroot=192.168.0.1:/home/user/buildroot ip=192.168.0.2:192.168.0.1:192.168.0.1:255.255.255.0:tgt:eth0:off rw console=ttyS2,115200n8" +# CONFIG_XIP_KERNEL is not set +# CONFIG_KEXEC is not set + +# +# CPU Frequency scaling +# +# CONFIG_CPU_FREQ is not set + +# +# Floating point emulation +# + +# +# At least one emulation must be selected +# +CONFIG_FPE_NWFPE=y +# CONFIG_FPE_NWFPE_XP is not set +# CONFIG_FPE_FASTFPE is not set +CONFIG_VFP=y +CONFIG_VFPv3=y +# CONFIG_NEON is not set + +# +# Userspace binary formats +# +CONFIG_BINFMT_ELF=y +# CONFIG_BINFMT_AOUT is not set +CONFIG_BINFMT_MISC=y + +# +# Power management options +# +# CONFIG_PM is not set +CONFIG_ARCH_SUSPEND_POSSIBLE=y +CONFIG_NET=y + +# +# Networking options +# +CONFIG_PACKET=y +# CONFIG_PACKET_MMAP is not set +CONFIG_UNIX=y +CONFIG_XFRM=y +CONFIG_XFRM_USER=y +# CONFIG_XFRM_SUB_POLICY is not set +CONFIG_XFRM_MIGRATE=y +# CONFIG_XFRM_STATISTICS is not set +CONFIG_NET_KEY=y +CONFIG_NET_KEY_MIGRATE=y +CONFIG_INET=y +CONFIG_IP_MULTICAST=y +# CONFIG_IP_ADVANCED_ROUTER is not set +CONFIG_IP_FIB_HASH=y +CONFIG_IP_PNP=y +CONFIG_IP_PNP_DHCP=y +CONFIG_IP_PNP_BOOTP=y +CONFIG_IP_PNP_RARP=y +# CONFIG_NET_IPIP is not set +# CONFIG_NET_IPGRE is not set +# CONFIG_IP_MROUTE is not set +# CONFIG_ARPD is not set +# CONFIG_SYN_COOKIES is not set +# CONFIG_INET_AH is not set +# CONFIG_INET_ESP is not set +# CONFIG_INET_IPCOMP is not set +# CONFIG_INET_XFRM_TUNNEL is not set +# CONFIG_INET_TUNNEL is not set +CONFIG_INET_XFRM_MODE_TRANSPORT=y +CONFIG_INET_XFRM_MODE_TUNNEL=y +CONFIG_INET_XFRM_MODE_BEET=y +# CONFIG_INET_LRO is not set +CONFIG_INET_DIAG=y +CONFIG_INET_TCP_DIAG=y +# CONFIG_TCP_CONG_ADVANCED is not set +CONFIG_TCP_CONG_CUBIC=y +CONFIG_DEFAULT_TCP_CONG="cubic" +# CONFIG_TCP_MD5SIG is not set +# CONFIG_IPV6 is not set +# CONFIG_NETWORK_SECMARK is not set +# CONFIG_NETFILTER is not set +# CONFIG_IP_DCCP is not set +# CONFIG_IP_SCTP is not set +# CONFIG_TIPC is not set +# CONFIG_ATM is not set +# CONFIG_BRIDGE is not set +# CONFIG_NET_DSA is not set +# CONFIG_VLAN_8021Q is not set +# CONFIG_DECNET is not set +# CONFIG_LLC2 is not set +# CONFIG_IPX is not set +# CONFIG_ATALK is not set +# CONFIG_X25 is not set +# CONFIG_LAPB is not set +# CONFIG_ECONET is not set +# CONFIG_WAN_ROUTER is not set +# CONFIG_NET_SCHED is not set + +# +# Network testing +# +# CONFIG_NET_PKTGEN is not set +# CONFIG_HAMRADIO is not set +# CONFIG_CAN is not set +# CONFIG_IRDA is not set +# CONFIG_BT is not set +# CONFIG_AF_RXRPC is not set +# CONFIG_PHONET is not set +# CONFIG_WIRELESS is not set +# CONFIG_RFKILL is not set +# CONFIG_NET_9P is not set + +# +# Device Drivers +# + +# +# Generic Driver Options +# +CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" +CONFIG_STANDALONE=y +CONFIG_PREVENT_FIRMWARE_BUILD=y +# CONFIG_FW_LOADER is not set +# CONFIG_DEBUG_DRIVER is not set +# CONFIG_DEBUG_DEVRES is not set +# CONFIG_SYS_HYPERVISOR is not set +CONFIG_CONNECTOR=y +CONFIG_PROC_EVENTS=y +# CONFIG_MTD is not set +# CONFIG_PARPORT is not set +CONFIG_BLK_DEV=y +# CONFIG_BLK_DEV_COW_COMMON is not set +CONFIG_BLK_DEV_LOOP=y +# CONFIG_BLK_DEV_CRYPTOLOOP is not set +CONFIG_BLK_DEV_RAM=y +CONFIG_BLK_DEV_RAM_COUNT=16 +CONFIG_BLK_DEV_RAM_SIZE=16384 +# CONFIG_BLK_DEV_XIP is not set +# CONFIG_CDROM_PKTCDVD is not set +CONFIG_MISC_DEVICES=y +# CONFIG_EEPROM_93CX6 is not set +# CONFIG_ENCLOSURE_SERVICES is not set +CONFIG_HAVE_IDE=y +# CONFIG_IDE is not set + +# +# SCSI device support +# +# CONFIG_RAID_ATTRS is not set +CONFIG_SCSI=y +CONFIG_SCSI_DMA=y +# CONFIG_SCSI_TGT is not set +# CONFIG_SCSI_NETLINK is not set +CONFIG_SCSI_PROC_FS=y + +# +# SCSI support type (disk, tape, CD-ROM) +# +CONFIG_BLK_DEV_SD=y +# CONFIG_CHR_DEV_ST is not set +# CONFIG_CHR_DEV_OSST is not set +# CONFIG_BLK_DEV_SR is not set +# CONFIG_CHR_DEV_SG is not set +# CONFIG_CHR_DEV_SCH is not set + +# +# Some SCSI devices (e.g. CD jukebox) support multiple LUNs +# +# CONFIG_SCSI_MULTI_LUN is not set +# CONFIG_SCSI_CONSTANTS is not set +# CONFIG_SCSI_LOGGING is not set +# CONFIG_SCSI_SCAN_ASYNC is not set +CONFIG_SCSI_WAIT_SCAN=m + +# +# SCSI Transports +# +# CONFIG_SCSI_SPI_ATTRS is not set +# CONFIG_SCSI_FC_ATTRS is not set +# CONFIG_SCSI_SAS_LIBSAS is not set +# CONFIG_SCSI_SRP_ATTRS is not set +CONFIG_SCSI_LOWLEVEL=y +# CONFIG_SCSI_DEBUG is not set +# CONFIG_SCSI_DH is not set +# CONFIG_ATA is not set +# CONFIG_MD is not set +CONFIG_NETDEVICES=y +# CONFIG_DUMMY is not set +# CONFIG_BONDING is not set +# CONFIG_MACVLAN is not set +# CONFIG_EQUALIZER is not set +# CONFIG_TUN is not set +# CONFIG_VETH is not set +CONFIG_PHYLIB=y + +# +# MII PHY device drivers +# +# CONFIG_MARVELL_PHY is not set +# CONFIG_DAVICOM_PHY is not set +# CONFIG_QSEMI_PHY is not set +# CONFIG_LXT_PHY is not set +# CONFIG_CICADA_PHY is not set +# CONFIG_VITESSE_PHY is not set +CONFIG_SMSC_PHY=y +# CONFIG_BROADCOM_PHY is not set +# CONFIG_ICPLUS_PHY is not set +# CONFIG_REALTEK_PHY is not set +# CONFIG_NATIONAL_PHY is not set +# CONFIG_STE10XP is not set +# CONFIG_LSI_ET1011C_PHY is not set +# CONFIG_FIXED_PHY is not set +# CONFIG_MDIO_BITBANG is not set +CONFIG_NET_ETHERNET=y +CONFIG_MII=y +# CONFIG_AX88796 is not set +# CONFIG_SMC91X is not set +# CONFIG_DM9000 is not set +# CONFIG_ENC28J60 is not set +# CONFIG_SMC911X is not set +CONFIG_SMSC911X=y +# CONFIG_IBM_NEW_EMAC_ZMII is not set +# CONFIG_IBM_NEW_EMAC_RGMII is not set +# CONFIG_IBM_NEW_EMAC_TAH is not set +# CONFIG_IBM_NEW_EMAC_EMAC4 is not set +# CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL is not set +# CONFIG_IBM_NEW_EMAC_MAL_CLR_ICINTSTAT is not set +# CONFIG_IBM_NEW_EMAC_MAL_COMMON_ERR is not set +# CONFIG_B44 is not set +CONFIG_NETDEV_1000=y +CONFIG_NETDEV_10000=y + +# +# Wireless LAN +# +# CONFIG_WLAN_PRE80211 is not set +# CONFIG_WLAN_80211 is not set +# CONFIG_IWLWIFI_LEDS is not set + +# +# USB Network Adapters +# +# CONFIG_USB_CATC is not set +# CONFIG_USB_KAWETH is not set +# CONFIG_USB_PEGASUS is not set +# CONFIG_USB_RTL8150 is not set +# CONFIG_USB_USBNET is not set +# CONFIG_WAN is not set +# CONFIG_PPP is not set +# CONFIG_SLIP is not set +# CONFIG_NETCONSOLE is not set +# CONFIG_NETPOLL is not set +# CONFIG_NET_POLL_CONTROLLER is not set +# CONFIG_ISDN is not set + +# +# Input device support +# +CONFIG_INPUT=y +# CONFIG_INPUT_FF_MEMLESS is not set +# CONFIG_INPUT_POLLDEV is not set + +# +# Userland interfaces +# +# CONFIG_INPUT_MOUSEDEV is not set +# CONFIG_INPUT_JOYDEV is not set +CONFIG_INPUT_EVDEV=y +# CONFIG_INPUT_EVBUG is not set + +# +# Input Device Drivers +# +# CONFIG_INPUT_KEYBOARD is not set +# CONFIG_INPUT_MOUSE is not set +# CONFIG_INPUT_JOYSTICK is not set +# CONFIG_INPUT_TABLET is not set +CONFIG_INPUT_TOUCHSCREEN=y +CONFIG_TOUCHSCREEN_ADS7846=y +# CONFIG_TOUCHSCREEN_FUJITSU is not set +# CONFIG_TOUCHSCREEN_GUNZE is not set +# CONFIG_TOUCHSCREEN_ELO is not set +# CONFIG_TOUCHSCREEN_MTOUCH is not set +# CONFIG_TOUCHSCREEN_INEXIO is not set +# CONFIG_TOUCHSCREEN_MK712 is not set +# CONFIG_TOUCHSCREEN_PENMOUNT is not set +# CONFIG_TOUCHSCREEN_TOUCHRIGHT is not set +# CONFIG_TOUCHSCREEN_TOUCHWIN is not set +# CONFIG_TOUCHSCREEN_UCB1400 is not set +# CONFIG_TOUCHSCREEN_TOUCHIT213 is not set +# CONFIG_INPUT_MISC is not set + +# +# Hardware I/O ports +# +# CONFIG_SERIO is not set +# CONFIG_GAMEPORT is not set + +# +# Character devices +# +CONFIG_VT=y +CONFIG_CONSOLE_TRANSLATIONS=y +CONFIG_VT_CONSOLE=y +CONFIG_HW_CONSOLE=y +# CONFIG_VT_HW_CONSOLE_BINDING is not set +CONFIG_DEVKMEM=y +# CONFIG_SERIAL_NONSTANDARD is not set + +# +# Serial drivers +# +CONFIG_SERIAL_8250=y +CONFIG_SERIAL_8250_CONSOLE=y +CONFIG_SERIAL_8250_NR_UARTS=32 +CONFIG_SERIAL_8250_RUNTIME_UARTS=4 +CONFIG_SERIAL_8250_EXTENDED=y +CONFIG_SERIAL_8250_MANY_PORTS=y +CONFIG_SERIAL_8250_SHARE_IRQ=y +CONFIG_SERIAL_8250_DETECT_IRQ=y +CONFIG_SERIAL_8250_RSA=y + +# +# Non-8250 serial port support +# +CONFIG_SERIAL_CORE=y +CONFIG_SERIAL_CORE_CONSOLE=y +CONFIG_UNIX98_PTYS=y +# CONFIG_LEGACY_PTYS is not set +# CONFIG_IPMI_HANDLER is not set +CONFIG_HW_RANDOM=y +# CONFIG_NVRAM is not set +# CONFIG_R3964 is not set +# CONFIG_RAW_DRIVER is not set +# CONFIG_TCG_TPM is not set +CONFIG_I2C=y +CONFIG_I2C_BOARDINFO=y +CONFIG_I2C_CHARDEV=y +CONFIG_I2C_HELPER_AUTO=y + +# +# I2C Hardware Bus support +# + +# +# I2C system bus drivers (mostly embedded / system-on-chip) +# +# CONFIG_I2C_GPIO is not set +# CONFIG_I2C_OCORES is not set +CONFIG_I2C_OMAP=y +# CONFIG_I2C_SIMTEC is not set + +# +# External I2C/SMBus adapter drivers +# +# CONFIG_I2C_PARPORT_LIGHT is not set +# CONFIG_I2C_TAOS_EVM is not set + +# +# Other I2C/SMBus bus drivers +# +# CONFIG_I2C_PCA_PLATFORM is not set +# CONFIG_I2C_STUB is not set + +# +# Miscellaneous I2C Chip support +# +# CONFIG_DS1682 is not set +# CONFIG_EEPROM_AT24 is not set +# CONFIG_EEPROM_LEGACY is not set +# CONFIG_SENSORS_PCF8574 is not set +# CONFIG_PCF8575 is not set +# CONFIG_SENSORS_PCA9539 is not set +# CONFIG_SENSORS_PCF8591 is not set +# CONFIG_ISP1301_OMAP is not set +# CONFIG_TPS65010 is not set +# CONFIG_SENSORS_MAX6875 is not set +# CONFIG_SENSORS_TSL2550 is not set +# CONFIG_I2C_DEBUG_CORE is not set +# CONFIG_I2C_DEBUG_ALGO is not set +# CONFIG_I2C_DEBUG_BUS is not set +# CONFIG_I2C_DEBUG_CHIP is not set +CONFIG_SPI=y +# CONFIG_SPI_DEBUG is not set +CONFIG_SPI_MASTER=y + +# +# SPI Master Controller Drivers +# +# CONFIG_SPI_BITBANG is not set +CONFIG_SPI_OMAP24XX=y + +# +# SPI Protocol Masters +# +# CONFIG_EEPROM_AT25 is not set +# CONFIG_SPI_SPIDEV is not set +# CONFIG_SPI_TLE62X0 is not set +CONFIG_ARCH_REQUIRE_GPIOLIB=y +CONFIG_GPIOLIB=y +# CONFIG_DEBUG_GPIO is not set +# CONFIG_GPIO_SYSFS is not set + +# +# I2C GPIO expanders: +# +# CONFIG_GPIO_MAX732X is not set +# CONFIG_GPIO_PCA953X is not set +# CONFIG_GPIO_PCF857X is not set + +# +# PCI GPIO expanders: +# + +# +# SPI GPIO expanders: +# +# CONFIG_GPIO_MAX7301 is not set +# CONFIG_GPIO_MCP23S08 is not set +CONFIG_W1=y + +# +# 1-wire Bus Masters +# +# CONFIG_W1_MASTER_DS2482 is not set +# CONFIG_W1_MASTER_DS1WM is not set +# CONFIG_W1_MASTER_GPIO is not set + +# +# 1-wire Slaves +# +# CONFIG_W1_SLAVE_THERM is not set +# CONFIG_W1_SLAVE_SMEM is not set +# CONFIG_W1_SLAVE_DS2433 is not set +# CONFIG_W1_SLAVE_DS2760 is not set +CONFIG_POWER_SUPPLY=y +# CONFIG_POWER_SUPPLY_DEBUG is not set +# CONFIG_PDA_POWER is not set +# CONFIG_BATTERY_DS2760 is not set +# CONFIG_HWMON is not set +CONFIG_WATCHDOG=y +CONFIG_WATCHDOG_NOWAYOUT=y + +# +# Watchdog Device Drivers +# +# CONFIG_SOFT_WATCHDOG is not set + +# +# Sonics Silicon Backplane +# +CONFIG_SSB_POSSIBLE=y +# CONFIG_SSB is not set + +# +# Multifunction device drivers +# +# CONFIG_MFD_CORE is not set +# CONFIG_MFD_SM501 is not set +# CONFIG_HTC_EGPIO is not set +# CONFIG_HTC_PASIC3 is not set +# CONFIG_MFD_TMIO is not set +# CONFIG_MFD_T7L66XB is not set +# CONFIG_MFD_TC6387XB is not set +# CONFIG_MFD_TC6393XB is not set + +# +# Multimedia devices +# + +# +# Multimedia core support +# +# CONFIG_VIDEO_DEV is not set +# CONFIG_VIDEO_MEDIA is not set + +# +# Multimedia drivers +# +CONFIG_DAB=y + +# +# Graphics support +# +# CONFIG_VGASTATE is not set +CONFIG_VIDEO_OUTPUT_CONTROL=m +# CONFIG_FB is not set +# CONFIG_BACKLIGHT_LCD_SUPPORT is not set + +# +# Display device support +# +# CONFIG_DISPLAY_SUPPORT is not set + +# +# Console display driver support +# +# CONFIG_VGA_CONSOLE is not set +CONFIG_DUMMY_CONSOLE=y +CONFIG_SOUND=y +CONFIG_SND=y +# CONFIG_SND_SEQUENCER is not set +# CONFIG_SND_MIXER_OSS is not set +# CONFIG_SND_PCM_OSS is not set +# CONFIG_SND_DYNAMIC_MINORS is not set +CONFIG_SND_SUPPORT_OLD_API=y +CONFIG_SND_VERBOSE_PROCFS=y +# CONFIG_SND_VERBOSE_PRINTK is not set +# CONFIG_SND_DEBUG is not set +CONFIG_SND_DRIVERS=y +# CONFIG_SND_DUMMY is not set +# CONFIG_SND_MTPAV is not set +# CONFIG_SND_SERIAL_U16550 is not set +# CONFIG_SND_MPU401 is not set +CONFIG_SND_ARM=y +CONFIG_SND_SPI=y +# CONFIG_SND_SOC is not set +# CONFIG_SOUND_PRIME is not set +CONFIG_HID_SUPPORT=y +CONFIG_HID=y +# CONFIG_HID_DEBUG is not set +# CONFIG_HIDRAW is not set +# CONFIG_USB_SUPPORT is not set +CONFIG_MMC=y +# CONFIG_MMC_DEBUG is not set +# CONFIG_MMC_UNSAFE_RESUME is not set + +# +# MMC/SD Card Drivers +# +CONFIG_MMC_BLOCK=y +CONFIG_MMC_BLOCK_BOUNCE=y +# CONFIG_SDIO_UART is not set +# CONFIG_MMC_TEST is not set + +# +# MMC/SD Host Controller Drivers +# +# CONFIG_MMC_SDHCI is not set +# CONFIG_MMC_OMAP is not set +# CONFIG_MMC_SPI is not set +# CONFIG_NEW_LEDS is not set +CONFIG_RTC_LIB=y +CONFIG_RTC_CLASS=y +CONFIG_RTC_HCTOSYS=y +CONFIG_RTC_HCTOSYS_DEVICE="rtc0" +# CONFIG_RTC_DEBUG is not set + +# +# RTC interfaces +# +CONFIG_RTC_INTF_SYSFS=y +CONFIG_RTC_INTF_PROC=y +CONFIG_RTC_INTF_DEV=y +# CONFIG_RTC_INTF_DEV_UIE_EMUL is not set +# CONFIG_RTC_DRV_TEST is not set + +# +# I2C RTC drivers +# +# CONFIG_RTC_DRV_DS1307 is not set +# CONFIG_RTC_DRV_DS1374 is not set +# CONFIG_RTC_DRV_DS1672 is not set +# CONFIG_RTC_DRV_MAX6900 is not set +# CONFIG_RTC_DRV_RS5C372 is not set +# CONFIG_RTC_DRV_ISL1208 is not set +# CONFIG_RTC_DRV_X1205 is not set +# CONFIG_RTC_DRV_PCF8563 is not set +# CONFIG_RTC_DRV_PCF8583 is not set +# CONFIG_RTC_DRV_M41T80 is not set +# CONFIG_RTC_DRV_S35390A is not set +# CONFIG_RTC_DRV_FM3130 is not set + +# +# SPI RTC drivers +# +# CONFIG_RTC_DRV_M41T94 is not set +# CONFIG_RTC_DRV_DS1305 is not set +# CONFIG_RTC_DRV_MAX6902 is not set +# CONFIG_RTC_DRV_R9701 is not set +# CONFIG_RTC_DRV_RS5C348 is not set + +# +# Platform RTC drivers +# +# CONFIG_RTC_DRV_CMOS is not set +# CONFIG_RTC_DRV_DS1511 is not set +# CONFIG_RTC_DRV_DS1553 is not set +# CONFIG_RTC_DRV_DS1742 is not set +# CONFIG_RTC_DRV_STK17TA8 is not set +# CONFIG_RTC_DRV_M48T86 is not set +# CONFIG_RTC_DRV_M48T59 is not set +# CONFIG_RTC_DRV_V3020 is not set + +# +# on-CPU RTC drivers +# +# CONFIG_DMADEVICES is not set + +# +# Voltage and Current regulators +# +# CONFIG_REGULATOR is not set +# CONFIG_REGULATOR_FIXED_VOLTAGE is not set +# CONFIG_REGULATOR_VIRTUAL_CONSUMER is not set +# CONFIG_REGULATOR_BQ24022 is not set +# CONFIG_UIO is not set + +# +# File systems +# +CONFIG_EXT2_FS=y +# CONFIG_EXT2_FS_XATTR is not set +# CONFIG_EXT2_FS_XIP is not set +CONFIG_EXT3_FS=y +# CONFIG_EXT3_FS_XATTR is not set +# CONFIG_EXT4DEV_FS is not set +CONFIG_JBD=y +# CONFIG_REISERFS_FS is not set +# CONFIG_JFS_FS is not set +# CONFIG_FS_POSIX_ACL is not set +# CONFIG_XFS_FS is not set +CONFIG_DNOTIFY=y +CONFIG_INOTIFY=y +CONFIG_INOTIFY_USER=y +CONFIG_QUOTA=y +CONFIG_PRINT_QUOTA_WARNING=y +# CONFIG_QFMT_V1 is not set +CONFIG_QFMT_V2=y +CONFIG_QUOTACTL=y +# CONFIG_AUTOFS_FS is not set +# CONFIG_AUTOFS4_FS is not set +# CONFIG_FUSE_FS is not set + +# +# CD-ROM/DVD Filesystems +# +# CONFIG_ISO9660_FS is not set +# CONFIG_UDF_FS is not set + +# +# DOS/FAT/NT Filesystems +# +CONFIG_FAT_FS=y +CONFIG_MSDOS_FS=y +CONFIG_VFAT_FS=y +CONFIG_FAT_DEFAULT_CODEPAGE=437 +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" +# CONFIG_NTFS_FS is not set + +# +# Pseudo filesystems +# +CONFIG_PROC_FS=y +CONFIG_PROC_SYSCTL=y +CONFIG_SYSFS=y +CONFIG_TMPFS=y +# CONFIG_TMPFS_POSIX_ACL is not set +# CONFIG_HUGETLB_PAGE is not set +# CONFIG_CONFIGFS_FS is not set + +# +# Miscellaneous filesystems +# +# CONFIG_ADFS_FS is not set +# CONFIG_AFFS_FS is not set +# CONFIG_HFS_FS is not set +# CONFIG_HFSPLUS_FS is not set +# CONFIG_BEFS_FS is not set +# CONFIG_BFS_FS is not set +# CONFIG_EFS_FS is not set +# CONFIG_CRAMFS is not set +# CONFIG_VXFS_FS is not set +# CONFIG_MINIX_FS is not set +# CONFIG_OMFS_FS is not set +# CONFIG_HPFS_FS is not set +# CONFIG_QNX4FS_FS is not set +# CONFIG_ROMFS_FS is not set +# CONFIG_SYSV_FS is not set +# CONFIG_UFS_FS is not set +CONFIG_NETWORK_FILESYSTEMS=y +CONFIG_NFS_FS=y +CONFIG_NFS_V3=y +CONFIG_NFS_V3_ACL=y +CONFIG_NFS_V4=y +CONFIG_ROOT_NFS=y +# CONFIG_NFSD is not set +CONFIG_LOCKD=y +CONFIG_LOCKD_V4=y +CONFIG_NFS_ACL_SUPPORT=y +CONFIG_NFS_COMMON=y +CONFIG_SUNRPC=y +CONFIG_SUNRPC_GSS=y +# CONFIG_SUNRPC_REGISTER_V4 is not set +CONFIG_RPCSEC_GSS_KRB5=y +# CONFIG_RPCSEC_GSS_SPKM3 is not set +# CONFIG_SMB_FS is not set +# CONFIG_CIFS is not set +# CONFIG_NCP_FS is not set +# CONFIG_CODA_FS is not set +# CONFIG_AFS_FS is not set + +# +# Partition Types +# +CONFIG_PARTITION_ADVANCED=y +# CONFIG_ACORN_PARTITION is not set +# CONFIG_OSF_PARTITION is not set +# CONFIG_AMIGA_PARTITION is not set +# CONFIG_ATARI_PARTITION is not set +# CONFIG_MAC_PARTITION is not set +CONFIG_MSDOS_PARTITION=y +# CONFIG_BSD_DISKLABEL is not set +# CONFIG_MINIX_SUBPARTITION is not set +# CONFIG_SOLARIS_X86_PARTITION is not set +# CONFIG_UNIXWARE_DISKLABEL is not set +# CONFIG_LDM_PARTITION is not set +# CONFIG_SGI_PARTITION is not set +# CONFIG_ULTRIX_PARTITION is not set +# CONFIG_SUN_PARTITION is not set +# CONFIG_KARMA_PARTITION is not set +# CONFIG_EFI_PARTITION is not set +# CONFIG_SYSV68_PARTITION is not set +CONFIG_NLS=y +CONFIG_NLS_DEFAULT="iso8859-1" +CONFIG_NLS_CODEPAGE_437=y +# CONFIG_NLS_CODEPAGE_737 is not set +# CONFIG_NLS_CODEPAGE_775 is not set +# CONFIG_NLS_CODEPAGE_850 is not set +# CONFIG_NLS_CODEPAGE_852 is not set +# CONFIG_NLS_CODEPAGE_855 is not set +# CONFIG_NLS_CODEPAGE_857 is not set +# CONFIG_NLS_CODEPAGE_860 is not set +# CONFIG_NLS_CODEPAGE_861 is not set +# CONFIG_NLS_CODEPAGE_862 is not set +# CONFIG_NLS_CODEPAGE_863 is not set +# CONFIG_NLS_CODEPAGE_864 is not set +# CONFIG_NLS_CODEPAGE_865 is not set +# CONFIG_NLS_CODEPAGE_866 is not set +# CONFIG_NLS_CODEPAGE_869 is not set +# CONFIG_NLS_CODEPAGE_936 is not set +# CONFIG_NLS_CODEPAGE_950 is not set +# CONFIG_NLS_CODEPAGE_932 is not set +# CONFIG_NLS_CODEPAGE_949 is not set +# CONFIG_NLS_CODEPAGE_874 is not set +# CONFIG_NLS_ISO8859_8 is not set +# CONFIG_NLS_CODEPAGE_1250 is not set +# CONFIG_NLS_CODEPAGE_1251 is not set +# CONFIG_NLS_ASCII is not set +CONFIG_NLS_ISO8859_1=y +# CONFIG_NLS_ISO8859_2 is not set +# CONFIG_NLS_ISO8859_3 is not set +# CONFIG_NLS_ISO8859_4 is not set +# CONFIG_NLS_ISO8859_5 is not set +# CONFIG_NLS_ISO8859_6 is not set +# CONFIG_NLS_ISO8859_7 is not set +# CONFIG_NLS_ISO8859_9 is not set +# CONFIG_NLS_ISO8859_13 is not set +# CONFIG_NLS_ISO8859_14 is not set +# CONFIG_NLS_ISO8859_15 is not set +# CONFIG_NLS_KOI8_R is not set +# CONFIG_NLS_KOI8_U is not set +# CONFIG_NLS_UTF8 is not set + +# +# Kernel hacking +# +# CONFIG_PRINTK_TIME is not set +CONFIG_ENABLE_WARN_DEPRECATED=y +CONFIG_ENABLE_MUST_CHECK=y +CONFIG_FRAME_WARN=1024 +CONFIG_MAGIC_SYSRQ=y +# CONFIG_UNUSED_SYMBOLS is not set +# CONFIG_DEBUG_FS is not set +# CONFIG_HEADERS_CHECK is not set +CONFIG_DEBUG_KERNEL=y +# CONFIG_DEBUG_SHIRQ is not set +CONFIG_DETECT_SOFTLOCKUP=y +# CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC is not set +CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC_VALUE=0 +CONFIG_SCHED_DEBUG=y +# CONFIG_SCHEDSTATS is not set +# CONFIG_TIMER_STATS is not set +# CONFIG_DEBUG_OBJECTS is not set +# CONFIG_DEBUG_SLAB is not set +# CONFIG_DEBUG_RT_MUTEXES is not set +# CONFIG_RT_MUTEX_TESTER is not set +# CONFIG_DEBUG_SPINLOCK is not set +CONFIG_DEBUG_MUTEXES=y +# CONFIG_DEBUG_LOCK_ALLOC is not set +# CONFIG_PROVE_LOCKING is not set +# CONFIG_LOCK_STAT is not set +# CONFIG_DEBUG_SPINLOCK_SLEEP is not set +# CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set +# CONFIG_DEBUG_KOBJECT is not set +# CONFIG_DEBUG_BUGVERBOSE is not set +CONFIG_DEBUG_INFO=y +# CONFIG_DEBUG_VM is not set +# CONFIG_DEBUG_WRITECOUNT is not set +# CONFIG_DEBUG_MEMORY_INIT is not set +# CONFIG_DEBUG_LIST is not set +# CONFIG_DEBUG_SG is not set +CONFIG_FRAME_POINTER=y +# CONFIG_BOOT_PRINTK_DELAY is not set +# CONFIG_RCU_TORTURE_TEST is not set +# CONFIG_BACKTRACE_SELF_TEST is not set +# CONFIG_FAULT_INJECTION is not set +# CONFIG_LATENCYTOP is not set +CONFIG_HAVE_FTRACE=y +CONFIG_HAVE_DYNAMIC_FTRACE=y +# CONFIG_FTRACE is not set +# CONFIG_IRQSOFF_TRACER is not set +# CONFIG_SCHED_TRACER is not set +# CONFIG_CONTEXT_SWITCH_TRACER is not set +# CONFIG_SAMPLES is not set +CONFIG_HAVE_ARCH_KGDB=y +# CONFIG_KGDB is not set +# CONFIG_DEBUG_USER is not set +# CONFIG_DEBUG_ERRORS is not set +# CONFIG_DEBUG_STACK_USAGE is not set +CONFIG_DEBUG_LL=y +# CONFIG_DEBUG_ICEDCC is not set + +# +# Security options +# +# CONFIG_KEYS is not set +# CONFIG_SECURITY is not set +# CONFIG_SECURITY_FILE_CAPABILITIES is not set +CONFIG_CRYPTO=y + +# +# Crypto core or helper +# +CONFIG_CRYPTO_ALGAPI=y +CONFIG_CRYPTO_BLKCIPHER=y +CONFIG_CRYPTO_MANAGER=y +# CONFIG_CRYPTO_GF128MUL is not set +# CONFIG_CRYPTO_NULL is not set +# CONFIG_CRYPTO_CRYPTD is not set +# CONFIG_CRYPTO_AUTHENC is not set +# CONFIG_CRYPTO_TEST is not set + +# +# Authenticated Encryption with Associated Data +# +# CONFIG_CRYPTO_CCM is not set +# CONFIG_CRYPTO_GCM is not set +# CONFIG_CRYPTO_SEQIV is not set + +# +# Block modes +# +CONFIG_CRYPTO_CBC=y +# CONFIG_CRYPTO_CTR is not set +# CONFIG_CRYPTO_CTS is not set +CONFIG_CRYPTO_ECB=m +# CONFIG_CRYPTO_LRW is not set +CONFIG_CRYPTO_PCBC=m +# CONFIG_CRYPTO_XTS is not set + +# +# Hash modes +# +# CONFIG_CRYPTO_HMAC is not set +# CONFIG_CRYPTO_XCBC is not set + +# +# Digest +# +# CONFIG_CRYPTO_CRC32C is not set +# CONFIG_CRYPTO_MD4 is not set +CONFIG_CRYPTO_MD5=y +# CONFIG_CRYPTO_MICHAEL_MIC is not set +# CONFIG_CRYPTO_RMD128 is not set +# CONFIG_CRYPTO_RMD160 is not set +# CONFIG_CRYPTO_RMD256 is not set +# CONFIG_CRYPTO_RMD320 is not set +# CONFIG_CRYPTO_SHA1 is not set +# CONFIG_CRYPTO_SHA256 is not set +# CONFIG_CRYPTO_SHA512 is not set +# CONFIG_CRYPTO_TGR192 is not set +# CONFIG_CRYPTO_WP512 is not set + +# +# Ciphers +# +# CONFIG_CRYPTO_AES is not set +# CONFIG_CRYPTO_ANUBIS is not set +# CONFIG_CRYPTO_ARC4 is not set +# CONFIG_CRYPTO_BLOWFISH is not set +# CONFIG_CRYPTO_CAMELLIA is not set +# CONFIG_CRYPTO_CAST5 is not set +# CONFIG_CRYPTO_CAST6 is not set +CONFIG_CRYPTO_DES=y +# CONFIG_CRYPTO_FCRYPT is not set +# CONFIG_CRYPTO_KHAZAD is not set +# CONFIG_CRYPTO_SALSA20 is not set +# CONFIG_CRYPTO_SEED is not set +# CONFIG_CRYPTO_SERPENT is not set +# CONFIG_CRYPTO_TEA is not set +# CONFIG_CRYPTO_TWOFISH is not set + +# +# Compression +# +# CONFIG_CRYPTO_DEFLATE is not set +# CONFIG_CRYPTO_LZO is not set +CONFIG_CRYPTO_HW=y + +# +# Library routines +# +CONFIG_BITREVERSE=y +# CONFIG_GENERIC_FIND_FIRST_BIT is not set +# CONFIG_GENERIC_FIND_NEXT_BIT is not set +CONFIG_CRC_CCITT=y +# CONFIG_CRC16 is not set +CONFIG_CRC_T10DIF=y +# CONFIG_CRC_ITU_T is not set +CONFIG_CRC32=y +# CONFIG_CRC7 is not set +CONFIG_LIBCRC32C=y +CONFIG_PLIST=y +CONFIG_HAS_IOMEM=y +CONFIG_HAS_IOPORT=y +CONFIG_HAS_DMA=y -- 1.5.4.3 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 3/3] OMAP3:zoom2: Makefile and Kconfig for Zoom2 board 2009-05-15 21:20 ` [PATCH v3 2/3] OMAP3:zoom2: Defconfig for " Mikkel Christensen @ 2009-05-15 21:20 ` Mikkel Christensen 0 siblings, 0 replies; 16+ messages in thread From: Mikkel Christensen @ 2009-05-15 21:20 UTC (permalink / raw) To: linux-omap; +Cc: Mikkel Christensen, Vikram Pandita This patch adds OMAP3 Zoom2 board to the Makefile and Kconfig. Signed-off-by: Mikkel Christensen <mlc@ti.com> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> --- arch/arm/mach-omap2/Kconfig | 5 +++++ arch/arm/mach-omap2/Makefile | 4 +++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 64ab386..d08a9a5 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -67,3 +67,8 @@ config MACH_OMAP_3430SDP config MACH_NOKIA_RX51 bool "Nokia RX-51 board" depends on ARCH_OMAP3 && ARCH_OMAP34XX + +config MACH_OMAP_ZOOM2 + bool "OMAP3 Zoom2 board" + depends on ARCH_OMAP3 && ARCH_OMAP34XX + diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index c49d9bf..fe4485f 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -48,7 +48,9 @@ obj-$(CONFIG_MACH_OMAP_3430SDP) += board-3430sdp.o \ obj-$(CONFIG_MACH_NOKIA_RX51) += board-rx51.o \ board-rx51-peripherals.o \ mmc-twl4030.o - +obj-$(CONFIG_MACH_OMAP_ZOOM2) += board-zoom2.o \ + mmc-twl4030.o \ + board-zoom2-debugboard.o # Platform specific device init code ifeq ($(CONFIG_USB_MUSB_SOC),y) obj-y += usb-musb.o -- 1.5.4.3 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-15 21:20 ` [PATCH v3 1/3] OMAP3:zoom2: Add support " Mikkel Christensen 2009-05-15 21:20 ` [PATCH v3 2/3] OMAP3:zoom2: Defconfig for " Mikkel Christensen @ 2009-05-18 21:22 ` Tony Lindgren 2009-05-18 21:30 ` Pandita, Vikram 1 sibling, 1 reply; 16+ messages in thread From: Tony Lindgren @ 2009-05-18 21:22 UTC (permalink / raw) To: Mikkel Christensen; +Cc: linux-omap, Vikram Pandita Hi, Few comments below. * Mikkel Christensen <mlc@ti.com> [090515 14:17]: > This patch creates the minimal OMAP3 Zoom2 board support. > > Signed-off-by: Mikkel Christensen <mlc@ti.com> > Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> > --- > arch/arm/mach-omap2/board-zoom2-debugboard.c | 161 ++++++++++++++++++++++++++ > arch/arm/mach-omap2/board-zoom2.c | 107 +++++++++++++++++ > 2 files changed, 268 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/mach-omap2/board-zoom2-debugboard.c > create mode 100644 arch/arm/mach-omap2/board-zoom2.c > > diff --git a/arch/arm/mach-omap2/board-zoom2-debugboard.c b/arch/arm/mach-omap2/board-zoom2-debugboard.c > new file mode 100644 > index 0000000..e5686e8 > --- /dev/null > +++ b/arch/arm/mach-omap2/board-zoom2-debugboard.c > @@ -0,0 +1,161 @@ > +/* > + * Copyright (C) 2009 Texas Instruments Inc. > + * Mikkel Christensen <mlc@ti.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include <linux/kernel.h> > +#include <linux/init.h> > +#include <linux/serial_8250.h> > +#include <linux/smsc911x.h> > + > +#include <mach/gpio.h> > +#include <mach/gpmc.h> > + > +#define ZOOM2_SMSC911X_CS 7 > +#define ZOOM2_SMSC911X_GPIO 158 > +#define ZOOM2_QUADUART_CS 3 > +#define ZOOM2_QUADUART_GPIO 102 > +#define QUART_CLK 1843200 > +#define DEBUG_BASE 0x08000000 > +#define ZOOM2_ETHR_START DEBUG_BASE > + > +static struct resource zoom2_smsc911x_resources[] = { > + [0] = { > + .start = ZOOM2_ETHR_START, > + .end = ZOOM2_ETHR_START + SZ_4K, > + .flags = IORESOURCE_MEM, > + }, > + [1] = { > + .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL, > + }, > +}; > + > +static struct smsc911x_platform_config zoom2_smsc911x_config = { > + .irq_polarity = SMSC911X_IRQ_POLARITY_ACTIVE_LOW, > + .irq_type = SMSC911X_IRQ_TYPE_OPEN_DRAIN, > + .flags = SMSC911X_USE_32BIT, > + .phy_interface = PHY_INTERFACE_MODE_MII, > +}; > + > +static struct platform_device zoom2_smsc911x_device = { > + .name = "smsc911x", > + .id = -1, > + .num_resources = ARRAY_SIZE(zoom2_smsc911x_resources), > + .resource = zoom2_smsc911x_resources, > + .dev = { > + .platform_data = &zoom2_smsc911x_config, > + }, > +}; > + > +static inline void __init zoom2_init_smsc911x(void) > +{ > + int eth_cs; > + unsigned long cs_mem_base; > + int eth_gpio = 0; > + > + eth_cs = ZOOM2_SMSC911X_CS; > + > + if (gpmc_cs_request(eth_cs, SZ_16M, &cs_mem_base) < 0) { > + printk(KERN_ERR "Failed to request GPMC mem for smsc911x\n"); > + return; > + } > + > + zoom2_smsc911x_resources[0].start = cs_mem_base + 0x0; > + zoom2_smsc911x_resources[0].end = cs_mem_base + 0xff; > + > + eth_gpio = ZOOM2_SMSC911X_GPIO; > + > + zoom2_smsc911x_resources[1].start = OMAP_GPIO_IRQ(eth_gpio); > + > + if (gpio_request(eth_gpio, "smsc911x irq") < 0) { > + printk(KERN_ERR "Failed to request GPIO%d for smsc911x IRQ\n", > + eth_gpio); > + return; > + } > + gpio_direction_input(eth_gpio); > +} > + > +static struct plat_serial8250_port serial_platform_data[] = { > + { > + .mapbase = 0x10000000, > + .irq = OMAP_GPIO_IRQ(102), > + .flags = UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ, > + .iotype = UPIO_MEM, > + .regshift = 1, > + .uartclk = QUART_CLK, > + }, { > + .flags = 0 > + } > +}; > + > +static struct platform_device zoom2_debugboard_serial_device = { > + .name = "serial8250", > + .id = PLAT8250_DEV_PLATFORM1, > + .dev = { > + .platform_data = serial_platform_data, > + }, > +}; > + > +static inline void __init zoom2_init_quaduart(void) > +{ > + int quart_cs; > + unsigned long cs_mem_base; > + int quart_gpio = 0; > + > + quart_cs = ZOOM2_QUADUART_CS; > + > + if (gpmc_cs_request(quart_cs, SZ_1M, &cs_mem_base) < 0) { > + printk(KERN_ERR "Failed to request GPMC mem" > + "for Quad UART(TL16CP754C)\n"); > + return; > + } > + > + quart_gpio = ZOOM2_QUADUART_GPIO; > + > + if (gpio_request(quart_gpio, "TL16CP754C GPIO") < 0) { > + printk(KERN_ERR "Failed to request GPIO%d for TL16CP754C\n", > + quart_gpio); > + return; > + } > + gpio_direction_input(quart_gpio); > +} > + > +static inline int omap_zoom2_debugboard_detect(void) > +{ > + int debug_board_detect = 0; > + > + debug_board_detect = ZOOM2_SMSC911X_GPIO; > + > + if (gpio_request(debug_board_detect, "Zoom2 debug board detect") < 0) { > + printk(KERN_ERR "Failed to request GPIO%d for Zoom2 debug" > + "board detect\n", debug_board_detect); > + return 0; > + } > + gpio_direction_input(debug_board_detect); > + > + if (!gpio_get_value(debug_board_detect)) { > + gpio_free(debug_board_detect); > + return 0; > + } > + return 1; > +} > + > +static struct platform_device *zoom2_devices[] __initdata = { > + &zoom2_smsc911x_device, > + &zoom2_debugboard_serial_device, > +}; > + > +static int __init omap_zoom2_debugboard_init(void) > +{ > + if (!omap_zoom2_debugboard_detect()) > + return 0; > + > + zoom2_init_smsc911x(); > + zoom2_init_quaduart(); > + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); > +} > +arch_initcall(omap_zoom2_debugboard_init); Please just move all the related functions to board-zoom2.c. I don't see any reason to have a separate file for the debugboard features. The runtime detection should do the trick. Also, the arch_initcall() above is wrong, it runs for all the boards and platforms compiled in even if they are not zoom2 boards. Other than, looks OK to me, so we might be able to get this into mainline this merge window. Regards, Tony > diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c > new file mode 100644 > index 0000000..5a656b3 > --- /dev/null > +++ b/arch/arm/mach-omap2/board-zoom2.c > @@ -0,0 +1,107 @@ > +/* > + * Copyright (C) 2009 Texas Instruments Inc. > + * Mikkel Christensen <mlc@ti.com> > + * > + * Modified from mach-omap2/board-ldp.c > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include <linux/kernel.h> > +#include <linux/init.h> > +#include <linux/platform_device.h> > +#include <linux/i2c/twl4030.h> > + > +#include <asm/mach-types.h> > +#include <asm/mach/arch.h> > + > +#include <mach/gpio.h> > +#include <mach/common.h> > +#include <mach/usb.h> > + > +#include "mmc-twl4030.h" > + > +static void __init omap_zoom2_init_irq(void) > +{ > + omap2_init_common_hw(NULL); > + omap_init_irq(); > + omap_gpio_init(); > +} > + > +static struct omap_uart_config zoom2_uart_config __initdata = { > + .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)), > +}; > + > +static struct omap_board_config_kernel zoom2_config[] __initdata = { > + { OMAP_TAG_UART, &zoom2_uart_config }, > +}; > + > +static struct twl4030_gpio_platform_data zoom2_gpio_data = { > + .gpio_base = OMAP_MAX_GPIO_LINES, > + .irq_base = TWL4030_GPIO_IRQ_BASE, > + .irq_end = TWL4030_GPIO_IRQ_END, > +}; > + > +static struct twl4030_platform_data zoom2_twldata = { > + .irq_base = TWL4030_IRQ_BASE, > + .irq_end = TWL4030_IRQ_END, > + > + /* platform_data for children goes here */ > + .gpio = &zoom2_gpio_data, > +}; > + > +static struct i2c_board_info __initdata zoom2_i2c_boardinfo[] = { > + { > + I2C_BOARD_INFO("twl4030", 0x48), > + .flags = I2C_CLIENT_WAKE, > + .irq = INT_34XX_SYS_NIRQ, > + .platform_data = &zoom2_twldata, > + }, > +}; > + > +static int __init omap_i2c_init(void) > +{ > + omap_register_i2c_bus(1, 2600, zoom2_i2c_boardinfo, > + ARRAY_SIZE(zoom2_i2c_boardinfo)); > + omap_register_i2c_bus(2, 400, NULL, 0); > + omap_register_i2c_bus(3, 400, NULL, 0); > + return 0; > +} > + > +static struct twl4030_hsmmc_info mmc[] __initdata = { > + { > + .mmc = 1, > + .wires = 4, > + .gpio_cd = -EINVAL, > + .gpio_wp = -EINVAL, > + }, > + {} /* Terminator */ > +}; > + > +static void __init omap_zoom2_init(void) > +{ > + omap_i2c_init(); > + omap_board_config = zoom2_config; > + omap_board_config_size = ARRAY_SIZE(zoom2_config); > + omap_serial_init(); > + twl4030_mmc_init(mmc); > + usb_musb_init(); > +} > + > +static void __init omap_zoom2_map_io(void) > +{ > + omap2_set_globals_343x(); > + omap2_map_common_io(); > +} > + > +MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board") > + .phys_io = 0x48000000, > + .io_pg_offst = ((0xd8000000) >> 18) & 0xfffc, > + .boot_params = 0x80000100, > + .map_io = omap_zoom2_map_io, > + .init_irq = omap_zoom2_init_irq, > + .init_machine = omap_zoom2_init, > + .timer = &omap_timer, > +MACHINE_END > -- > 1.5.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-18 21:22 ` [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 " Tony Lindgren @ 2009-05-18 21:30 ` Pandita, Vikram 2009-05-18 21:39 ` Tony Lindgren 0 siblings, 1 reply; 16+ messages in thread From: Pandita, Vikram @ 2009-05-18 21:30 UTC (permalink / raw) To: Tony Lindgren, Christensen, Mikkel; +Cc: linux-omap@vger.kernel.org Tony >-----Original Message----- >From: Tony Lindgren [mailto:tony@atomide.com] >Hi, > >Few comments below. > >* Mikkel Christensen <mlc@ti.com> [090515 14:17]: >> This patch creates the minimal OMAP3 Zoom2 board support. >> >> Signed-off-by: Mikkel Christensen <mlc@ti.com> >> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> >> --- >> arch/arm/mach-omap2/board-zoom2-debugboard.c | 161 ++++++++++++++++++++++++++ >> arch/arm/mach-omap2/board-zoom2.c | 107 +++++++++++++++++ >> 2 files changed, 268 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/mach-omap2/board-zoom2-debugboard.c >> create mode 100644 arch/arm/mach-omap2/board-zoom2.c <snip> >> >> + >> + zoom2_init_smsc911x(); >> + zoom2_init_quaduart(); >> + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); >> +} >> +arch_initcall(omap_zoom2_debugboard_init); > >Please just move all the related functions to board-zoom2.c. I don't see any >reason to have a separate file for the debugboard features. The runtime detection >should do the trick. Two reasons for keeping a separate debug board. a) debug board is detachable in h/w and hence we thought its better to keep the s/w also that way The quart chip on debug bard is a quard-uart and can support 4 different console outputs. All those we thought of adding in future. b) we took reference from board-rx51-peripherals.c wherein some parts of the board file can be moved out to a new file If you still think we need to merge, then let us know. We are open to suggestions/changes. > >Also, the arch_initcall() above is wrong, it runs for all the boards and >platforms compiled in even if they are not zoom2 boards. > >Other than, looks OK to me, so we might be able to get this into mainline >this merge window. > >Regards, > >Tony > > >> diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c >> new file mode 100644 >> index 0000000..5a656b3 >> --- /dev/null >> +++ b/arch/arm/mach-omap2/board-zoom2.c >> @@ -0,0 +1,107 @@ >> +/* >> + * Copyright (C) 2009 Texas Instruments Inc. >> + * Mikkel Christensen <mlc@ti.com> >> + * >> + * Modified from mach-omap2/board-ldp.c >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#include <linux/kernel.h> >> +#include <linux/init.h> >> +#include <linux/platform_device.h> >> +#include <linux/i2c/twl4030.h> >> + >> +#include <asm/mach-types.h> >> +#include <asm/mach/arch.h> >> + >> +#include <mach/gpio.h> >> +#include <mach/common.h> >> +#include <mach/usb.h> >> + >> +#include "mmc-twl4030.h" >> + >> +static void __init omap_zoom2_init_irq(void) >> +{ >> + omap2_init_common_hw(NULL); >> + omap_init_irq(); >> + omap_gpio_init(); >> +} >> + >> +static struct omap_uart_config zoom2_uart_config __initdata = { >> + .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)), >> +}; >> + >> +static struct omap_board_config_kernel zoom2_config[] __initdata = { >> + { OMAP_TAG_UART, &zoom2_uart_config }, >> +}; >> + >> +static struct twl4030_gpio_platform_data zoom2_gpio_data = { >> + .gpio_base = OMAP_MAX_GPIO_LINES, >> + .irq_base = TWL4030_GPIO_IRQ_BASE, >> + .irq_end = TWL4030_GPIO_IRQ_END, >> +}; >> + >> +static struct twl4030_platform_data zoom2_twldata = { >> + .irq_base = TWL4030_IRQ_BASE, >> + .irq_end = TWL4030_IRQ_END, >> + >> + /* platform_data for children goes here */ >> + .gpio = &zoom2_gpio_data, >> +}; >> + >> +static struct i2c_board_info __initdata zoom2_i2c_boardinfo[] = { >> + { >> + I2C_BOARD_INFO("twl4030", 0x48), >> + .flags = I2C_CLIENT_WAKE, >> + .irq = INT_34XX_SYS_NIRQ, >> + .platform_data = &zoom2_twldata, >> + }, >> +}; >> + >> +static int __init omap_i2c_init(void) >> +{ >> + omap_register_i2c_bus(1, 2600, zoom2_i2c_boardinfo, >> + ARRAY_SIZE(zoom2_i2c_boardinfo)); >> + omap_register_i2c_bus(2, 400, NULL, 0); >> + omap_register_i2c_bus(3, 400, NULL, 0); >> + return 0; >> +} >> + >> +static struct twl4030_hsmmc_info mmc[] __initdata = { >> + { >> + .mmc = 1, >> + .wires = 4, >> + .gpio_cd = -EINVAL, >> + .gpio_wp = -EINVAL, >> + }, >> + {} /* Terminator */ >> +}; >> + >> +static void __init omap_zoom2_init(void) >> +{ >> + omap_i2c_init(); >> + omap_board_config = zoom2_config; >> + omap_board_config_size = ARRAY_SIZE(zoom2_config); >> + omap_serial_init(); >> + twl4030_mmc_init(mmc); >> + usb_musb_init(); >> +} >> + >> +static void __init omap_zoom2_map_io(void) >> +{ >> + omap2_set_globals_343x(); >> + omap2_map_common_io(); >> +} >> + >> +MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board") >> + .phys_io = 0x48000000, >> + .io_pg_offst = ((0xd8000000) >> 18) & 0xfffc, >> + .boot_params = 0x80000100, >> + .map_io = omap_zoom2_map_io, >> + .init_irq = omap_zoom2_init_irq, >> + .init_machine = omap_zoom2_init, >> + .timer = &omap_timer, >> +MACHINE_END >> -- >> 1.5.4.3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-18 21:30 ` Pandita, Vikram @ 2009-05-18 21:39 ` Tony Lindgren 2009-05-19 3:55 ` Pandita, Vikram 0 siblings, 1 reply; 16+ messages in thread From: Tony Lindgren @ 2009-05-18 21:39 UTC (permalink / raw) To: Pandita, Vikram; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org * Pandita, Vikram <vikram.pandita@ti.com> [090518 14:31]: > Tony > > >-----Original Message----- > >From: Tony Lindgren [mailto:tony@atomide.com] > >Hi, > > > >Few comments below. > > > >* Mikkel Christensen <mlc@ti.com> [090515 14:17]: > >> This patch creates the minimal OMAP3 Zoom2 board support. > >> > >> Signed-off-by: Mikkel Christensen <mlc@ti.com> > >> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> > >> --- > >> arch/arm/mach-omap2/board-zoom2-debugboard.c | 161 ++++++++++++++++++++++++++ > >> arch/arm/mach-omap2/board-zoom2.c | 107 +++++++++++++++++ > >> 2 files changed, 268 insertions(+), 0 deletions(-) > >> create mode 100644 arch/arm/mach-omap2/board-zoom2-debugboard.c > >> create mode 100644 arch/arm/mach-omap2/board-zoom2.c > > <snip> > >> > >> + > >> + zoom2_init_smsc911x(); > >> + zoom2_init_quaduart(); > >> + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); > >> +} > >> +arch_initcall(omap_zoom2_debugboard_init); > > > >Please just move all the related functions to board-zoom2.c. I don't see any > >reason to have a separate file for the debugboard features. The runtime detection > >should do the trick. > > Two reasons for keeping a separate debug board. > a) debug board is detachable in h/w and hence we thought its better to keep the s/w also that way > The quart chip on debug bard is a quard-uart and can support 4 different console outputs. > All those we thought of adding in future. Well those you can easily optimize out by not compiling in those devices. > > b) we took reference from board-rx51-peripherals.c wherein some parts of the board file can be moved out to a new file > > If you still think we need to merge, then let us know. > We are open to suggestions/changes. Well the reason for separate board-*-peripheral-whatever.c files is that they're intended to be shared with other board-*.c files. Currently n8x0 and rx51 share devices. In general, we should try to do generic platform init files, like gpmc-onenand.c and gpmc-smc91x.c. Then I see need for gpmc-sdp-flash.c that's shared between 2430 and 3430 sdp at least. So yeah, for zoom2, I'd rather see just board-zoom2.c for now. But if you create some other board that uses the same debug board functions, then there could be a separate zoom-debugboard.c. Regards, Tony > > > >Also, the arch_initcall() above is wrong, it runs for all the boards and > >platforms compiled in even if they are not zoom2 boards. > > > >Other than, looks OK to me, so we might be able to get this into mainline > >this merge window. > > > >Regards, > > > >Tony > > > > > > > > >> diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c > >> new file mode 100644 > >> index 0000000..5a656b3 > >> --- /dev/null > >> +++ b/arch/arm/mach-omap2/board-zoom2.c > >> @@ -0,0 +1,107 @@ > >> +/* > >> + * Copyright (C) 2009 Texas Instruments Inc. > >> + * Mikkel Christensen <mlc@ti.com> > >> + * > >> + * Modified from mach-omap2/board-ldp.c > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2 as > >> + * published by the Free Software Foundation. > >> + */ > >> + > >> +#include <linux/kernel.h> > >> +#include <linux/init.h> > >> +#include <linux/platform_device.h> > >> +#include <linux/i2c/twl4030.h> > >> + > >> +#include <asm/mach-types.h> > >> +#include <asm/mach/arch.h> > >> + > >> +#include <mach/gpio.h> > >> +#include <mach/common.h> > >> +#include <mach/usb.h> > >> + > >> +#include "mmc-twl4030.h" > >> + > >> +static void __init omap_zoom2_init_irq(void) > >> +{ > >> + omap2_init_common_hw(NULL); > >> + omap_init_irq(); > >> + omap_gpio_init(); > >> +} > >> + > >> +static struct omap_uart_config zoom2_uart_config __initdata = { > >> + .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)), > >> +}; > >> + > >> +static struct omap_board_config_kernel zoom2_config[] __initdata = { > >> + { OMAP_TAG_UART, &zoom2_uart_config }, > >> +}; > >> + > >> +static struct twl4030_gpio_platform_data zoom2_gpio_data = { > >> + .gpio_base = OMAP_MAX_GPIO_LINES, > >> + .irq_base = TWL4030_GPIO_IRQ_BASE, > >> + .irq_end = TWL4030_GPIO_IRQ_END, > >> +}; > >> + > >> +static struct twl4030_platform_data zoom2_twldata = { > >> + .irq_base = TWL4030_IRQ_BASE, > >> + .irq_end = TWL4030_IRQ_END, > >> + > >> + /* platform_data for children goes here */ > >> + .gpio = &zoom2_gpio_data, > >> +}; > >> + > >> +static struct i2c_board_info __initdata zoom2_i2c_boardinfo[] = { > >> + { > >> + I2C_BOARD_INFO("twl4030", 0x48), > >> + .flags = I2C_CLIENT_WAKE, > >> + .irq = INT_34XX_SYS_NIRQ, > >> + .platform_data = &zoom2_twldata, > >> + }, > >> +}; > >> + > >> +static int __init omap_i2c_init(void) > >> +{ > >> + omap_register_i2c_bus(1, 2600, zoom2_i2c_boardinfo, > >> + ARRAY_SIZE(zoom2_i2c_boardinfo)); > >> + omap_register_i2c_bus(2, 400, NULL, 0); > >> + omap_register_i2c_bus(3, 400, NULL, 0); > >> + return 0; > >> +} > >> + > >> +static struct twl4030_hsmmc_info mmc[] __initdata = { > >> + { > >> + .mmc = 1, > >> + .wires = 4, > >> + .gpio_cd = -EINVAL, > >> + .gpio_wp = -EINVAL, > >> + }, > >> + {} /* Terminator */ > >> +}; > >> + > >> +static void __init omap_zoom2_init(void) > >> +{ > >> + omap_i2c_init(); > >> + omap_board_config = zoom2_config; > >> + omap_board_config_size = ARRAY_SIZE(zoom2_config); > >> + omap_serial_init(); > >> + twl4030_mmc_init(mmc); > >> + usb_musb_init(); > >> +} > >> + > >> +static void __init omap_zoom2_map_io(void) > >> +{ > >> + omap2_set_globals_343x(); > >> + omap2_map_common_io(); > >> +} > >> + > >> +MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board") > >> + .phys_io = 0x48000000, > >> + .io_pg_offst = ((0xd8000000) >> 18) & 0xfffc, > >> + .boot_params = 0x80000100, > >> + .map_io = omap_zoom2_map_io, > >> + .init_irq = omap_zoom2_init_irq, > >> + .init_machine = omap_zoom2_init, > >> + .timer = &omap_timer, > >> +MACHINE_END > >> -- > >> 1.5.4.3 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-18 21:39 ` Tony Lindgren @ 2009-05-19 3:55 ` Pandita, Vikram 2009-05-19 16:29 ` Tony Lindgren 0 siblings, 1 reply; 16+ messages in thread From: Pandita, Vikram @ 2009-05-19 3:55 UTC (permalink / raw) To: Tony Lindgren; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org Tony >-----Original Message----- >From: Tony Lindgren [mailto:tony@atomide.com] >Sent: Monday, May 18, 2009 4:39 PM >To: Pandita, Vikram >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org >Subject: Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board > >* Pandita, Vikram <vikram.pandita@ti.com> [090518 14:31]: >> Tony >> >> >> >> >> + >> >> + zoom2_init_smsc911x(); >> >> + zoom2_init_quaduart(); >> >> + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); >> >> +} >> >> +arch_initcall(omap_zoom2_debugboard_init); >> > >> >Please just move all the related functions to board-zoom2.c. I don't see any >> >reason to have a separate file for the debugboard features. The runtime detection >> >should do the trick. >> >> Two reasons for keeping a separate debug board. >> a) debug board is detachable in h/w and hence we thought its better to keep the s/w also that way >> The quart chip on debug bard is a quard-uart and can support 4 different console outputs. >> All those we thought of adding in future. > >Well those you can easily optimize out by not compiling in those devices. > >> >> b) we took reference from board-rx51-peripherals.c wherein some parts of the board file can be >moved out to a new file >> >> If you still think we need to merge, then let us know. >> We are open to suggestions/changes. > >Well the reason for separate board-*-peripheral-whatever.c files is that >they're intended to be shared with other board-*.c files. Currently n8x0 >and rx51 share devices. In general, we should try to do generic platform >init files, like gpmc-onenand.c and gpmc-smc91x.c. > >Then I see need for gpmc-sdp-flash.c that's shared between 2430 and 3430 sdp >at least. > >So yeah, for zoom2, I'd rather see just board-zoom2.c for now. But if you >create some other board that uses the same debug board functions, then >there could be a separate zoom-debugboard.c. Yes. There is next generation of zoom boards that will re-use the Debug board. That way the debug board file will get re-used. > >Regards, > >Tony > > >> > >> >Also, the arch_initcall() above is wrong, it runs for all the boards and >> >platforms compiled in even if they are not zoom2 boards. >> > >> >Other than, looks OK to me, so we might be able to get this into mainline >> >this merge window. >> > >> >Regards, >> > >> >Tony >> >> >> >> > >> > >> >> diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c >> >> new file mode 100644 >> >> index 0000000..5a656b3 >> >> --- /dev/null >> >> +++ b/arch/arm/mach-omap2/board-zoom2.c >> >> @@ -0,0 +1,107 @@ >> >> +/* >> >> + * Copyright (C) 2009 Texas Instruments Inc. >> >> + * Mikkel Christensen <mlc@ti.com> >> >> + * >> >> + * Modified from mach-omap2/board-ldp.c >> >> + * >> >> + * This program is free software; you can redistribute it and/or modify >> >> + * it under the terms of the GNU General Public License version 2 as >> >> + * published by the Free Software Foundation. >> >> + */ >> >> + >> >> +#include <linux/kernel.h> >> >> +#include <linux/init.h> >> >> +#include <linux/platform_device.h> >> >> +#include <linux/i2c/twl4030.h> >> >> + >> >> +#include <asm/mach-types.h> >> >> +#include <asm/mach/arch.h> >> >> + >> >> +#include <mach/gpio.h> >> >> +#include <mach/common.h> >> >> +#include <mach/usb.h> >> >> + >> >> +#include "mmc-twl4030.h" >> >> + >> >> +static void __init omap_zoom2_init_irq(void) >> >> +{ >> >> + omap2_init_common_hw(NULL); >> >> + omap_init_irq(); >> >> + omap_gpio_init(); >> >> +} >> >> + >> >> +static struct omap_uart_config zoom2_uart_config __initdata = { >> >> + .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)), >> >> +}; >> >> + >> >> +static struct omap_board_config_kernel zoom2_config[] __initdata = { >> >> + { OMAP_TAG_UART, &zoom2_uart_config }, >> >> +}; >> >> + >> >> +static struct twl4030_gpio_platform_data zoom2_gpio_data = { >> >> + .gpio_base = OMAP_MAX_GPIO_LINES, >> >> + .irq_base = TWL4030_GPIO_IRQ_BASE, >> >> + .irq_end = TWL4030_GPIO_IRQ_END, >> >> +}; >> >> + >> >> +static struct twl4030_platform_data zoom2_twldata = { >> >> + .irq_base = TWL4030_IRQ_BASE, >> >> + .irq_end = TWL4030_IRQ_END, >> >> + >> >> + /* platform_data for children goes here */ >> >> + .gpio = &zoom2_gpio_data, >> >> +}; >> >> + >> >> +static struct i2c_board_info __initdata zoom2_i2c_boardinfo[] = { >> >> + { >> >> + I2C_BOARD_INFO("twl4030", 0x48), >> >> + .flags = I2C_CLIENT_WAKE, >> >> + .irq = INT_34XX_SYS_NIRQ, >> >> + .platform_data = &zoom2_twldata, >> >> + }, >> >> +}; >> >> + >> >> +static int __init omap_i2c_init(void) >> >> +{ >> >> + omap_register_i2c_bus(1, 2600, zoom2_i2c_boardinfo, >> >> + ARRAY_SIZE(zoom2_i2c_boardinfo)); >> >> + omap_register_i2c_bus(2, 400, NULL, 0); >> >> + omap_register_i2c_bus(3, 400, NULL, 0); >> >> + return 0; >> >> +} >> >> + >> >> +static struct twl4030_hsmmc_info mmc[] __initdata = { >> >> + { >> >> + .mmc = 1, >> >> + .wires = 4, >> >> + .gpio_cd = -EINVAL, >> >> + .gpio_wp = -EINVAL, >> >> + }, >> >> + {} /* Terminator */ >> >> +}; >> >> + >> >> +static void __init omap_zoom2_init(void) >> >> +{ >> >> + omap_i2c_init(); >> >> + omap_board_config = zoom2_config; >> >> + omap_board_config_size = ARRAY_SIZE(zoom2_config); >> >> + omap_serial_init(); >> >> + twl4030_mmc_init(mmc); >> >> + usb_musb_init(); >> >> +} >> >> + >> >> +static void __init omap_zoom2_map_io(void) >> >> +{ >> >> + omap2_set_globals_343x(); >> >> + omap2_map_common_io(); >> >> +} >> >> + >> >> +MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board") >> >> + .phys_io = 0x48000000, >> >> + .io_pg_offst = ((0xd8000000) >> 18) & 0xfffc, >> >> + .boot_params = 0x80000100, >> >> + .map_io = omap_zoom2_map_io, >> >> + .init_irq = omap_zoom2_init_irq, >> >> + .init_machine = omap_zoom2_init, >> >> + .timer = &omap_timer, >> >> +MACHINE_END >> >> -- >> >> 1.5.4.3 >> >> >> >> -- >> >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> >> the body of a message to majordomo@vger.kernel.org >> >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-19 3:55 ` Pandita, Vikram @ 2009-05-19 16:29 ` Tony Lindgren 2009-05-19 23:48 ` Pandita, Vikram 0 siblings, 1 reply; 16+ messages in thread From: Tony Lindgren @ 2009-05-19 16:29 UTC (permalink / raw) To: Pandita, Vikram; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org * Pandita, Vikram <vikram.pandita@ti.com> [090518 20:55]: > Tony > > >-----Original Message----- > >From: Tony Lindgren [mailto:tony@atomide.com] > >Sent: Monday, May 18, 2009 4:39 PM > >To: Pandita, Vikram > >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org > >Subject: Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board > > > >* Pandita, Vikram <vikram.pandita@ti.com> [090518 14:31]: > >> Tony > >> > >> >> > >> >> + > >> >> + zoom2_init_smsc911x(); > >> >> + zoom2_init_quaduart(); > >> >> + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); > >> >> +} > >> >> +arch_initcall(omap_zoom2_debugboard_init); > >> > > >> >Please just move all the related functions to board-zoom2.c. I don't see any > >> >reason to have a separate file for the debugboard features. The runtime detection > >> >should do the trick. > >> > >> Two reasons for keeping a separate debug board. > >> a) debug board is detachable in h/w and hence we thought its better to keep the s/w also that way > >> The quart chip on debug bard is a quard-uart and can support 4 different console outputs. > >> All those we thought of adding in future. > > > >Well those you can easily optimize out by not compiling in those devices. > > > >> > >> b) we took reference from board-rx51-peripherals.c wherein some parts of the board file can be > >moved out to a new file > >> > >> If you still think we need to merge, then let us know. > >> We are open to suggestions/changes. > > > >Well the reason for separate board-*-peripheral-whatever.c files is that > >they're intended to be shared with other board-*.c files. Currently n8x0 > >and rx51 share devices. In general, we should try to do generic platform > >init files, like gpmc-onenand.c and gpmc-smc91x.c. > > > >Then I see need for gpmc-sdp-flash.c that's shared between 2430 and 3430 sdp > >at least. > > > >So yeah, for zoom2, I'd rather see just board-zoom2.c for now. But if you > >create some other board that uses the same debug board functions, then > >there could be a separate zoom-debugboard.c. > > > Yes. There is next generation of zoom boards that will re-use the Debug board. > That way the debug board file will get re-used. OK, how about rename it to something that makes sense as a name for multiple zoom like boards and resubmit. Also the arch_initcall() issue below still needs fixing. Regards, Tony > > > > >Regards, > > > >Tony > > > > > >> > > >> >Also, the arch_initcall() above is wrong, it runs for all the boards and > >> >platforms compiled in even if they are not zoom2 boards. > >> > > >> >Other than, looks OK to me, so we might be able to get this into mainline > >> >this merge window. > >> > > >> >Regards, > >> > > >> >Tony > >> > >> > >> > >> > > >> > > >> >> diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c > >> >> new file mode 100644 > >> >> index 0000000..5a656b3 > >> >> --- /dev/null > >> >> +++ b/arch/arm/mach-omap2/board-zoom2.c > >> >> @@ -0,0 +1,107 @@ > >> >> +/* > >> >> + * Copyright (C) 2009 Texas Instruments Inc. > >> >> + * Mikkel Christensen <mlc@ti.com> > >> >> + * > >> >> + * Modified from mach-omap2/board-ldp.c > >> >> + * > >> >> + * This program is free software; you can redistribute it and/or modify > >> >> + * it under the terms of the GNU General Public License version 2 as > >> >> + * published by the Free Software Foundation. > >> >> + */ > >> >> + > >> >> +#include <linux/kernel.h> > >> >> +#include <linux/init.h> > >> >> +#include <linux/platform_device.h> > >> >> +#include <linux/i2c/twl4030.h> > >> >> + > >> >> +#include <asm/mach-types.h> > >> >> +#include <asm/mach/arch.h> > >> >> + > >> >> +#include <mach/gpio.h> > >> >> +#include <mach/common.h> > >> >> +#include <mach/usb.h> > >> >> + > >> >> +#include "mmc-twl4030.h" > >> >> + > >> >> +static void __init omap_zoom2_init_irq(void) > >> >> +{ > >> >> + omap2_init_common_hw(NULL); > >> >> + omap_init_irq(); > >> >> + omap_gpio_init(); > >> >> +} > >> >> + > >> >> +static struct omap_uart_config zoom2_uart_config __initdata = { > >> >> + .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)), > >> >> +}; > >> >> + > >> >> +static struct omap_board_config_kernel zoom2_config[] __initdata = { > >> >> + { OMAP_TAG_UART, &zoom2_uart_config }, > >> >> +}; > >> >> + > >> >> +static struct twl4030_gpio_platform_data zoom2_gpio_data = { > >> >> + .gpio_base = OMAP_MAX_GPIO_LINES, > >> >> + .irq_base = TWL4030_GPIO_IRQ_BASE, > >> >> + .irq_end = TWL4030_GPIO_IRQ_END, > >> >> +}; > >> >> + > >> >> +static struct twl4030_platform_data zoom2_twldata = { > >> >> + .irq_base = TWL4030_IRQ_BASE, > >> >> + .irq_end = TWL4030_IRQ_END, > >> >> + > >> >> + /* platform_data for children goes here */ > >> >> + .gpio = &zoom2_gpio_data, > >> >> +}; > >> >> + > >> >> +static struct i2c_board_info __initdata zoom2_i2c_boardinfo[] = { > >> >> + { > >> >> + I2C_BOARD_INFO("twl4030", 0x48), > >> >> + .flags = I2C_CLIENT_WAKE, > >> >> + .irq = INT_34XX_SYS_NIRQ, > >> >> + .platform_data = &zoom2_twldata, > >> >> + }, > >> >> +}; > >> >> + > >> >> +static int __init omap_i2c_init(void) > >> >> +{ > >> >> + omap_register_i2c_bus(1, 2600, zoom2_i2c_boardinfo, > >> >> + ARRAY_SIZE(zoom2_i2c_boardinfo)); > >> >> + omap_register_i2c_bus(2, 400, NULL, 0); > >> >> + omap_register_i2c_bus(3, 400, NULL, 0); > >> >> + return 0; > >> >> +} > >> >> + > >> >> +static struct twl4030_hsmmc_info mmc[] __initdata = { > >> >> + { > >> >> + .mmc = 1, > >> >> + .wires = 4, > >> >> + .gpio_cd = -EINVAL, > >> >> + .gpio_wp = -EINVAL, > >> >> + }, > >> >> + {} /* Terminator */ > >> >> +}; > >> >> + > >> >> +static void __init omap_zoom2_init(void) > >> >> +{ > >> >> + omap_i2c_init(); > >> >> + omap_board_config = zoom2_config; > >> >> + omap_board_config_size = ARRAY_SIZE(zoom2_config); > >> >> + omap_serial_init(); > >> >> + twl4030_mmc_init(mmc); > >> >> + usb_musb_init(); > >> >> +} > >> >> + > >> >> +static void __init omap_zoom2_map_io(void) > >> >> +{ > >> >> + omap2_set_globals_343x(); > >> >> + omap2_map_common_io(); > >> >> +} > >> >> + > >> >> +MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board") > >> >> + .phys_io = 0x48000000, > >> >> + .io_pg_offst = ((0xd8000000) >> 18) & 0xfffc, > >> >> + .boot_params = 0x80000100, > >> >> + .map_io = omap_zoom2_map_io, > >> >> + .init_irq = omap_zoom2_init_irq, > >> >> + .init_machine = omap_zoom2_init, > >> >> + .timer = &omap_timer, > >> >> +MACHINE_END > >> >> -- > >> >> 1.5.4.3 > >> >> > >> >> -- > >> >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in > >> >> the body of a message to majordomo@vger.kernel.org > >> >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-19 16:29 ` Tony Lindgren @ 2009-05-19 23:48 ` Pandita, Vikram 2009-05-19 23:55 ` Tony Lindgren 0 siblings, 1 reply; 16+ messages in thread From: Pandita, Vikram @ 2009-05-19 23:48 UTC (permalink / raw) To: Tony Lindgren; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org Tony >-----Original Message----- >From: Tony Lindgren [mailto:tony@atomide.com] >Sent: Tuesday, May 19, 2009 11:30 AM >To: Pandita, Vikram >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org >Subject: Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board > >* Pandita, Vikram <vikram.pandita@ti.com> [090518 20:55]: >> Tony >> >> >* Pandita, Vikram <vikram.pandita@ti.com> [090518 14:31]: >> >> Tony >> >> >> >> >> >> >> >> + >> >> >> + zoom2_init_smsc911x(); >> >> >> + zoom2_init_quaduart(); >> >> >> + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); >> >> >> +} >> >> >> +arch_initcall(omap_zoom2_debugboard_init); >> >> > >> >> >Please just move all the related functions to board-zoom2.c. I don't see any >> >> >reason to have a separate file for the debugboard features. The runtime detection >> >> >should do the trick. >> >> >> >> Two reasons for keeping a separate debug board. >> >> a) debug board is detachable in h/w and hence we thought its better to keep the s/w also that >way >> >> The quart chip on debug bard is a quard-uart and can support 4 different console outputs. >> >> All those we thought of adding in future. >> > >> >Well those you can easily optimize out by not compiling in those devices. >> > >> >> >> >> b) we took reference from board-rx51-peripherals.c wherein some parts of the board file can be >> >moved out to a new file >> >> >> >> If you still think we need to merge, then let us know. >> >> We are open to suggestions/changes. >> > >> >Well the reason for separate board-*-peripheral-whatever.c files is that >> >they're intended to be shared with other board-*.c files. Currently n8x0 >> >and rx51 share devices. In general, we should try to do generic platform >> >init files, like gpmc-onenand.c and gpmc-smc91x.c. >> > >> >Then I see need for gpmc-sdp-flash.c that's shared between 2430 and 3430 sdp >> >at least. >> > >> >So yeah, for zoom2, I'd rather see just board-zoom2.c for now. But if you >> >create some other board that uses the same debug board functions, then >> >there could be a separate zoom-debugboard.c. >> >> >> Yes. There is next generation of zoom boards that will re-use the Debug board. >> That way the debug board file will get re-used. > >OK, how about rename it to something that makes sense as a name for >multiple zoom like boards and resubmit. I am planning on renaming debug board zoom2 file to board-zoom-debugboard.c That way it can be used by different Zoom family of boards. > >Also the arch_initcall() issue below still needs fixing. I have cleaned the issue by making the debug_board_init call as late_initcall(). There is a dependency on serial.c file and hence the need for arch_init/late_init calls. platform_device_register() should happen for serial.c file (8250) for the omap uarts first and this should be followed by platform_device_register() for the quard uart on debug board. So there is a dependency on order of registration of platform device for the same 8250 driver. If you ack, then I can post the patches with the changes. > >Regards, > >Tony > >> >> > >> >Regards, >> > >> >Tony >> > >> > >> >> > >> >> >Also, the arch_initcall() above is wrong, it runs for all the boards and >> >> >platforms compiled in even if they are not zoom2 boards. >> >> > >> >> >Other than, looks OK to me, so we might be able to get this into mainline >> >> >this merge window. >> >> > >> >> >Regards, >> >> > >> >> >Tony >> >> >> >> >> >> >> >> > >> >> > >> >> >> diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c >> >> >> new file mode 100644 >> >> >> index 0000000..5a656b3 >> >> >> --- /dev/null >> >> >> +++ b/arch/arm/mach-omap2/board-zoom2.c >> >> >> @@ -0,0 +1,107 @@ >> >> >> +/* >> >> >> + * Copyright (C) 2009 Texas Instruments Inc. >> >> >> + * Mikkel Christensen <mlc@ti.com> >> >> >> + * >> >> >> + * Modified from mach-omap2/board-ldp.c >> >> >> + * >> >> >> + * This program is free software; you can redistribute it and/or modify >> >> >> + * it under the terms of the GNU General Public License version 2 as >> >> >> + * published by the Free Software Foundation. >> >> >> + */ >> >> >> + >> >> >> +#include <linux/kernel.h> >> >> >> +#include <linux/init.h> >> >> >> +#include <linux/platform_device.h> >> >> >> +#include <linux/i2c/twl4030.h> >> >> >> + >> >> >> +#include <asm/mach-types.h> >> >> >> +#include <asm/mach/arch.h> >> >> >> + >> >> >> +#include <mach/gpio.h> >> >> >> +#include <mach/common.h> >> >> >> +#include <mach/usb.h> >> >> >> + >> >> >> +#include "mmc-twl4030.h" >> >> >> + >> >> >> +static void __init omap_zoom2_init_irq(void) >> >> >> +{ >> >> >> + omap2_init_common_hw(NULL); >> >> >> + omap_init_irq(); >> >> >> + omap_gpio_init(); >> >> >> +} >> >> >> + >> >> >> +static struct omap_uart_config zoom2_uart_config __initdata = { >> >> >> + .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)), >> >> >> +}; >> >> >> + >> >> >> +static struct omap_board_config_kernel zoom2_config[] __initdata = { >> >> >> + { OMAP_TAG_UART, &zoom2_uart_config }, >> >> >> +}; >> >> >> + >> >> >> +static struct twl4030_gpio_platform_data zoom2_gpio_data = { >> >> >> + .gpio_base = OMAP_MAX_GPIO_LINES, >> >> >> + .irq_base = TWL4030_GPIO_IRQ_BASE, >> >> >> + .irq_end = TWL4030_GPIO_IRQ_END, >> >> >> +}; >> >> >> + >> >> >> +static struct twl4030_platform_data zoom2_twldata = { >> >> >> + .irq_base = TWL4030_IRQ_BASE, >> >> >> + .irq_end = TWL4030_IRQ_END, >> >> >> + >> >> >> + /* platform_data for children goes here */ >> >> >> + .gpio = &zoom2_gpio_data, >> >> >> +}; >> >> >> + >> >> >> +static struct i2c_board_info __initdata zoom2_i2c_boardinfo[] = { >> >> >> + { >> >> >> + I2C_BOARD_INFO("twl4030", 0x48), >> >> >> + .flags = I2C_CLIENT_WAKE, >> >> >> + .irq = INT_34XX_SYS_NIRQ, >> >> >> + .platform_data = &zoom2_twldata, >> >> >> + }, >> >> >> +}; >> >> >> + >> >> >> +static int __init omap_i2c_init(void) >> >> >> +{ >> >> >> + omap_register_i2c_bus(1, 2600, zoom2_i2c_boardinfo, >> >> >> + ARRAY_SIZE(zoom2_i2c_boardinfo)); >> >> >> + omap_register_i2c_bus(2, 400, NULL, 0); >> >> >> + omap_register_i2c_bus(3, 400, NULL, 0); >> >> >> + return 0; >> >> >> +} >> >> >> + >> >> >> +static struct twl4030_hsmmc_info mmc[] __initdata = { >> >> >> + { >> >> >> + .mmc = 1, >> >> >> + .wires = 4, >> >> >> + .gpio_cd = -EINVAL, >> >> >> + .gpio_wp = -EINVAL, >> >> >> + }, >> >> >> + {} /* Terminator */ >> >> >> +}; >> >> >> + >> >> >> +static void __init omap_zoom2_init(void) >> >> >> +{ >> >> >> + omap_i2c_init(); >> >> >> + omap_board_config = zoom2_config; >> >> >> + omap_board_config_size = ARRAY_SIZE(zoom2_config); >> >> >> + omap_serial_init(); >> >> >> + twl4030_mmc_init(mmc); >> >> >> + usb_musb_init(); >> >> >> +} >> >> >> + >> >> >> +static void __init omap_zoom2_map_io(void) >> >> >> +{ >> >> >> + omap2_set_globals_343x(); >> >> >> + omap2_map_common_io(); >> >> >> +} >> >> >> + >> >> >> +MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board") >> >> >> + .phys_io = 0x48000000, >> >> >> + .io_pg_offst = ((0xd8000000) >> 18) & 0xfffc, >> >> >> + .boot_params = 0x80000100, >> >> >> + .map_io = omap_zoom2_map_io, >> >> >> + .init_irq = omap_zoom2_init_irq, >> >> >> + .init_machine = omap_zoom2_init, >> >> >> + .timer = &omap_timer, >> >> >> +MACHINE_END >> >> >> -- >> >> >> 1.5.4.3 >> >> >> >> >> >> -- >> >> >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> >> >> the body of a message to majordomo@vger.kernel.org >> >> >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-19 23:48 ` Pandita, Vikram @ 2009-05-19 23:55 ` Tony Lindgren 2009-05-20 0:01 ` Pandita, Vikram 0 siblings, 1 reply; 16+ messages in thread From: Tony Lindgren @ 2009-05-19 23:55 UTC (permalink / raw) To: Pandita, Vikram; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org * Pandita, Vikram <vikram.pandita@ti.com> [090519 16:48]: > Tony > > >-----Original Message----- > >From: Tony Lindgren [mailto:tony@atomide.com] > >Sent: Tuesday, May 19, 2009 11:30 AM > >To: Pandita, Vikram > >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org > >Subject: Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board > > > >* Pandita, Vikram <vikram.pandita@ti.com> [090518 20:55]: > >> Tony > >> > >> >* Pandita, Vikram <vikram.pandita@ti.com> [090518 14:31]: > >> >> Tony > >> >> > >> >> >> > >> >> >> + > >> >> >> + zoom2_init_smsc911x(); > >> >> >> + zoom2_init_quaduart(); > >> >> >> + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); > >> >> >> +} > >> >> >> +arch_initcall(omap_zoom2_debugboard_init); > >> >> > > >> >> >Please just move all the related functions to board-zoom2.c. I don't see any > >> >> >reason to have a separate file for the debugboard features. The runtime detection > >> >> >should do the trick. > >> >> > >> >> Two reasons for keeping a separate debug board. > >> >> a) debug board is detachable in h/w and hence we thought its better to keep the s/w also that > >way > >> >> The quart chip on debug bard is a quard-uart and can support 4 different console outputs. > >> >> All those we thought of adding in future. > >> > > >> >Well those you can easily optimize out by not compiling in those devices. > >> > > >> >> > >> >> b) we took reference from board-rx51-peripherals.c wherein some parts of the board file can be > >> >moved out to a new file > >> >> > >> >> If you still think we need to merge, then let us know. > >> >> We are open to suggestions/changes. > >> > > >> >Well the reason for separate board-*-peripheral-whatever.c files is that > >> >they're intended to be shared with other board-*.c files. Currently n8x0 > >> >and rx51 share devices. In general, we should try to do generic platform > >> >init files, like gpmc-onenand.c and gpmc-smc91x.c. > >> > > >> >Then I see need for gpmc-sdp-flash.c that's shared between 2430 and 3430 sdp > >> >at least. > >> > > >> >So yeah, for zoom2, I'd rather see just board-zoom2.c for now. But if you > >> >create some other board that uses the same debug board functions, then > >> >there could be a separate zoom-debugboard.c. > >> > >> > >> Yes. There is next generation of zoom boards that will re-use the Debug board. > >> That way the debug board file will get re-used. > > > >OK, how about rename it to something that makes sense as a name for > >multiple zoom like boards and resubmit. > > I am planning on renaming debug board zoom2 file to board-zoom-debugboard.c > That way it can be used by different Zoom family of boards. OK > >Also the arch_initcall() issue below still needs fixing. > > I have cleaned the issue by making the debug_board_init call as late_initcall(). > > There is a dependency on serial.c file and hence the need for arch_init/late_init calls. > > platform_device_register() should happen for serial.c file (8250) for the omap uarts first and this should be followed by platform_device_register() for the quard uart on debug board. > > So there is a dependency on order of registration of platform device for the same 8250 driver. > > If you ack, then I can post the patches with the changes. Well you still cannot have it as a late_initcall(), you should just call the function from board-zoom2.c. Otherwise it will run for all the boards. Regards, Tony ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-19 23:55 ` Tony Lindgren @ 2009-05-20 0:01 ` Pandita, Vikram 2009-05-20 0:10 ` Pandita, Vikram 0 siblings, 1 reply; 16+ messages in thread From: Pandita, Vikram @ 2009-05-20 0:01 UTC (permalink / raw) To: Tony Lindgren; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org >-----Original Message----- >From: Tony Lindgren [mailto:tony@atomide.com] >Sent: Tuesday, May 19, 2009 6:55 PM >To: Pandita, Vikram >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org >Subject: Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board > >* Pandita, Vikram <vikram.pandita@ti.com> [090519 16:48]: >> Tony >> >> >-----Original Message----- >> >From: Tony Lindgren [mailto:tony@atomide.com] >> >Sent: Tuesday, May 19, 2009 11:30 AM >> >To: Pandita, Vikram >> >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org >> >Subject: Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board >> > >> >* Pandita, Vikram <vikram.pandita@ti.com> [090518 20:55]: >> >> Tony >> >> >> >> >* Pandita, Vikram <vikram.pandita@ti.com> [090518 14:31]: >> >> >> Tony >> >> >> >> >> >> >> >> >> >> >> + >> >> >> >> + zoom2_init_smsc911x(); >> >> >> >> + zoom2_init_quaduart(); >> >> >> >> + return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); >> >> >> >> +} >> >> >> >> +arch_initcall(omap_zoom2_debugboard_init); >> >> >> > >> >> >> >Please just move all the related functions to board-zoom2.c. I don't see any >> >> >> >reason to have a separate file for the debugboard features. The runtime detection >> >> >> >should do the trick. >> >> >> >> >> >> Two reasons for keeping a separate debug board. >> >> >> a) debug board is detachable in h/w and hence we thought its better to keep the s/w also that >> >way >> >> >> The quart chip on debug bard is a quard-uart and can support 4 different console outputs. >> >> >> All those we thought of adding in future. >> >> > >> >> >Well those you can easily optimize out by not compiling in those devices. >> >> > >> >> >> >> >> >> b) we took reference from board-rx51-peripherals.c wherein some parts of the board file can >be >> >> >moved out to a new file >> >> >> >> >> >> If you still think we need to merge, then let us know. >> >> >> We are open to suggestions/changes. >> >> > >> >> >Well the reason for separate board-*-peripheral-whatever.c files is that >> >> >they're intended to be shared with other board-*.c files. Currently n8x0 >> >> >and rx51 share devices. In general, we should try to do generic platform >> >> >init files, like gpmc-onenand.c and gpmc-smc91x.c. >> >> > >> >> >Then I see need for gpmc-sdp-flash.c that's shared between 2430 and 3430 sdp >> >> >at least. >> >> > >> >> >So yeah, for zoom2, I'd rather see just board-zoom2.c for now. But if you >> >> >create some other board that uses the same debug board functions, then >> >> >there could be a separate zoom-debugboard.c. >> >> >> >> >> >> Yes. There is next generation of zoom boards that will re-use the Debug board. >> >> That way the debug board file will get re-used. >> > >> >OK, how about rename it to something that makes sense as a name for >> >multiple zoom like boards and resubmit. >> >> I am planning on renaming debug board zoom2 file to board-zoom-debugboard.c >> That way it can be used by different Zoom family of boards. > >OK > >> >Also the arch_initcall() issue below still needs fixing. >> >> I have cleaned the issue by making the debug_board_init call as late_initcall(). >> >> There is a dependency on serial.c file and hence the need for arch_init/late_init calls. >> >> platform_device_register() should happen for serial.c file (8250) for the omap uarts first and this >should be followed by platform_device_register() for the quard uart on debug board. >> >> So there is a dependency on order of registration of platform device for the same 8250 driver. >> >> If you ack, then I can post the patches with the changes. > >Well you still cannot have it as a late_initcall(), you should just call the >function from board-zoom2.c. Otherwise it will run for all the boards. The problem is that serial.c: platform_device_register() for UART1/2/3 happens as arch_init(). We want that Quard/Dbg-board Uart console to appear as UART4(ttyS3) and so the platform_device_register() has to happen after the arch_init() call from serial.c If we put the dbg-board init in .init_machine = omap_zoom2_init() function, then this gets called first before the serial.c:arch_init() and assigns ttyS0(UART0) to the debug board uart. This is not what we want to do. > >Regards, > >Tony > ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-20 0:01 ` Pandita, Vikram @ 2009-05-20 0:10 ` Pandita, Vikram 2009-05-20 21:12 ` Tony Lindgren 0 siblings, 1 reply; 16+ messages in thread From: Pandita, Vikram @ 2009-05-20 0:10 UTC (permalink / raw) To: Tony Lindgren; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org Tony >-----Original Message----- >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of >Pandita, Vikram >Sent: Tuesday, May 19, 2009 7:01 PM >To: Tony Lindgren >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org >Subject: RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board > > > <snip> >> >>Well you still cannot have it as a late_initcall(), you should just call the >>function from board-zoom2.c. Otherwise it will run for all the boards. Way not execute the debug board function for other boards could be to put it under #ifdef CONFIG_MACH_OMAP_ZOOM2 static int __init omap_zoom2_debugboard_init(void) { #ifdef CONFIG_MACH_OMAP_ZOOM2 if (!omap_zoom2_debugboard_detect()) return 0; zoom2_init_smsc911x(); zoom2_init_quaduart(); return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); #endif } late_initcall(omap_zoom2_debugboard_init); The registration order of the UARTS with 8250 driver is all the reason we have to do this _initcall() > >The problem is that serial.c: platform_device_register() for UART1/2/3 happens as arch_init(). > >We want that Quard/Dbg-board Uart console to appear as UART4(ttyS3) and so the >platform_device_register() has to happen after the arch_init() call from serial.c > >If we put the dbg-board init in .init_machine = omap_zoom2_init() function, then this gets called >first before the serial.c:arch_init() and assigns ttyS0(UART0) to the debug board uart. > >This is not what we want to do. > > >> >>Regards, >> >>Tony >> > >-- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-20 0:10 ` Pandita, Vikram @ 2009-05-20 21:12 ` Tony Lindgren 2009-05-20 21:15 ` Pandita, Vikram 0 siblings, 1 reply; 16+ messages in thread From: Tony Lindgren @ 2009-05-20 21:12 UTC (permalink / raw) To: Pandita, Vikram; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org * Pandita, Vikram <vikram.pandita@ti.com> [090519 17:10]: > Tony > > >-----Original Message----- > >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of > >Pandita, Vikram > >Sent: Tuesday, May 19, 2009 7:01 PM > >To: Tony Lindgren > >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org > >Subject: RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board > > > > > > > <snip> > >> > >>Well you still cannot have it as a late_initcall(), you should just call the > >>function from board-zoom2.c. Otherwise it will run for all the boards. > > Way not execute the debug board function for other boards could be to put it under > #ifdef CONFIG_MACH_OMAP_ZOOM2 > > static int __init omap_zoom2_debugboard_init(void) > { > #ifdef CONFIG_MACH_OMAP_ZOOM2 > if (!omap_zoom2_debugboard_detect()) > return 0; > > zoom2_init_smsc911x(); > zoom2_init_quaduart(); > return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); > #endif > } > late_initcall(omap_zoom2_debugboard_init); > > > The registration order of the UARTS with 8250 driver is all the reason we have to do this _initcall() Hmm, OK. That sounds like a bug that's from some older code. We should probably just do the platform_device_register in omap_serial_init(), then you can call your zoom_debug_init() after omap_serial_init(). Care to do a separate patch to get rid of omap_init in mach-omap2/serial.c, and do the registration in omap_serial_init()? Regards, Tony > > > > > >The problem is that serial.c: platform_device_register() for UART1/2/3 happens as arch_init(). > > > >We want that Quard/Dbg-board Uart console to appear as UART4(ttyS3) and so the > >platform_device_register() has to happen after the arch_init() call from serial.c > > > >If we put the dbg-board init in .init_machine = omap_zoom2_init() function, then this gets called > >first before the serial.c:arch_init() and assigns ttyS0(UART0) to the debug board uart. > > > >This is not what we want to do. > > > > > >> > >>Regards, > >> > >>Tony > >> > > > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-omap" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board 2009-05-20 21:12 ` Tony Lindgren @ 2009-05-20 21:15 ` Pandita, Vikram 0 siblings, 0 replies; 16+ messages in thread From: Pandita, Vikram @ 2009-05-20 21:15 UTC (permalink / raw) To: Tony Lindgren; +Cc: Christensen, Mikkel, linux-omap@vger.kernel.org >From: Tony Lindgren [mailto:tony@atomide.com] >To: Pandita, Vikram >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org >Subject: Re: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board > >* Pandita, Vikram <vikram.pandita@ti.com> [090519 17:10]: >> Tony >> >> >-----Original Message----- >> >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of >> >Pandita, Vikram >> >Sent: Tuesday, May 19, 2009 7:01 PM >> >To: Tony Lindgren >> >Cc: Christensen, Mikkel; linux-omap@vger.kernel.org >> >Subject: RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board >> > >> > >> > >> <snip> >> >> >> >>Well you still cannot have it as a late_initcall(), you should just call the >> >>function from board-zoom2.c. Otherwise it will run for all the boards. >> >> Way not execute the debug board function for other boards could be to put it under >> #ifdef CONFIG_MACH_OMAP_ZOOM2 >> >> static int __init omap_zoom2_debugboard_init(void) >> { >> #ifdef CONFIG_MACH_OMAP_ZOOM2 >> if (!omap_zoom2_debugboard_detect()) >> return 0; >> >> zoom2_init_smsc911x(); >> zoom2_init_quaduart(); >> return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices)); >> #endif >> } >> late_initcall(omap_zoom2_debugboard_init); >> >> >> The registration order of the UARTS with 8250 driver is all the reason we have to do this >_initcall() > >Hmm, OK. That sounds like a bug that's from some older code. We should probably >just do the platform_device_register in omap_serial_init(), then you can call >your zoom_debug_init() after omap_serial_init(). > >Care to do a separate patch to get rid of omap_init in mach-omap2/serial.c, and do >the registration in omap_serial_init()? Yes I can do that. I will submit the patch for this change. Following this I will resubmit Zoom2-board support version4 > >Regards, > >Tony > >> >> >> > >> >The problem is that serial.c: platform_device_register() for UART1/2/3 happens as arch_init(). >> > >> >We want that Quard/Dbg-board Uart console to appear as UART4(ttyS3) and so the >> >platform_device_register() has to happen after the arch_init() call from serial.c >> > >> >If we put the dbg-board init in .init_machine = omap_zoom2_init() function, then this gets >called >> >first before the serial.c:arch_init() and assigns ttyS0(UART0) to the debug board uart. >> > >> >This is not what we want to do. >> > >> > >> >> >> >>Regards, >> >> >> >>Tony >> >> >> > >> >-- >> >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> >the body of a message to majordomo@vger.kernel.org >> >More majordomo info at http://vger.kernel.org/majordomo-info.html >> ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 0/3] Support for OMAP3 Zoom2 board 2009-05-15 21:20 [PATCH v3 0/3] Support for OMAP3 Zoom2 board Mikkel Christensen 2009-05-15 21:20 ` [PATCH v3 1/3] OMAP3:zoom2: Add support " Mikkel Christensen @ 2009-05-15 22:34 ` Kevin Hilman 1 sibling, 0 replies; 16+ messages in thread From: Kevin Hilman @ 2009-05-15 22:34 UTC (permalink / raw) To: Mikkel Christensen; +Cc: linux-omap Mikkel Christensen <mlc@ti.com> writes: > The following patch series adds support for Zoom2 board. > This is a new version made after comments from Kevin Hilman. > > An external debug board is included for console and LAN. This version looks good to me. Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com> > > For details refer to this site: > http://www.logicpd.com/products/development-kits/texas-instruments-zoom%E2%84%A2-omap34x-ii-mdp > > Future work: > - SMSC911x NFS mount problem > - Low level debug uart need to use debug board I assume the uncompress.h and DEBUG_LL patches for UART are coming next as they are also required to boot. Kevin ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2009-05-20 21:16 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-05-15 21:20 [PATCH v3 0/3] Support for OMAP3 Zoom2 board Mikkel Christensen 2009-05-15 21:20 ` [PATCH v3 1/3] OMAP3:zoom2: Add support " Mikkel Christensen 2009-05-15 21:20 ` [PATCH v3 2/3] OMAP3:zoom2: Defconfig for " Mikkel Christensen 2009-05-15 21:20 ` [PATCH v3 3/3] OMAP3:zoom2: Makefile and Kconfig " Mikkel Christensen 2009-05-18 21:22 ` [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 " Tony Lindgren 2009-05-18 21:30 ` Pandita, Vikram 2009-05-18 21:39 ` Tony Lindgren 2009-05-19 3:55 ` Pandita, Vikram 2009-05-19 16:29 ` Tony Lindgren 2009-05-19 23:48 ` Pandita, Vikram 2009-05-19 23:55 ` Tony Lindgren 2009-05-20 0:01 ` Pandita, Vikram 2009-05-20 0:10 ` Pandita, Vikram 2009-05-20 21:12 ` Tony Lindgren 2009-05-20 21:15 ` Pandita, Vikram 2009-05-15 22:34 ` [PATCH v3 0/3] Support " Kevin Hilman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox