Re: [PATCH 5/7] omap iommu: entries for Kconfig and Makefile

Felipe Contreras
2009-05-20T13:40:54Z

On Wed, May 20, 2009 at 9:42 AM, Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
>
>  arch/arm/plat-omap/Kconfig  |    6 ++++++
>  arch/arm/plat-omap/Makefile |    1 +
>  2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index 9dd68fa..30e47a3 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -115,6 +115,12 @@ config OMAP_MBOX_FWK
>          Say Y here if you want to use OMAP Mailbox framework support for
>          DSP, IVA1.0 and IVA2 in OMAP1/2/3.
>
> +config OMAP_IOMMU
> +       tristate "IOMMU support"

Should be:
+ tristate

As Russell suggested there's not point in letting users manually
enable or disable it. It only makes sense when you use camera or dsp.

> +       help
> +         Say Y here if you want to use OMAP IOMMU support for IVA2 and
> +         Camera in OMAP3.
> +
>  choice
>         prompt "System timer"
>        default OMAP_MPU_TIMER
> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile
> index 04a100c..a832795 100644
> --- a/arch/arm/plat-omap/Makefile
> +++ b/arch/arm/plat-omap/Makefile
> @@ -13,6 +13,7 @@ obj-  :=
>  obj-$(CONFIG_ARCH_OMAP16XX) += ocpi.o
>
>  obj-$(CONFIG_OMAP_MCBSP) += mcbsp.o
> +obj-$(CONFIG_OMAP_IOMMU) += iommu.o iovmm.o
>
>  obj-$(CONFIG_CPU_FREQ) += cpu-omap.o
>  obj-$(CONFIG_OMAP_DM_TIMER) += dmtimer.o
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html