Re: [PATCH 5/8] ARM: OMAP3: Add support for OMAP3 Zoom2 board, v2

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Thu, May 28, 2009 at 02:13:06PM -0700, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [090528 09:05]:
> > On Mon, May 25, 2009 at 10:53:35AM -0700, Tony Lindgren wrote:
> > > diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c
> > > new file mode 100644
> > > index 0000000..91f07c1
> > > --- /dev/null
> > > +++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
> > > @@ -0,0 +1,160 @@
> > > +/*
> > > + * Copyright (C) 2009 Texas Instruments Inc.
> > > + * Mikkel Christensen <mlc@ti.com>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License version 2 as
> > > + * published by the Free Software Foundation.
> > > + */
> > > +
> > > +#include <linux/kernel.h>
> > > +#include <linux/init.h>
> > > +#include <linux/serial_8250.h>
> > > +#include <linux/smsc911x.h>
> > > +
> > > +#include <mach/gpio.h>
> > 
> > linux/gpio.h please.
> > 
> > > diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c
> > > new file mode 100644
> > > index 0000000..d4cd7ff
> > > --- /dev/null
> > > +++ b/arch/arm/mach-omap2/board-zoom2.c
> > > @@ -0,0 +1,110 @@
> > > +/*
> > > + * Copyright (C) 2009 Texas Instruments Inc.
> > > + * Mikkel Christensen <mlc@ti.com>
> > > + *
> > > + * Modified from mach-omap2/board-ldp.c
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License version 2 as
> > > + * published by the Free Software Foundation.
> > > + */
> > > +
> > > +#include <linux/kernel.h>
> > > +#include <linux/init.h>
> > > +#include <linux/platform_device.h>
> > > +#include <linux/i2c/twl4030.h>
> > > +
> > > +#include <asm/mach-types.h>
> > > +#include <asm/mach/arch.h>
> > > +
> > > +#include <mach/gpio.h>
> > 
> > Ditto.
> 
> Good eye. Here's this one updated.

Nothing really to do with eyes, more to do with regexps in .muttrc
highlighting this stuff with a red background...  It currently is
setup as:

color body white red "(\\+#include <(asm|mach)/(gp)?io\.h>|return -1|default n)"

but will probably expand more over time.