From: Jarkko Nikula <jhnikula@gmail.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: linux-omap@vger.kernel.org, alsa-devel@vger.kernel.org
Subject: Re: Please help in adding ams-delta support to ASoC
Date: Fri, 5 Jun 2009 16:55:31 +0300 [thread overview]
Message-ID: <20090605165531.7d0c4522.jhnikula@gmail.com> (raw)
In-Reply-To: <200906030924.14230.jkrzyszt@tis.icnet.pl>
On Wed, 3 Jun 2009 09:24:12 +0200
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
> Thanks! The origial driver with commented out clk_enable(vc_clk) and
> clk_disable(vc_clk) still works for me, so MCLK is not required! If I
> only knew what to do with this finding...
>
Optimize out one needless clock :-)
> > Just hack the same "static struct omap_mcbsp_reg_cfg mcbsp_regs =
> > { ..." in omap-mcbsp.c and pass that structure instead of
> > &mcbsp_data->regs to omap_mcbsp_config in omap_mcbsp_dai_hw_params.
>
> Done. Did not help. Again, I really don't know how to make use of
> this finding except for looking in a different place.
>
Ok, so looks that McBSP settings have nothing to do.
I got one another idea, quite far also, but omap_set_dma_params helper
function calls omap_set_dma_xxx_params functions in different order
than older sound/arm/omap/omap-alsa-dma.c: audio_set_dma_params_play.
While I don't believe that call order has something to do on 1510
versus other omaps, it's easy to try by changing call order in
arch/arm/plat-omap/dma.c: omap_set_dma_params.
Of course you could try to also copy transfer setup from
audio_set_dma_params_play into omap_pcm_prepare. Use prtd->dma_ch as
channel, runtime->dma_addr as a dma_ptr and
snd_pcm_lib_period_bytes(substream) as a dma_size. That should make the
DMA setup same than older implementation.
Hopefully these speculations would help you to find out at least one DMA
interrupt.
--
Jarkko
next prev parent reply other threads:[~2009-06-05 13:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 13:17 Please help in adding ams-delta support to ASoC Janusz Krzysztofik
2009-05-27 5:57 ` Peter Ujfalusi
2009-05-27 13:07 ` Janusz Krzysztofik
2009-06-02 5:47 ` Peter Ujfalusi
2009-06-02 11:38 ` Janusz Krzysztofik
2009-05-27 6:59 ` Jarkko Nikula
2009-05-27 14:33 ` Janusz Krzysztofik
2009-05-27 15:19 ` Jarkko Nikula
2009-05-27 18:58 ` Janusz Krzysztofik
2009-06-01 12:41 ` Janusz Krzysztofik
2009-06-01 18:04 ` Jarkko Nikula
2009-06-02 6:08 ` Peter Ujfalusi
2009-06-02 6:22 ` Jarkko Nikula
2009-06-02 13:35 ` Janusz Krzysztofik
2009-06-02 17:32 ` Jarkko Nikula
2009-06-03 7:24 ` Janusz Krzysztofik
2009-06-05 13:55 ` Jarkko Nikula [this message]
2009-06-05 22:28 ` Janusz Krzysztofik
2009-06-05 22:45 ` [alsa-devel] " Mark Brown
2009-06-06 17:42 ` Janusz Krzysztofik
2009-06-07 9:40 ` Mark Brown
2009-06-09 7:12 ` Peter Ujfalusi
2009-06-09 15:17 ` [alsa-devel] " Janusz Krzysztofik
2009-06-10 8:12 ` Peter Ujfalusi
2009-06-10 10:27 ` [alsa-devel] " Janusz Krzysztofik
2009-06-10 10:53 ` Peter Ujfalusi
2009-06-10 12:20 ` Janusz Krzysztofik
2009-06-10 18:05 ` Janusz Krzysztofik
2009-06-10 14:20 ` Janusz Krzysztofik
2009-06-08 6:40 ` Jarkko Nikula
2009-06-09 15:00 ` Janusz Krzysztofik
2009-06-15 13:22 ` Janusz Krzysztofik
2009-06-15 15:16 ` Jarkko Nikula
2009-06-16 14:43 ` Janusz Krzysztofik
2009-06-17 14:12 ` Progress in adding ams-delta support to ASoC? Janusz Krzysztofik
2009-06-18 9:02 ` Peter Ujfalusi
2009-06-18 7:58 ` Tony Lindgren
2009-06-18 11:51 ` Janusz Krzysztofik
2009-06-18 10:21 ` Tony Lindgren
2009-06-18 6:07 ` Please help in adding ams-delta support to ASoC Jarkko Nikula
2009-06-18 11:40 ` Janusz Krzysztofik
2009-06-19 3:50 ` Arun K S
2009-06-19 11:20 ` Janusz Krzysztofik
2009-06-19 18:55 ` Arun K S
2009-06-22 11:47 ` Jarkko Nikula
2009-06-23 11:58 ` Janusz Krzysztofik
2009-06-02 10:50 ` *SPAM* " Janusz Krzysztofik
2009-06-03 5:28 ` Peter Ujfalusi
2009-06-03 8:28 ` Janusz Krzysztofik
[not found] ` <20090527104711.GA1970@sirena.org.uk>
2009-06-02 7:24 ` Janusz Krzysztofik
2009-06-02 9:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605165531.7d0c4522.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@vger.kernel.org \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox