From: "Luke-Jr" <luke@dashjr.org>
To: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Solution: N810 keyboard regression
Date: Sat, 6 Jun 2009 16:51:34 -0500 [thread overview]
Message-ID: <200906061651.43882.luke@dashjr.org> (raw)
Found the problem with the 2.6.29 N810 keyboard regression in this commit:
commit c83702a764c3099df50f215b8e79e07344e34a1a
Author: Felipe Balbi <felipe.balbi@nokia.com>
Date: Thu Feb 19 12:29:40 2009 +0000
input: lm8323: get rid of useless debug macro
we can use dev_vdbg() which is only true when VERBOSE is enabled.
Part of this commit removed the "default" values for platform parameters, but
set the N810's size_y to 8 instead of the earlier default of 12. Changing this
to 12 (patch to follow) fixes the keyboard regression. Note, the total keys on
the N810 is in fact under 64, so 8x8 seems correct. Not sure why it doesn't
work like that in practise. I did notice a curious line in the driver that
might (or might not) be related/wrong...
drivers/input/keyboard/lm8323.c line 353:
int keysize = (lm->size_x << 4) | lm->size_y;
Shouldn't this be lm->size_x * lm->size_y?
Luke
next reply other threads:[~2009-06-06 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-06 21:51 Luke-Jr [this message]
2009-06-06 22:42 ` Solution: N810 keyboard regression Felipe Balbi
2009-06-06 23:15 ` Luke-Jr
2009-06-08 9:01 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906061651.43882.luke@dashjr.org \
--to=luke@dashjr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox