From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Andrew de Quincey <adq_dvb@lidskialf.net>
Cc: "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: Patch: Init/shutdown correctness fixes for drivers/cbus/tahvo*
Date: Thu, 11 Jun 2009 23:36:57 +0300 [thread overview]
Message-ID: <20090611203657.GB31172@nokia.com> (raw)
In-Reply-To: <20090611182646.68427jqmiduhec8w@lidskialf.net>
Hi,
On Thu, Jun 11, 2009 at 07:26:46PM +0200, ext Andrew de Quincey wrote:
> Hi - the current phase I'm in of this development is to simply get the
> thing working reliably again; that includes cleanup etc as appropriate.
>
> Once that is complete, i want to go back and refactor all the drivers
> s that they do exactly what you suggest above, as well as using the
> latest kernel APIs, modularisation where appropriate etc, with a view
> to being suitable for mainline (even if they are not actually
> submitted to mainline).
>
> I don't want to do both at once because I feel that is too big a step
> for this older slightly unmaintained code. Is it acceptable to you to
> commit this patch in the interim?
That's fine then, but at least fix this line:
+ struct tahvo_usb *tu = (struct tahvo_usb*) pdev->dev.driver_data;
then you have my ack
--
balbi
prev parent reply other threads:[~2009-06-11 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 23:20 Patch: Init/shutdown correctness fixes for drivers/cbus/tahvo* Andrew de Quincey
2009-06-02 18:28 ` Tony Lindgren
2009-06-08 19:47 ` Andrew de Quincey
2009-06-11 9:37 ` Felipe Balbi
2009-06-11 17:26 ` Andrew de Quincey
2009-06-11 20:36 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611203657.GB31172@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=adq_dvb@lidskialf.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox