Re: [PATCH] OMAP: McSPI: Fix RX DMA transfer path

[Tony Lindgren <tony@atomide.com>]

* Kalle Valo <kalle.valo@iki.fi> [090613 09:45]:
> Aaro Koskinen <aaro.koskinen@nokia.com> writes:
> 
> > From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
> >
> > When data is read through DMA, the last element must be read separately
> > through the RX register. It cannot be transferred by the DMA. For further
> > details see e.g. OMAP3430 TRM.
> >
> > Without the fix the driver causes extra clocks to be clocked to the
> > bus after DMA RX operations. This can cause interesting behaviour with
> > some devices.
> 
> I was hit by this with stlc45xx and earlier versions of Juuso's patch at
> least fixed the problem.
> 
> I will test this patch as soon as I get N800 boot with latest
> linux-omap, now I only get this:
> 
> <6>JFFS2 version 2.2. (NAND) (SUMMARY)  © 2001-2006 Red Hat, Inc.
> <6>JFFS2 version 2.2. (NAND) (SUMMARY)  © 2001-2006 Red H
> <6>msgmni has been set to 247
> <6>io scheduler noop registered (default)
> <6>omapfb: ls041y3 rev 87 LCD detected, 0 data lines      d
> <6>serial8250.0: ttyS0 at MMIO 0x4806a000 (irq = 72) is a ST16654
> <6>serial8250.0: ttyS1 at MMIO 0x4806e000 (irq = 74) is a ST16654
> <ó"F:­5 #!*$Õ<ó¬#0­5 #!*$Õ<ó­r%
> µ²² æ2Õ<ó$¶ #®*#5##¹'%Õ<ó#62°$¶ ¹)K!¥º¹'Õ<ó¬¹5 K#z 0«²)Ñ%f¡T:6æ0ªÿ<ó¯
> ó
> %°ö2­Õ³#²©T ô­#.#É ,­#2¬#£µ0V³/­5 V§Í#%Rí<ó00¢F ô- ¹##£$¶ +3Sí<ó
> 0
> ·#
>   # V60±:)¥#
> ,#µ¥Õ46 V#Õ#
> ¬é)¶.¹ªÿ<óµ&£É%²:©F%V$®º ¹##£$¶
>  Í#É¡*ªÿ<óµ&                            ©#­0Á:£µ­.#µ¥Õ4#Ô#Kªÿ#ó#Í!Ä)
>  %
> ³3{%°ö2­±9±Sí<ó"Õ {/+#í#ó#Í!Ä)4?+#í#ó#Í!Ä)4ó ö£U4¬¹ ¹)K!)º"ªÿ<ó"Õ%{/C:³ô
> Ù¯    s
> ®Ñ ®®Ò 335<#U2,°®!Ä)  ô2V#"ö/ë"¢#4/##®#%!V C%!

Might be related to the omap specific ATAGs now gone, sorry but that
just had to go to get things in sync. And it should not come as a
surprise as it's been discussed over past few years :)

The missing data needs to be initialized in platform_data, cmdline,
ARM generic ATAGs, upcoming device tree.. I suggest using platform_data
where possible. The GPIO values etc coming from nolo can be dumped
with some earlier kernel using CONFIG_ATAGS_PROC.

BTW, I'll move the n8x0 board-*.c files around a bit to have just
board-n800.c, board-n810.c and board-n8x0-peripherals.c.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html