From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [patch] Fix brf6510 cleanup code Date: Mon, 15 Jun 2009 01:58:56 -0700 Message-ID: <20090615085855.GH4474@atomide.com> References: <20090530180721.75203sfsqbpppfi8@lidskialf.net> <20090608210333.11295srly8te8xog@lidskialf.net> <20090615080242.GD4474@atomide.com> <4A360897.1050701@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:60217 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758765AbZFOI6z (ORCPT ); Mon, 15 Jun 2009 04:58:55 -0400 Content-Disposition: inline In-Reply-To: <4A360897.1050701@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Ville Tervo Cc: Andrew de Quincey , "linux-omap@vger.kernel.org" * Ville Tervo [090615 01:39]: > Hi Andrew, > > ext Tony Lindgren wrote: >> * Andrew de Quincey [090608 13:04]: >>> The brf6150 driver is missing several necessary cleanup steps to >>> allow module unloading. Add them. > > Yes. This driver was used as compiled in driver and seems to be missing > cleanups. > > As you may have noticed this brf6150 driver has been replaced by hci_h4p > drier in later tablets and the easiest way to maintain support for Nokia > 770 bluetooth would be to make sure that also brf6150 works with the > current driver. AFAIK it should work with quite little modifications. > The settings negotiation is a little bit different. > >> >> I've removed the brf6150 from linux-omap as this should get merged into >> the mainline kernel via bt list. >> >> Ville & Andrew, can you guys please coordinate on the bt list to get >> the driver merged in? I believe there were some changes needed for >> passing the hw address as a module option and for loading the firmware >> or something.. > > Is 2.6.30 booting in Nokia 770/N800/N810? If so then I guess this should > be quite easy task. No.. The board files are missing, drivers/cbus is missing, and the code depends on omap specific ATAGs. Hopefully we can get the minimal support into 2.6.31 though. Tony