L-O master branch broken ?

L-O master branch broken ?

[Hemanth V]

I get the below error while compiling 3430SDP. I see below commit  as the 
latest one.

Hemanth

commit 3dc15d62d3f8e85d74dcbabc234585cb8dbc2194
Author: Tony Lindgren <tony@atomide.com>
Date:   Thu Jun 18 08:59:09 2009 +0300

    Fix iommu.c file permissions

    Commit c8c8bfc4c3664317441b0037040c9bdea210fba1 changed the
    permissions, so undo that. Also checked the other files with:

    $ find arch/arm/*omap* -type f -perm 755

    Signed-off-by: Tony Lindgren <tony@atomide.com>


arch/arm/plat-omap/sram.c: In function 'omap_detect_sram':
arch/arm/plat-omap/sram.c:139: error: expected expression before 'else'
arch/arm/plat-omap/sram.c:190: warning: ISO C90 forbids mixed declarations 
and code
arch/arm/plat-omap/sram.c:347: error: invalid storage class for function 
'omap242x_sram_init'
arch/arm/plat-omap/sram.c:368: error: invalid storage class for function 
'omap243x_sram_init'
arch/arm/plat-omap/sram.c:433: error: expected declaration or statement at 
end of input
make[1]: *** [arch/arm/plat-omap/sram.o] Error 1
make: *** [arch/arm/plat-omap] Error 2

Re: L-O master branch broken ?

[Tony Lindgren]

* Hemanth V <hemanthv@ti.com> [090618 12:35]:
> I get the below error while compiling 3430SDP. I see below commit  as the 
> latest one.

Thanks, pushing a fix right now with the missing brace missing from Kevin's
sram.c patch. Also moved around the defines so sram.c build for omap1.

Regards,

Tony


> Hemanth
>
> commit 3dc15d62d3f8e85d74dcbabc234585cb8dbc2194
> Author: Tony Lindgren <tony@atomide.com>
> Date:   Thu Jun 18 08:59:09 2009 +0300
>
>    Fix iommu.c file permissions
>
>    Commit c8c8bfc4c3664317441b0037040c9bdea210fba1 changed the
>    permissions, so undo that. Also checked the other files with:
>
>    $ find arch/arm/*omap* -type f -perm 755
>
>    Signed-off-by: Tony Lindgren <tony@atomide.com>
>
>
> arch/arm/plat-omap/sram.c: In function 'omap_detect_sram':
> arch/arm/plat-omap/sram.c:139: error: expected expression before 'else'
> arch/arm/plat-omap/sram.c:190: warning: ISO C90 forbids mixed 
> declarations and code
> arch/arm/plat-omap/sram.c:347: error: invalid storage class for function  
> 'omap242x_sram_init'
> arch/arm/plat-omap/sram.c:368: error: invalid storage class for function  
> 'omap243x_sram_init'
> arch/arm/plat-omap/sram.c:433: error: expected declaration or statement 
> at end of input
> make[1]: *** [arch/arm/plat-omap/sram.o] Error 1
> make: *** [arch/arm/plat-omap] Error 2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: L-O master branch broken ?

[Hemanth V]

----- Original Message ----- 
From: "Tony Lindgren" <tony@atomide.com>


>> I get the below error while compiling 3430SDP. I see below commit  as the
>> latest one.

>
> Thanks, pushing a fix right now with the missing brace missing from 
> Kevin's
> sram.c patch. Also moved around the defines so sram.c build for omap1.
>

Booting still seems to have problems. Its hung after start kernel


Bytes transferred = 2480664 (25da18 hex)
## Booting image at 80000000 ...
   Image Name:   Linux-2.6.30-omap1-06022-g6f4712
   Image Type:   ARM Linux Kernel Image (uncompressed)
   Data Size:    2480600 Bytes =  2.4 MB
   Load Address: 80008000
   Entry Point:  80008000
   Verifying Checksum ... OK
OK

Starting kernel ... 

Re: L-O master branch broken ?

[Tony Lindgren]

* Hemanth V <hemanthv@ti.com> [090618 13:39]:
> ----- Original Message ----- From: "Tony Lindgren" <tony@atomide.com>
>
>
>>> I get the below error while compiling 3430SDP. I see below commit  as the
>>> latest one.
>
>>
>> Thanks, pushing a fix right now with the missing brace missing from  
>> Kevin's
>> sram.c patch. Also moved around the defines so sram.c build for omap1.
>>
>
> Booting still seems to have problems. Its hung after start kernel
>
>
> Bytes transferred = 2480664 (25da18 hex)
> ## Booting image at 80000000 ...
>   Image Name:   Linux-2.6.30-omap1-06022-g6f4712
>   Image Type:   ARM Linux Kernel Image (uncompressed)
>   Data Size:    2480600 Bytes =  2.4 MB
>   Load Address: 80008000
>   Entry Point:  80008000
>   Verifying Checksum ... OK
> OK
>
> Starting kernel ... 
>

Can you see what happens with DEBUG_LL enabled?

Tony

Re: L-O master branch broken ?

[Hemanth V]

----- Original Message ----- 
From: "Tony Lindgren" <tony@atomide.com>
To: "Hemanth V" <hemanthv@ti.com>
Cc: "Kevin Hilman" <khilman@deeprootsystems.com>; 
<linux-omap@vger.kernel.org>
Sent: Thursday, June 18, 2009 3:52 PM
Subject: Re: L-O master branch broken ?


>* Hemanth V <hemanthv@ti.com> [090618 13:39]:
>> ----- Original Message ----- From: "Tony Lindgren" <tony@atomide.com>
>>
>>
>>>> I get the below error while compiling 3430SDP. I see below commit  as 
>>>> the
>>>> latest one.
>>
>>>
>>> Thanks, pushing a fix right now with the missing brace missing from
>>> Kevin's
>>> sram.c patch. Also moved around the defines so sram.c build for omap1.
>>>
>>
>> Booting still seems to have problems. Its hung after start kernel
>>
>>
>> Bytes transferred = 2480664 (25da18 hex)
>> ## Booting image at 80000000 ...
>>   Image Name:   Linux-2.6.30-omap1-06022-g6f4712
>>   Image Type:   ARM Linux Kernel Image (uncompressed)
>>   Data Size:    2480600 Bytes =  2.4 MB
>>   Load Address: 80008000
>>   Entry Point:  80008000
>>   Verifying Checksum ... OK
>> OK
>>
>> Starting kernel ...
>>
>
> Can you see what happens with DEBUG_LL enabled?

Doesn't seem to show any additional messages even with
DEBUG_LL enabled 

Re: L-O master branch broken ?

[Kevin Hilman]

"Hemanth V" <hemanthv@ti.com> writes:

> ----- Original Message ----- 
> From: "Tony Lindgren" <tony@atomide.com>
> To: "Hemanth V" <hemanthv@ti.com>
> Cc: "Kevin Hilman" <khilman@deeprootsystems.com>;
> <linux-omap@vger.kernel.org>
> Sent: Thursday, June 18, 2009 3:52 PM
> Subject: Re: L-O master branch broken ?
>
>
>>* Hemanth V <hemanthv@ti.com> [090618 13:39]:
>>> ----- Original Message ----- From: "Tony Lindgren" <tony@atomide.com>
>>>
>>>
>>>>> I get the below error while compiling 3430SDP. I see below commit
>>>>> as the
>>>>> latest one.
>>>
>>>>
>>>> Thanks, pushing a fix right now with the missing brace missing from
>>>> Kevin's
>>>> sram.c patch. Also moved around the defines so sram.c build for omap1.
>>>>
>>>
>>> Booting still seems to have problems. Its hung after start kernel
>>>
>>>
>>> Bytes transferred = 2480664 (25da18 hex)
>>> ## Booting image at 80000000 ...
>>>   Image Name:   Linux-2.6.30-omap1-06022-g6f4712
>>>   Image Type:   ARM Linux Kernel Image (uncompressed)
>>>   Data Size:    2480600 Bytes =  2.4 MB
>>>   Load Address: 80008000
>>>   Entry Point:  80008000
>>>   Verifying Checksum ... OK
>>> OK
>>>
>>> Starting kernel ...
>>>
>>
>> Can you see what happens with DEBUG_LL enabled?
>
> Doesn't seem to show any additional messages even with
> DEBUG_LL enabled 

Since you don't even see 'Uncompressing Linux....', I'm guessing you
have CONFIG_OMAP_LL_DEBUG_UART3=y in your .config

Try setting this to UART1.

Kevin

RE: L-O master branch broken ?

[Aguirre Rodriguez, Sergio Alberto]

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Kevin Hilman
> Sent: Thursday, June 18, 2009 10:32 AM
> To: V, Hemanth
> Cc: Tony Lindgren; linux-omap@vger.kernel.org
> Subject: Re: L-O master branch broken ?
> 
> "Hemanth V" <hemanthv@ti.com> writes:
> 
> > ----- Original Message -----
> > From: "Tony Lindgren" <tony@atomide.com>
> > To: "Hemanth V" <hemanthv@ti.com>
> > Cc: "Kevin Hilman" <khilman@deeprootsystems.com>;
> > <linux-omap@vger.kernel.org>
> > Sent: Thursday, June 18, 2009 3:52 PM
> > Subject: Re: L-O master branch broken ?
> >
> >
> >>* Hemanth V <hemanthv@ti.com> [090618 13:39]:
> >>> ----- Original Message ----- From: "Tony Lindgren" <tony@atomide.com>
> >>>
> >>>
> >>>>> I get the below error while compiling 3430SDP. I see below commit
> >>>>> as the
> >>>>> latest one.
> >>>
> >>>>
> >>>> Thanks, pushing a fix right now with the missing brace missing from
> >>>> Kevin's
> >>>> sram.c patch. Also moved around the defines so sram.c build for
> omap1.
> >>>>
> >>>
> >>> Booting still seems to have problems. Its hung after start kernel
> >>>
> >>>
> >>> Bytes transferred = 2480664 (25da18 hex)
> >>> ## Booting image at 80000000 ...
> >>>   Image Name:   Linux-2.6.30-omap1-06022-g6f4712
> >>>   Image Type:   ARM Linux Kernel Image (uncompressed)
> >>>   Data Size:    2480600 Bytes =  2.4 MB
> >>>   Load Address: 80008000
> >>>   Entry Point:  80008000
> >>>   Verifying Checksum ... OK
> >>> OK
> >>>
> >>> Starting kernel ...
> >>>
> >>
> >> Can you see what happens with DEBUG_LL enabled?
> >
> > Doesn't seem to show any additional messages even with
> > DEBUG_LL enabled
> 
> Since you don't even see 'Uncompressing Linux....', I'm guessing you
> have CONFIG_OMAP_LL_DEBUG_UART3=y in your .config
> 
> Try setting this to UART1.

I tried this on my SDP, and enabling both options, it boots!

But without enabling low level debug, it doesn't...

Does that ring any bells? Am I missing something?

Regards,
Sergio

> 
> Kevin
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html