public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: "Woodruff, Richard" <r-woodruff2-l0cyMroinI0@public.gmane.org>
Cc: Niilo Minkkinen
	<ext-niilo.1.minkkinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org"
	<tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] usb: disable OTG AUTOIDLE only with omap3430
Date: Fri, 19 Jun 2009 03:35:50 -0700	[thread overview]
Message-ID: <200906190335.50621.david-b@pacbell.net> (raw)
In-Reply-To: <13B9B4C6EF24D648824FF11BE8967162038BED5CF1-EovWT4A8QTWIQmiDNMet8wC/G2K4zDHf@public.gmane.org>

On Monday 18 May 2009, Woodruff, Richard wrote:
> 
> > From: linux-omap-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-omap-
> > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Niilo Minkkinen
> > Sent: Monday, May 18, 2009 9:54 AM
> 
> > Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG
> > register prevents the device from going into retention.
> > This is a workaround (by Richard Woodruff/TI), as his comment :
> > > A new MUSB bug which is a match to data below was identified very
> > > recently (on hardware and in simulation).
> > > This bug is in 3430 and not 3630.
> > > As a priority test (and as new default) you should have engineers
> > > disable autoidle for MUSB block.
> > > This is the workaround which will show up in next errata.
> >
> > Signed-off-by: Niilo Minkkinen <ext-niilo.1.minkkinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> 
> Signed-off-by: Richard Woodruff <r-woodruff2-l0cyMroinI0@public.gmane.org>
> 
> Yes this is needed for 34xx. Side note is this cost around 1mW of power
> during active mode of MUSB. When device is not active cost is not
> significant.  System impact depends on duty cycle of MUSB in usecase.  

There's also some initialization goofiness in that code ... it's supposed
to set initialize the transceiver with several distinct writes, of which
setting AUTOIDLE (to auto-gate the L3 clock) is ISTR the last step.

The goofiness shows up with OTG initialization, which is documented as
needing a slightly different sequence ... my notes have it as being
an extra write to set ENABLEFORCE.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-06-19 10:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 14:54 [PATCH] usb: disable OTG AUTOIDLE only with omap3430 Niilo Minkkinen
     [not found] ` <1242658456-5723-1-git-send-email-ext-niilo.1.minkkinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-05-18 19:23   ` Woodruff, Richard
2009-05-19 16:57     ` Kevin Hilman
     [not found]     ` <13B9B4C6EF24D648824FF11BE8967162038BED5CF1-EovWT4A8QTWIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-06-19 10:35       ` David Brownell [this message]
     [not found]         ` <200906190335.50621.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-06-19 16:45           ` Niilo Minkkinen
2009-08-26 11:47       ` Gupta, Ajay Kumar
     [not found]         ` <19F8576C6E063C45BE387C64729E73940436A4A15B-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-26 13:53           ` Niilo Minkkinen
     [not found]             ` <fb705f540908260653l990f173n8b953ebc893efb9e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-08-26 14:52               ` Pandita, Vikram
2009-08-27  1:27                 ` Gupta, Ajay Kumar
2009-08-28  5:08           ` Gupta, Ajay Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906190335.50621.david-b@pacbell.net \
    --to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
    --cc=ext-niilo.1.minkkinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=r-woodruff2-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox