Re: [PATCH v2 1/2] OMAP3:Zoom2: Add TWL4030 support

[Tony Lindgren <tony@atomide.com>]

* Vikram Pandita <vikram.pandita@ti.com> [090619 01:18]:
> Add TWL4030 CORE and TWL4030 drivers to Zoom2 board file
> TWL drivers enabled are:
> 	bci
> 	madc
> 	usb
> 	keypad
> 	mmc
> 
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
>  arch/arm/mach-omap2/board-zoom2.c |  209 +++++++++++++++++++++++++++++++++++--
>  1 files changed, 198 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c
> index bcc0f76..443859c 100644
> --- a/arch/arm/mach-omap2/board-zoom2.c
> +++ b/arch/arm/mach-omap2/board-zoom2.c
> @@ -12,17 +12,88 @@
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/platform_device.h>
> +#include <linux/input.h>
>  #include <linux/gpio.h>
>  #include <linux/i2c/twl4030.h>
> +#include <linux/regulator/machine.h>
>  
>  #include <asm/mach-types.h>
>  #include <asm/mach/arch.h>
>  
>  #include <mach/common.h>
>  #include <mach/usb.h>
> +#include <mach/keypad.h>
>  
>  #include "mmc-twl4030.h"
>  
> +#ifndef CONFIG_TWL4030_CORE
> +#error "no power companion board defined!"
> +#endif

This does not look right. You should still be able to boot the board even without
twl compiled in. Or compile twl as a module. Currently we do have a bug where
mmc-twl4030.c forces mmc core to be compiled in because of the regulator fwk, but
that should be fixed by moving the regulator fwk calls to drivers/mmc/host/omap_hsmmc.c.

Regards,

Tony