From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Gadiyar, Anand" <gadiyar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"me@felipebalbi.com" <me@felipebalbi.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] OMAP3: EHCI: Allow EHCI to work as a module again
Date: Mon, 6 Jul 2009 10:13:16 +0300 [thread overview]
Message-ID: <20090706071316.GI8461@nokia.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB0305C10FA4@dbde02.ent.ti.com>
On Mon, Jul 06, 2009 at 09:05:09AM +0200, ext Gadiyar, Anand wrote:
> From: Anand Gadiyar <gadiyar@ti.com>
>
> OMAP3: EHCI: Allow EHCI to work as a module again
>
> commit fc3c45ca seems to have broken EHCI as a module. Fix this.
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
hmm... that was a bad mistake :-s
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> diff --git a/arch/arm/mach-omap2/usb-ehci.c b/arch/arm/mach-omap2/usb-ehci.c
> index 0fe26f2..56fc7f4 100644
> --- a/arch/arm/mach-omap2/usb-ehci.c
> +++ b/arch/arm/mach-omap2/usb-ehci.c
> @@ -27,7 +27,7 @@
> #include <mach/irqs.h>
> #include <mach/usb.h>
>
> -#if defined(CONFIG_USB_EHCI_HCD) || #define(CONFIG_USB_EHCI_HCD_MODULE)
> +#if defined(CONFIG_USB_EHCI_HCD) || defined(CONFIG_USB_EHCI_HCD_MODULE)
>
> static struct resource ehci_resources[] = {
> {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
next prev parent reply other threads:[~2009-07-06 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 7:05 [PATCH] OMAP3: EHCI: Allow EHCI to work as a module again Gadiyar, Anand
2009-07-06 7:13 ` Felipe Balbi [this message]
2009-08-05 13:23 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706071316.GI8461@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox