From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Gupta, Ajay Kumar" <ajay.gupta@ti.com>
Cc: Dmitry Krivoschekov <dmitry.krivoschekov@gmail.com>,
no To-header on input <"unlisted-recipients:;"@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"tony@atomide.com" <tony@atomide.com>
Subject: Re: [PATCH 2/2] ehci: Fix EHCI init for OMAP3EVM
Date: Mon, 6 Jul 2009 12:50:59 +0300 [thread overview]
Message-ID: <20090706095059.GQ8461@nokia.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739404328C675C@dbde02.ent.ti.com>
Hi,
On Mon, Jul 06, 2009 at 10:55:05AM +0200, ext Gupta, Ajay Kumar wrote:
> Looks better but if USB itself is not included in the build then this part of code would be unnecessary in board-omap3evm.c. We again need to add some #ifdef there to avoid this.
>
> Another solution is to add something like board_is_omap3evm() in <mach/board.h> and use them in usb-ehci.c.
>
> Felipe, what do you suggest?
how about passing setup() and cleanup() function pointers from
board-file to the driver via platform_data ?
the board-specific setup() could handle the mux config then.
--
balbi
next prev parent reply other threads:[~2009-07-06 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 7:58 [PATCH 2/2] ehci: Fix EHCI init for OMAP3EVM Ajay Kumar Gupta
[not found] ` <4A51B500.1080004@gmail.com>
2009-07-06 8:55 ` Gupta, Ajay Kumar
2009-07-06 9:50 ` Felipe Balbi [this message]
2009-07-06 9:53 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706095059.GQ8461@nokia.com \
--to=felipe.balbi@nokia.com \
--cc="unlisted-recipients:;"@gmail.com \
--cc=ajay.gupta@ti.com \
--cc=dmitry.krivoschekov@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox