public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@verdurent.com>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: Vikram Pandita <vikram.pandita@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] TWL4030:TWL5030:TPS659x0: add keypad support
Date: Wed, 22 Jul 2009 17:25:06 +0300	[thread overview]
Message-ID: <20090722142506.GC4790@everest> (raw)
In-Reply-To: <5d5443650907200006h29b75a94kfab151a900f00fd@mail.gmail.com>

On 09 Jul 20, Trilok Soni wrote:
> Hi Vikram,
> 
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +#include <linux/init.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/input.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/i2c/twl4030.h>
> > +#include <mach/keypad.h>
> 
> One empty line between above two headers.
> 
> I hope you are aware of earlier comments posted for this driver when
> it was submitted few months back and had long discussion on threaded
> irq stuff.
>

Trilok,

Could you please post a link to that discussion. Google isn't pointing
me to any relevant discussions besides
http://lkml.org/lkml/2008/10/1/334

I'll do a further cleanup and resubmit.

Regards,
Amit

  reply	other threads:[~2009-07-22 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-18  0:13 [PATCH] TWL4030:TWL5030:TPS659x0: add keypad support Vikram Pandita
2009-07-20  7:06 ` Trilok Soni
2009-07-22 14:25   ` Amit Kucheria [this message]
2009-07-22 18:43     ` Trilok Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090722142506.GC4790@everest \
    --to=amit.kucheria@verdurent.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=soni.trilok@gmail.com \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox