From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [alsa-devel] [RFC] [PATCH 3/3] ASoC: add support for Amstrad E3 (Delta) machine Date: Thu, 23 Jul 2009 09:57:38 +0100 Message-ID: <20090723085738.GC5744@rakim.wolfsonmicro.main> References: <200907220523.01107.jkrzyszt@tis.icnet.pl> <4A6727D8.5080808@tis.icnet.pl> <20090722150709.GB4987@rakim.wolfsonmicro.main> <200907222118.06396.jkrzyszt@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200907222118.06396.jkrzyszt@tis.icnet.pl> Sender: linux-serial-owner@vger.kernel.org To: Janusz Krzysztofik Cc: alsa-devel@alsa-project.org, Jonathan McDowell , Tony Lindgren , Peter Ujfalusi , "linux-kernel@vger.kernel.org" , e3-hacking@earth.li, Arun KS , "linux-serial@vger.kernel.org" , "linux-omap@vger.kernel.org" , Alan Cox , Takashi Iwai List-Id: linux-omap@vger.kernel.org On Wed, Jul 22, 2009 at 09:18:05PM +0200, Janusz Krzysztofik wrote: > After all, I am not sure what your preferences finally are. If you still think > that exporting gpio based jack state from ASoC framework over gpiolib sysfs > doesn't hurt and can be usefull, I'll remove the code from my driver and > provide a patch against sound/soc/soc-jack.c. But if you would rather prefere > exposing jack state in a more general, not gpio limited way instead, or > depend on input layer provided EVIOCGSW ioctl, as Dmitry suggested > (unfortunatelly, unlike generic ldattach, there is no utility ready for > use!), I'd rather keep this gpio_export() in my driver, let's say for > diagnostic purposes, at least until that different option is ready for use in > a convenient way. Jack state is already exposed via the input layer by the ALSA jack core. Reporting of GPIO state via gpio_export() would be additional to that and would be purely for debug purposes, it would not be recommended for use by userspace applications.