public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: linux-omap@vger.kernel.org
Cc: Rajendra Nayak <rnayak@ti.com>, Limei Wang <E12499@motorola.com>,
	Richard Woodruff <r-woodruff2@ti.com>,
	Girish Ghongdemath <girishsg@ti.com>
Subject: [PATCH 4/8] OMAP3 SDRC: Fix freeze when scaling CORE dpll to < 83Mhz
Date: Fri, 24 Jul 2009 20:11:27 -0600	[thread overview]
Message-ID: <20090725021127.29059.44697.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090725021102.29059.94214.stgit@localhost.localdomain>

From: Rajendra Nayak <rnayak@ti.com>

This patch fixes a bug in the CORE dpll scaling sequence which was
errouneously clearing some bits in the SDRC DLLA CTRL register and
hence causing a freeze.  The issue was observed only on platforms
which scale CORE dpll to < 83Mhz and hence program the DLL in fixed
delay mode.

Issue reported by Limei Wang <E12499@motorola.com>, with debugging
assistance from Richard Woodruff <r-woodruff2@ti.com> and Girish
Ghongdemath <girishsg@ti.com>.

Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Cc: Limei Wang <E12499@motorola.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Girish Ghongdemath <girishsg@ti.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
[paul@pwsan.com: updated patch description to include collaboration credits]
---
 arch/arm/mach-omap2/sram34xx.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/sram34xx.S b/arch/arm/mach-omap2/sram34xx.S
index 9c2d046..e6b1125 100644
--- a/arch/arm/mach-omap2/sram34xx.S
+++ b/arch/arm/mach-omap2/sram34xx.S
@@ -143,7 +143,7 @@ return_to_sdram:
 unlock_dll:
 	ldr	r11, omap3_sdrc_dlla_ctrl
 	ldr	r12, [r11]
-	and	r12, r12, #FIXEDDELAY_MASK
+	bic	r12, r12, #FIXEDDELAY_MASK
 	orr	r12, r12, #FIXEDDELAY_DEFAULT
 	orr	r12, r12, #DLLIDLE_MASK
 	str	r12, [r11]		@ (no OCP barrier needed)



  parent reply	other threads:[~2009-07-25  2:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-25  2:11 [PATCH 0/8] Fixes for OMAP2/3 SDRC/clock for 2.6.31-rc* Paul Walmsley
2009-07-25  2:11 ` [PATCH 1/8] OMAP3 SDRC: add support for 2 SDRAM chip selects Paul Walmsley
2009-07-25  2:11 ` [PATCH 2/8] OMAP3: Setup MUX settings for SDRC CKE signals Paul Walmsley
2009-07-25  2:11 ` [PATCH 3/8] OMAP2/3 SDRC: don't set SDRC_POWER.PWDENA on boot Paul Walmsley
2009-07-25  2:11 ` Paul Walmsley [this message]
2009-07-25  2:11 ` [PATCH 5/8] OMAP3 SDRC: Move the clk stabilization delay to the right place Paul Walmsley
2009-07-25  2:11 ` [PATCH 6/8] OMAP2/3 clock: split, rename omap2_wait_clock_ready() Paul Walmsley
2009-07-25  2:11 ` [PATCH 7/8] OMAP2 clock: 2430 I2CHS uses non-standard CM_IDLEST register Paul Walmsley
2009-07-25  2:11 ` [PATCH 8/8] OMAP3 clock: correct module IDLEST bits: SSI; DSS; USBHOST; HSOTGUSB Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090725021127.29059.44697.stgit@localhost.localdomain \
    --to=paul@pwsan.com \
    --cc=E12499@motorola.com \
    --cc=girishsg@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=r-woodruff2@ti.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox