From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [RFC] [PATCH 1/3] ASoC: Add support for Conexant CX20442-11 voice modem codec Date: Tue, 28 Jul 2009 16:07:27 +0100 Message-ID: <20090728150727.GA10870@rakim.wolfsonmicro.main> References: <200907220522.29221.jkrzyszt@tis.icnet.pl> <20090722101027.GA7622@sirena.org.uk> <200907281659.36000.jkrzyszt@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <200907281659.36000.jkrzyszt@tis.icnet.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Janusz Krzysztofik Cc: alsa-devel@alsa-project.org, Jonathan McDowell , Tony Lindgren , Peter Ujfalusi , "linux-kernel@vger.kernel.org" , e3-hacking@earth.li, Arun KS , "linux-serial@vger.kernel.org" , "linux-omap@vger.kernel.org" , Alan Cox List-Id: linux-omap@vger.kernel.org On Tue, Jul 28, 2009 at 04:59:33PM +0200, Janusz Krzysztofik wrote: > Following that model, the line discipline code didn't seam to belong to a > codec driver for me. If it could be recognized as a new bus dirver, it should > be pushed down probably into a separate module. However, if it was rather > some kind of a bus adapter driver, it seamed to belong to the machine code. The way it looks with the current code the line discipline itself is going to apply equally well to any serial port that's used - I'm not clear what's system-specific about it. The bit that connects the line discipline to the line is a different matter but the bit that interacts with the TTY layer after registration is working through a pluggable abstraction layer and shouldn't, I'd expect, be specific to the particular serial port.