From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
alsa-devel@alsa-project.org,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
e3-hacking@earth.li
Subject: Re: [RFC] [PATCH] ASoC: OMAP: full duplex mode fix
Date: Mon, 3 Aug 2009 10:43:47 +0100 [thread overview]
Message-ID: <20090803094346.GA7820@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20090803112950.3fb6cda9.jhnikula@gmail.com>
On Mon, Aug 03, 2009 at 11:29:50AM +0300, Jarkko Nikula wrote:
> Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
> > + else
> > + /* looks like playback already in progress,
> > + * start capture by taking it out of error condition */
> > + omap_mcbsp_pollread(mcbsp_data->bus_id, &buf);
> Minor note: See preferred style for multi-line comments in
> Documentation/CodingStyle. I'm not 100 % sure about the braces but I
> think they are also preferred if there are indented comment lines with
> the single code line.
Indeed; only omit the braces if the *only* thing in the block is a
single statement.
next prev parent reply other threads:[~2009-08-03 9:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 1:32 [RFC] [PATCH] ASoC: OMAP: full duplex mode fix Janusz Krzysztofik
2009-08-03 8:29 ` Jarkko Nikula
2009-08-03 9:43 ` Mark Brown [this message]
2009-08-03 14:00 ` Janusz Krzysztofik
2009-08-03 15:14 ` Jarkko Nikula
2009-08-04 20:46 ` Janusz Krzysztofik
2009-08-05 6:45 ` Peter Ujfalusi
2009-08-05 13:14 ` Janusz Krzysztofik
2009-08-06 9:30 ` Janusz Krzysztofik
2009-08-05 7:21 ` Jarkko Nikula
2009-08-05 8:42 ` Jarkko Nikula
2009-08-05 13:26 ` Janusz Krzysztofik
2009-08-06 0:27 ` Janusz Krzysztofik
2009-08-06 9:16 ` Janusz Krzysztofik
2009-08-03 17:53 ` Arun KS
2009-08-03 17:57 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803094346.GA7820@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=e3-hacking@earth.li \
--cc=jhnikula@gmail.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox