From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators Date: Tue, 4 Aug 2009 14:42:48 +0100 Message-ID: <20090804134247.GA32353@rakim.wolfsonmicro.main> References: <1248842173-21821-1-git-send-email-balajitk@ti.com> <20090803142356.GA4265@rakim.wolfsonmicro.main> <20090804074544.GG24334@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Shilimkar, Santosh" Cc: "Premi, Sanjeev" , Tony Lindgren , "Krishnamoorthy, Balaji T" , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org" , "david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "sameo-RWuK6r/cQWRpLGFMi4vTTA@public.gmane.org" , "wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org" , "timo.t.kokkonen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org" , "ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org" , "lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" , "Nayak, Rajendra" List-Id: linux-omap@vger.kernel.org On Tue, Aug 04, 2009 at 06:56:13PM +0530, Shilimkar, Santosh wrote: > > > > is_class_twl4030() feels like it should have better namespacing, > > though > > > > having the part name in there means it's not actually an issue. > > > How about twl_is_4030()? > > The idea was to have a class of twl4030 IC's type IC's. There are many of > > them with just different name (TPS *) > > ... twl_class_is_4030().... What you say ? > > Can I suggest: pmic_class_is_xxx() ? > Even better That feels like it's got a more global namespace than it ought - this is really only for this class of chip. It's also got a bit of an assumption that there's only one PMIC in the system which isn't always the case.