From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Kanigeri, Hari" <h-kanigeri2@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: [PATCH v1 1/3] ARM:OMAP4 iommu:changes in iommu for OMAP4
Date: Wed, 5 Aug 2009 10:20:01 +0300 [thread overview]
Message-ID: <20090805072001.GB7374@atomide.com> (raw)
In-Reply-To: <20090804224504.GB17716@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [090805 01:45]:
> On Tue, Aug 04, 2009 at 05:30:23PM -0500, Kanigeri, Hari wrote:
> > - obj->clk = clk_get(&pdev->dev, pdata->clk_name);
> > - if (IS_ERR(obj->clk))
> > - goto err_clk;
> > + /*
> > + * FIX-ME: Replace with correct clk node when clk
> > + * framework is available
> > + */
> > + if (!cpu_is_omap44xx()) {
> > + obj->clk = clk_get(&pdev->dev, pdata->clk_name);
> > + if (IS_ERR(obj->clk))
> > + goto err_clk;
> > + }
>
> I've no visibility on when these are going to get resolved, and it's
> starting to concern me that there appears to be no progress on it,
> especially as we have more and more code being merged with these
> workarounds. It's getting towards the point where enough is enough
> and we need OMAP4 clk support in place, even if it is just a simple
> stop-gap implementation rather than all these horrible hacks spread
> through the code which one day will need to be found and removed.
Yeah I agree.
Tony
next prev parent reply other threads:[~2009-08-05 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 22:30 [PATCH v1 1/3] ARM:OMAP4 iommu:changes in iommu for OMAP4 Kanigeri, Hari
2009-08-04 22:45 ` Russell King - ARM Linux
2009-08-05 7:20 ` Tony Lindgren [this message]
2009-08-05 16:06 ` Shilimkar, Santosh
2009-08-05 16:33 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805072001.GB7374@atomide.com \
--to=tony@atomide.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=h-kanigeri2@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox