From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v1 1/3] ARM:OMAP4 iommu:changes in iommu for OMAP4 Date: Wed, 5 Aug 2009 10:20:01 +0300 Message-ID: <20090805072001.GB7374@atomide.com> References: <8F7AF80515AF0D4D93307E594F3CB40E3ABDBABD@dlee03.ent.ti.com> <20090804224504.GB17716@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:61033 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933564AbZHEHUL (ORCPT ); Wed, 5 Aug 2009 03:20:11 -0400 Content-Disposition: inline In-Reply-To: <20090804224504.GB17716@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: "Kanigeri, Hari" , "linux-omap@vger.kernel.org" , Hiroshi DOYU , "Shilimkar, Santosh" * Russell King - ARM Linux [090805 01:45]: > On Tue, Aug 04, 2009 at 05:30:23PM -0500, Kanigeri, Hari wrote: > > - obj->clk = clk_get(&pdev->dev, pdata->clk_name); > > - if (IS_ERR(obj->clk)) > > - goto err_clk; > > + /* > > + * FIX-ME: Replace with correct clk node when clk > > + * framework is available > > + */ > > + if (!cpu_is_omap44xx()) { > > + obj->clk = clk_get(&pdev->dev, pdata->clk_name); > > + if (IS_ERR(obj->clk)) > > + goto err_clk; > > + } > > I've no visibility on when these are going to get resolved, and it's > starting to concern me that there appears to be no progress on it, > especially as we have more and more code being merged with these > workarounds. It's getting towards the point where enough is enough > and we need OMAP4 clk support in place, even if it is just a simple > stop-gap implementation rather than all these horrible hacks spread > through the code which one day will need to be found and removed. Yeah I agree. Tony