From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>
Cc: Ben Goska <goskab@onid.oregonstate.edu>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: arch/arm/mach-omap* organization
Date: Wed, 5 Aug 2009 11:39:35 +0300 [thread overview]
Message-ID: <20090805083935.GB28674@nokia.com> (raw)
In-Reply-To: <20090804070526.GD24334@atomide.com>
On Tue, Aug 04, 2009 at 09:05:27AM +0200, ext Tony Lindgren wrote:
> * Ben Goska <goskab@onid.oregonstate.edu> [090804 01:53]:
> > Is there a reason why omap2, omap3, and now omap4 files are all packed
> > into the mach-omap2 directory?
> >
> > It seems like it would make more sense for each omap version to have
> > it's own directory.
>
> Majority of the mach-omap2 code is shared across them.
>
> For example, the initial patch to add minimal omap3 support on top of
> the omap2 code was about 500 lines of diff. The situation was pretty
> much the same to add minimal omap4 support on top of omap3.
>
> If we wanted to, in the long run we could move more of the shared
> code to plat-omap, and just keep board-*.c files under each mach-*
> directory.
I guess that will start to show as a necessary change since we would be
able to remove several "if (cpu_is_omapXXX())" from platform_device
registration code and related changes.
--
balbi
prev parent reply other threads:[~2009-08-05 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 22:23 arch/arm/mach-omap* organization Ben Goska
2009-08-04 7:05 ` Tony Lindgren
2009-08-05 8:39 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805083935.GB28674@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=goskab@onid.oregonstate.edu \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox