arch/arm/mach-omap* organization

arch/arm/mach-omap* organization

[Ben Goska]

Is there a reason why omap2, omap3, and now omap4 files are all packed 
into the mach-omap2 directory?

It seems like it would make more sense for each omap version to have 
it's own directory.

-Ben Goska

Re: arch/arm/mach-omap* organization

[Tony Lindgren]

* Ben Goska <goskab@onid.oregonstate.edu> [090804 01:53]:
> Is there a reason why omap2, omap3, and now omap4 files are all packed  
> into the mach-omap2 directory?
>
> It seems like it would make more sense for each omap version to have  
> it's own directory.

Majority of the mach-omap2 code is shared across them.

For example, the initial patch to add minimal omap3 support on top of
the omap2 code was about 500 lines of diff. The situation was pretty
much the same to add minimal omap4 support on top of omap3.

If we wanted to, in the long run we could move more of the shared
code to plat-omap, and just keep board-*.c files under each mach-*
directory.

But before we start doing rearranging like that we should first
concentrate on more important things, such as getting all the
PM code into the mainline, getting clock framework up and running
for omap4, get rid of IO_ADDRESS macros and omap_read/write and so
on.

Regards,

Tony

Re: arch/arm/mach-omap* organization

[Felipe Balbi]

On Tue, Aug 04, 2009 at 09:05:27AM +0200, ext Tony Lindgren wrote:
> * Ben Goska <goskab@onid.oregonstate.edu> [090804 01:53]:
> > Is there a reason why omap2, omap3, and now omap4 files are all packed  
> > into the mach-omap2 directory?
> >
> > It seems like it would make more sense for each omap version to have  
> > it's own directory.
> 
> Majority of the mach-omap2 code is shared across them.
> 
> For example, the initial patch to add minimal omap3 support on top of
> the omap2 code was about 500 lines of diff. The situation was pretty
> much the same to add minimal omap4 support on top of omap3.
> 
> If we wanted to, in the long run we could move more of the shared
> code to plat-omap, and just keep board-*.c files under each mach-*
> directory.

I guess that will start to show as a necessary change since we would be
able to remove several "if (cpu_is_omapXXX())" from platform_device
registration code and related changes.

-- 
balbi