From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"alsa-devel@vger.kernel.org" <alsa-devel@vger.kernel.org>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>
Subject: Re: [PATCH 03/20] OMAP: McBSP: Change wakeup signals
Date: Wed, 5 Aug 2009 10:40:36 +0300 [thread overview]
Message-ID: <200908051040.36699.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <1248958183-15015-4-git-send-email-eduardo.valentin@nokia.com>
On Thursday 30 July 2009 15:49:26 Valentin Eduardo (Nokia-D/Helsinki) wrote:
> Configure only XRDYEN and RRDYEN wakeup signals
> in order to get better power consumption.
>
> @@ -264,9 +264,7 @@
> #define REOFEN 0x0004
> #define RFSREN 0x0002
> #define RSYNCERREN 0x0001
> -#define WAKEUPEN_ALL (XEMPTYEOFEN | XRDYEN | XEOFEN | XFSXEN | \
> - XSYNCERREN | RRDYEN | REOFEN | RFSREN | \
> - RSYNCERREN)
> +#define WAKEUPEN_ALL (XRDYEN | RRDYEN)
Or don't use the WAKEUPEN_ALL in the code, but replace it with (XRDYEN |
RRDYEN)? It is confusing to use WAKEUPEN_ALL, which is actually _not_ enabling
all wakeups.
--
Péter
next prev parent reply other threads:[~2009-08-05 7:40 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 12:49 [PATCH 00/20] OMAP ASoC changes in DMA utilization Eduardo Valentin
2009-07-30 12:49 ` [PATCH 01/20] OMAP: McBSP: Provide functions for ASoC frame syncronization Eduardo Valentin
2009-07-30 12:49 ` [PATCH 02/20] OMAP: McBSP: Wakeups utilized Eduardo Valentin
2009-07-30 12:49 ` [PATCH 03/20] OMAP: McBSP: Change wakeup signals Eduardo Valentin
2009-07-30 12:49 ` [PATCH 04/20] OMAP: McBSP: Add IRQEN, IRQSTATUS, THRESHOLD2 and THRESHOLD1 registers Eduardo Valentin
2009-07-30 12:49 ` [PATCH 05/20] OMAP: McBSP: Retain McBSP FCLK clockactivity Eduardo Valentin
2009-07-30 12:49 ` [PATCH 06/20] OMAP: McBSP: Use appropriate value for startup delay Eduardo Valentin
2009-07-30 12:49 ` [PATCH 07/20] OMAP: McBSP: Add transmit/receive threshold handler Eduardo Valentin
2009-07-30 12:49 ` [PATCH 08/20] OMAP: McBSP: Create and export max_(r|t)x_thres property Eduardo Valentin
2009-07-30 12:49 ` [PATCH 09/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1,3,4,5 Eduardo Valentin
2009-07-30 12:49 ` [PATCH 10/20] OMAP: McBSP: Rename thres sysfs symbols Eduardo Valentin
2009-07-30 12:49 ` [PATCH 11/20] OMAP: McBSP: Add link DMA mode selection Eduardo Valentin
2009-07-30 12:49 ` [PATCH 12/20] OMAP: McBSP: Configure NO IDLE mode for DMA mode different of threshold Eduardo Valentin
2009-07-30 12:49 ` [PATCH 13/20] OMAP: McBSP: Do not enable wakeups for no-idle mode Eduardo Valentin
2009-07-30 12:49 ` [PATCH 14/20] OMAP: McBSP: Disable all wakeups upon exit Eduardo Valentin
2009-07-30 12:49 ` [PATCH 15/20] OMAP: McBSP: Let element DMA mode hit retention also Eduardo Valentin
2009-07-30 12:49 ` [PATCH 16/20] ASoC: OMAP: Use McBSP threshold again Eduardo Valentin
2009-07-30 12:49 ` [PATCH 17/20] ASoC: OMAP: Make DMA 64 aligned Eduardo Valentin
2009-07-30 12:49 ` [PATCH 18/20] ASoC: OMAP: Enable DMA burst mode Eduardo Valentin
2009-07-30 12:49 ` [PATCH 19/20] ASoC: OMAP: Use DMA operating mode of McBSP Eduardo Valentin
2009-07-30 12:49 ` [PATCH 20/20] ASoC: Always syncronize audio transfers on frames Eduardo Valentin
2009-07-30 18:57 ` Jarkko Nikula
2009-08-05 7:48 ` [PATCH 16/20] ASoC: OMAP: Use McBSP threshold again Jarkko Nikula
2009-08-10 8:53 ` Eduardo Valentin
2009-08-11 5:34 ` Jarkko Nikula
2009-08-11 6:22 ` Eduardo Valentin
2009-08-06 12:00 ` [PATCH 12/20] OMAP: McBSP: Configure NO IDLE mode for DMA mode different of threshold Eduardo Valentin
2009-07-30 13:04 ` [PATCH 11/20] OMAP: McBSP: Add link DMA mode selection Mark Brown
2009-07-30 13:28 ` Eduardo Valentin
2009-07-30 13:47 ` Mark Brown
2009-08-03 10:15 ` Eduardo Valentin
2009-08-05 7:39 ` Jarkko Nikula
2009-08-05 8:58 ` Peter Ujfalusi
2009-08-06 18:15 ` [alsa-devel] " ext-Eero.Nurkkala
2009-08-07 13:11 ` Eduardo Valentin
2009-08-11 6:04 ` Jarkko Nikula
2009-08-11 6:18 ` [alsa-devel] " Eero Nurkkala
2009-08-12 11:45 ` Jarkko Nikula
2009-08-12 11:48 ` [alsa-devel] " Eero Nurkkala
2009-08-13 6:01 ` Peter Ujfalusi
2009-07-30 18:57 ` [PATCH 09/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1,3,4,5 Jarkko Nikula
2009-07-31 7:58 ` Eduardo Valentin
2009-07-31 17:26 ` Jarkko Nikula
2009-08-03 8:11 ` Eduardo Valentin
2009-08-03 8:36 ` Jarkko Nikula
2009-08-03 8:36 ` Eduardo Valentin
2009-08-06 12:10 ` [PATCH 07/20] OMAP: McBSP: Add transmit/receive threshold handler Tony Lindgren
2009-08-06 12:20 ` ext-Eero.Nurkkala
2009-08-06 12:24 ` Tony Lindgren
2009-07-30 18:56 ` [PATCH 06/20] OMAP: McBSP: Use appropriate value for startup delay Jarkko Nikula
2009-07-31 7:21 ` ext-Eero.Nurkkala
2009-07-31 17:25 ` Jarkko Nikula
2009-08-05 7:40 ` Peter Ujfalusi [this message]
2009-07-30 18:56 ` [PATCH 02/20] OMAP: McBSP: Wakeups utilized Jarkko Nikula
2009-07-31 7:56 ` Eduardo Valentin
2009-08-06 12:05 ` Tony Lindgren
2009-08-06 12:00 ` Eduardo Valentin
2009-08-06 12:00 ` Tony Lindgren
2009-08-06 12:02 ` Tony Lindgren
2009-08-06 11:56 ` Eduardo Valentin
2009-08-05 7:18 ` [PATCH 01/20] OMAP: McBSP: Provide functions for ASoC frame syncronization Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908051040.36699.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-devel@vger.kernel.org \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox