From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable Date: Wed, 5 Aug 2009 18:11:00 +0300 Message-ID: <20090805151059.GT7374@atomide.com> References: <20090805123354.GF7374@atomide.com> <877hxi9vl7.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:55563 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933080AbZHEPLH (ORCPT ); Wed, 5 Aug 2009 11:11:07 -0400 Content-Disposition: inline In-Reply-To: <877hxi9vl7.fsf@deeprootsystems.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Wang Sawsd-A24013 , linux-omap@vger.kernel.org * Kevin Hilman [090805 17:36]: > Tony Lindgren writes: > > > Hi, > > > > Sorry for the long delay on replying to this one. > > Tony, this one has been superceded, and the irq_enable/disable stuff no > longer is needed due to the patch > > OMAP: GPIO: clear/restore level/edge detect settings on mask/unmask > > from my PM fixes queue. > > An updated version (currently in the PM branch) is here: > http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=commit;h=c80a909697ad931ffad9d30ed321469fa699b208 OK, thanks. > > but... > > > To me it looks like the right way to deal with the level gpio > > would be to change it temporarily to be edge for the duration of > > idle, then change it back to be level after returning from idle. > > Not sure about that. That would have to be experimented with to > see if there are any other side effects. > > In any case, that kind of change would be independent of this change > as this change just fixes a bug so wake-enables are only set on > edge-triggered GPIOs. OK. Just FYI, I think I experimented on that for 2420 at some point and it worked, but that was several years ago. Tony