Re: [PATCH] OMAP: GPIO: Avoid generating extra IRQs

[Tony Lindgren <tony@atomide.com>]

* ext-Eero.Nurkkala@nokia.com <ext-Eero.Nurkkala@nokia.com> [090805 17:45]:
> 
> >>               l ^= bank->saved_datain;
> >>               l &= bank->non_wakeup_gpios;
> >> -             if (l) {
> >> +
> >> +             /*
> >> +              * No need to generate IRQs for the rising edge for gpio IRQs
> >> +              * configured with falling edge only; and vice versa.
> >> +              */
> >> +             gen0 = l & bank->saved_fallingdetect;
> >> +             gen0 &= bank->saved_datain;
> >> +
> >> +             gen1 = l & bank->saved_risingdetect;
> >> +             gen1 &= ~(bank->saved_datain);
> >> +
> 
> > Is the gen0 &= correct or should it also clear the bits?
> 
> What do you mean, eg, what bits should be cleared?
> 
> gen0 = (bit has changed) and is falling_edge
> gen0 &= (the bit has changed) is falling edge and former state was "HIGH"
> (transition from HIGH to LOW has occurred)
> 
> for rising edge, needed is LOW to HIGH transition.

OK, my comment was just based on looking at the patch, sounds like
you have verified that it's correct. 

Tony