From: Tony Lindgren <tony@atomide.com>
To: Eduardo Valentin <eduardo.valentin@nokia.com>
Cc: ext Jarkko Nikula <jhnikula@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"alsa-devel@vger.kernel.org" <alsa-devel@vger.kernel.org>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>
Subject: Re: [PATCH 02/20] OMAP: McBSP: Wakeups utilized
Date: Thu, 6 Aug 2009 15:05:25 +0300 [thread overview]
Message-ID: <20090806120525.GJ2358@atomide.com> (raw)
In-Reply-To: <20090731075622.GA27083@esdhcp037198.research.nokia.com>
* Eduardo Valentin <eduardo.valentin@nokia.com> [090731 11:08]:
> On Thu, Jul 30, 2009 at 08:56:02PM +0200, ext Jarkko Nikula wrote:
> > On Thu, 30 Jul 2009 15:49:25 +0300
> > Eduardo Valentin <eduardo.valentin@nokia.com> wrote:
> >
> > > --- a/arch/arm/plat-omap/mcbsp.c
> > > +++ b/arch/arm/plat-omap/mcbsp.c
> > > @@ -257,6 +257,23 @@ int omap_mcbsp_request(unsigned int id)
> > > clk_enable(mcbsp->iclk);
> > > clk_enable(mcbsp->fclk);
> > >
> > > +#ifdef CONFIG_ARCH_OMAP34XX
> > > + /*
> >
> > I'm sure there is a way to avoid all of these added ifdefs in this patch
> > and in patches 7 and 8 as well.
>
> hmmm.. these ifdef's are required because I've put the extra field (for
> 34xx only) inside an ifdef on their declaration in mcbsp.h. We can remove it
> there, but will leave a few extra bytes on !omap3xx binaries.
Hmm which field are you talking about? The define does not matter, and the
u16 syscon also gets optimized out if 34xx is not selected.
Tony
next prev parent reply other threads:[~2009-08-06 12:05 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 12:49 [PATCH 00/20] OMAP ASoC changes in DMA utilization Eduardo Valentin
2009-07-30 12:49 ` [PATCH 01/20] OMAP: McBSP: Provide functions for ASoC frame syncronization Eduardo Valentin
2009-07-30 12:49 ` [PATCH 02/20] OMAP: McBSP: Wakeups utilized Eduardo Valentin
2009-07-30 12:49 ` [PATCH 03/20] OMAP: McBSP: Change wakeup signals Eduardo Valentin
2009-07-30 12:49 ` [PATCH 04/20] OMAP: McBSP: Add IRQEN, IRQSTATUS, THRESHOLD2 and THRESHOLD1 registers Eduardo Valentin
2009-07-30 12:49 ` [PATCH 05/20] OMAP: McBSP: Retain McBSP FCLK clockactivity Eduardo Valentin
2009-07-30 12:49 ` [PATCH 06/20] OMAP: McBSP: Use appropriate value for startup delay Eduardo Valentin
2009-07-30 12:49 ` [PATCH 07/20] OMAP: McBSP: Add transmit/receive threshold handler Eduardo Valentin
2009-07-30 12:49 ` [PATCH 08/20] OMAP: McBSP: Create and export max_(r|t)x_thres property Eduardo Valentin
2009-07-30 12:49 ` [PATCH 09/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1,3,4,5 Eduardo Valentin
2009-07-30 12:49 ` [PATCH 10/20] OMAP: McBSP: Rename thres sysfs symbols Eduardo Valentin
2009-07-30 12:49 ` [PATCH 11/20] OMAP: McBSP: Add link DMA mode selection Eduardo Valentin
2009-07-30 12:49 ` [PATCH 12/20] OMAP: McBSP: Configure NO IDLE mode for DMA mode different of threshold Eduardo Valentin
2009-07-30 12:49 ` [PATCH 13/20] OMAP: McBSP: Do not enable wakeups for no-idle mode Eduardo Valentin
2009-07-30 12:49 ` [PATCH 14/20] OMAP: McBSP: Disable all wakeups upon exit Eduardo Valentin
2009-07-30 12:49 ` [PATCH 15/20] OMAP: McBSP: Let element DMA mode hit retention also Eduardo Valentin
2009-07-30 12:49 ` [PATCH 16/20] ASoC: OMAP: Use McBSP threshold again Eduardo Valentin
2009-07-30 12:49 ` [PATCH 17/20] ASoC: OMAP: Make DMA 64 aligned Eduardo Valentin
2009-07-30 12:49 ` [PATCH 18/20] ASoC: OMAP: Enable DMA burst mode Eduardo Valentin
2009-07-30 12:49 ` [PATCH 19/20] ASoC: OMAP: Use DMA operating mode of McBSP Eduardo Valentin
2009-07-30 12:49 ` [PATCH 20/20] ASoC: Always syncronize audio transfers on frames Eduardo Valentin
2009-07-30 18:57 ` Jarkko Nikula
2009-08-05 7:48 ` [PATCH 16/20] ASoC: OMAP: Use McBSP threshold again Jarkko Nikula
2009-08-10 8:53 ` Eduardo Valentin
2009-08-11 5:34 ` Jarkko Nikula
2009-08-11 6:22 ` Eduardo Valentin
2009-08-06 12:00 ` [PATCH 12/20] OMAP: McBSP: Configure NO IDLE mode for DMA mode different of threshold Eduardo Valentin
2009-07-30 13:04 ` [PATCH 11/20] OMAP: McBSP: Add link DMA mode selection Mark Brown
2009-07-30 13:28 ` Eduardo Valentin
2009-07-30 13:47 ` Mark Brown
2009-08-03 10:15 ` Eduardo Valentin
2009-08-05 7:39 ` Jarkko Nikula
2009-08-05 8:58 ` Peter Ujfalusi
2009-08-06 18:15 ` [alsa-devel] " ext-Eero.Nurkkala
2009-08-07 13:11 ` Eduardo Valentin
2009-08-11 6:04 ` Jarkko Nikula
2009-08-11 6:18 ` [alsa-devel] " Eero Nurkkala
2009-08-12 11:45 ` Jarkko Nikula
2009-08-12 11:48 ` [alsa-devel] " Eero Nurkkala
2009-08-13 6:01 ` Peter Ujfalusi
2009-07-30 18:57 ` [PATCH 09/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1,3,4,5 Jarkko Nikula
2009-07-31 7:58 ` Eduardo Valentin
2009-07-31 17:26 ` Jarkko Nikula
2009-08-03 8:11 ` Eduardo Valentin
2009-08-03 8:36 ` Jarkko Nikula
2009-08-03 8:36 ` Eduardo Valentin
2009-08-06 12:10 ` [PATCH 07/20] OMAP: McBSP: Add transmit/receive threshold handler Tony Lindgren
2009-08-06 12:20 ` ext-Eero.Nurkkala
2009-08-06 12:24 ` Tony Lindgren
2009-07-30 18:56 ` [PATCH 06/20] OMAP: McBSP: Use appropriate value for startup delay Jarkko Nikula
2009-07-31 7:21 ` ext-Eero.Nurkkala
2009-07-31 17:25 ` Jarkko Nikula
2009-08-05 7:40 ` [PATCH 03/20] OMAP: McBSP: Change wakeup signals Peter Ujfalusi
2009-07-30 18:56 ` [PATCH 02/20] OMAP: McBSP: Wakeups utilized Jarkko Nikula
2009-07-31 7:56 ` Eduardo Valentin
2009-08-06 12:05 ` Tony Lindgren [this message]
2009-08-06 12:00 ` Eduardo Valentin
2009-08-06 12:00 ` Tony Lindgren
2009-08-06 12:02 ` Tony Lindgren
2009-08-06 11:56 ` Eduardo Valentin
2009-08-05 7:18 ` [PATCH 01/20] OMAP: McBSP: Provide functions for ASoC frame syncronization Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806120525.GJ2358@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@vger.kernel.org \
--cc=eduardo.valentin@nokia.com \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox