Re: [PATCH 7/9] omap3: Add CHIP_GE_OMAP3430ES3 for HSUSB

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <felipe.balbi@nokia.com> [090806 16:06]:
> On Thu, Aug 06, 2009 at 02:07:38PM +0200, ext Ajay Kumar Gupta wrote:
> > OMAP3 HSUSB ports can be individually programmed in PHY or TLL
> > mode in ES3.0 onwards whereas this is not supported in ES2.1
> > and earlier versions.
> > 
> > CHIP_GE_OMAP3430ES3 is added to program this behavior at runtime.
> > 
> > Also updated the existing macros to use the priviously defined
> > *_GE_* logic instead of repeating the same logic again.
> > 
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > ---
> >  arch/arm/plat-omap/include/mach/cpu.h |    7 ++++---
> >  1 files changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/plat-omap/include/mach/cpu.h b/arch/arm/plat-omap/include/mach/cpu.h
> > index 285eaa3..5848717 100644
> > --- a/arch/arm/plat-omap/include/mach/cpu.h
> > +++ b/arch/arm/plat-omap/include/mach/cpu.h
> > @@ -428,10 +428,11 @@ IS_OMAP_TYPE(3430, 0x3430)
> >   * chips at ES2 and beyond, but not, for example, any OMAP lines after
> >   * OMAP3.
> >   */
> > -#define CHIP_GE_OMAP3430ES2		(CHIP_IS_OMAP3430ES2 | \
> > -					 CHIP_IS_OMAP3430ES3_0 | \
> > -					 CHIP_IS_OMAP3430ES3_1)
> >  #define CHIP_GE_OMAP3430ES3_1		(CHIP_IS_OMAP3430ES3_1)
> > +#define CHIP_GE_OMAP3430ES3		(CHIP_IS_OMAP3430ES3_0 | \
> > +					 CHIP_GE_OMAP3430ES3_1)
> > +#define CHIP_GE_OMAP3430ES2		(CHIP_IS_OMAP3430ES2 | \
> > +					 CHIP_GE_OMAP3430ES3)
> 
> Tony, what about this one ? Do you agree with it ? I need this in order
> to get a buildable driver merged through linux-usb. The usb-ehci.c stuff
> I can postpone to be sent later but without this, ehci-omap.c won't
> build.
> 
> any input is appreciated.

Yeh looks OK to me.

Tony