From: Kalle Valo <kalle.valo@iki.fi>
To: linux-omap@vger.kernel.org
Subject: [PATCH 1/2] OMAP: remove OMAP_TAG_SERIAL_CONSOLE
Date: Fri, 07 Aug 2009 08:16:44 +0300 [thread overview]
Message-ID: <20090807051643.4787.85971.stgit@tikku> (raw)
In-Reply-To: <20090807051516.4787.36125.stgit@tikku>
Omap tags are deprecated and remove OMAP_TAG_SERIAL_CONSOLE. Console must be
enabled with the console boot parameter instead.
Signed-off-by: Kalle Valo <kalle.valo@iki.fi>
---
arch/arm/plat-omap/common.c | 44 -------------------------------
arch/arm/plat-omap/include/mach/board.h | 1 -
2 files changed, 0 insertions(+), 45 deletions(-)
diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c
index ebcf006..f37a29a 100644
--- a/arch/arm/plat-omap/common.c
+++ b/arch/arm/plat-omap/common.c
@@ -127,50 +127,6 @@ const void *omap_get_var_config(u16 tag, size_t *len)
}
EXPORT_SYMBOL(omap_get_var_config);
-static int __init omap_add_serial_console(void)
-{
- const struct omap_serial_console_config *con_info;
- const struct omap_uart_config *uart_info;
- static char speed[11], *opt = NULL;
- int line, i, uart_idx;
-
- uart_info = omap_get_config(OMAP_TAG_UART, struct omap_uart_config);
- con_info = omap_get_config(OMAP_TAG_SERIAL_CONSOLE,
- struct omap_serial_console_config);
- if (uart_info == NULL || con_info == NULL)
- return 0;
-
- if (con_info->console_uart == 0)
- return 0;
-
- if (con_info->console_speed) {
- snprintf(speed, sizeof(speed), "%u", con_info->console_speed);
- opt = speed;
- }
-
- uart_idx = con_info->console_uart - 1;
- if (uart_idx >= OMAP_MAX_NR_PORTS) {
- printk(KERN_INFO "Console: external UART#%d. "
- "Not adding it as console this time.\n",
- uart_idx + 1);
- return 0;
- }
- if (!(uart_info->enabled_uarts & (1 << uart_idx))) {
- printk(KERN_ERR "Console: Selected UART#%d is "
- "not enabled for this platform\n",
- uart_idx + 1);
- return -1;
- }
- line = 0;
- for (i = 0; i < uart_idx; i++) {
- if (uart_info->enabled_uarts & (1 << i))
- line++;
- }
- return add_preferred_console("ttyS", line, opt);
-}
-console_initcall(omap_add_serial_console);
-
-
/*
* 32KHz clocksource ... always available, on pretty most chips except
* OMAP 730 and 1510. Other timers could be used as clocksources, with
diff --git a/arch/arm/plat-omap/include/mach/board.h b/arch/arm/plat-omap/include/mach/board.h
index 50ea79a..0d12586 100644
--- a/arch/arm/plat-omap/include/mach/board.h
+++ b/arch/arm/plat-omap/include/mach/board.h
@@ -16,7 +16,6 @@
/* Different peripheral ids */
#define OMAP_TAG_CLOCK 0x4f01
-#define OMAP_TAG_SERIAL_CONSOLE 0x4f03
#define OMAP_TAG_LCD 0x4f05
#define OMAP_TAG_GPIO_SWITCH 0x4f06
#define OMAP_TAG_UART 0x4f07
next prev parent reply other threads:[~2009-08-07 5:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 5:16 [PATCH 0/2] Remove omap serial tags Kalle Valo
2009-08-07 5:16 ` Kalle Valo [this message]
2009-08-10 15:46 ` [APPLIED] [PATCH 1/2] OMAP: remove OMAP_TAG_SERIAL_CONSOLE Tony Lindgren
2009-08-07 5:16 ` [PATCH 2/2] OMAP: remove OMAP_TAG_UART Kalle Valo
2009-08-07 5:40 ` Pandita, Vikram
2009-08-07 6:03 ` Kalle Valo
2009-08-07 9:26 ` Grazvydas Ignotas
2009-08-07 13:27 ` Roger Quadros
2009-08-07 13:29 ` Pandita, Vikram
2009-08-10 15:49 ` [APPLIED] " Tony Lindgren
[not found] ` <87k50tslp1.fsf@deeprootsystems.com>
2009-08-24 12:54 ` Grazvydas Ignotas
2009-08-24 12:57 ` Kevin Hilman
2009-08-24 14:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807051643.4787.85971.stgit@tikku \
--to=kalle.valo@iki.fi \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox