From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org,
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH][2.6.31-rc5] ARM: OMAP: McBSP: Fix ASoC on OMAP1510 by fixing API of omap_mcbsp_start/stop
Date: Fri, 7 Aug 2009 11:47:57 +0300 [thread overview]
Message-ID: <20090807114757.0067a707.jhnikula@gmail.com> (raw)
In-Reply-To: <200908071130.54337.peter.ujfalusi@nokia.com>
On Fri, 7 Aug 2009 11:30:54 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> Looks nice, but I would have done it a bit differently...
>
...
> > -void omap_mcbsp_start(unsigned int id);
> > -void omap_mcbsp_stop(unsigned int id);
> > +void omap_mcbsp_start(unsigned int id, int tx, int rx);
> > +void omap_mcbsp_stop(unsigned int id, int tx, int rx);
>
> void omap_mcbsp_start(unsigned int id, int dir);
> void omap_mcbsp_stop(unsigned int id, int dir);
>
Valid point and cleans up a bit the ALSA SoC part of the patch.
However I didn't want to limit this generic arch/arm/plat-omap/mcbsp.c
into audio use case only. My change still allows to start transmitter
and receiver exactly at the same time. Might be worth if the
generic McBSP driver is used for something else than audio.
--
Jarkko
next prev parent reply other threads:[~2009-08-07 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 6:59 [PATCH][2.6.31-rc5] ARM: OMAP: McBSP: Fix ASoC on OMAP1510 by fixing API of omap_mcbsp_start/stop Jarkko Nikula
2009-08-07 8:14 ` Tony Lindgren
2009-08-07 8:30 ` Peter Ujfalusi
2009-08-07 8:47 ` Jarkko Nikula [this message]
2009-08-07 8:51 ` Peter Ujfalusi
2009-08-07 8:52 ` Peter Ujfalusi
2009-08-07 9:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807114757.0067a707.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox