From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 8/9] OMAP2: add board file for Nokia N800 and N810 Date: Fri, 14 Aug 2009 14:08:51 +0300 Message-ID: <20090814110850.GU7278@atomide.com> References: <20090811094348.32577.81307.stgit@localhost> <20090811095558.32577.26177.stgit@localhost> <20090813091510.GK6132@n2100.arm.linux.org.uk> <87vdkrhr2q.fsf@litku.valot.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:57751 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754016AbZHNLJL (ORCPT ); Fri, 14 Aug 2009 07:09:11 -0400 Content-Disposition: inline In-Reply-To: <87vdkrhr2q.fsf@litku.valot.fi> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kalle Valo Cc: Russell King - ARM Linux , linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org * Kalle Valo [090814 09:01]: > Russell King - ARM Linux writes: > > > On Tue, Aug 11, 2009 at 12:55:58PM +0300, Tony Lindgren wrote: > >> +#include > > > > linux/gpio.h > > > >> +#include > > > > linux/io.h > > Thanks, will fix. > > >> +static struct musb_hdrc_platform_data tusb_data = { > >> + .mode = BOARD_MODE, > >> + .set_power = tusb_set_power, > >> + .set_clock = tusb_set_clock, > >> + .min_power = 25, /* x2 = 50 mA drawn from VBUS as peripheral */ > >> + .power = 100, /* Max 100 mA VBUS for host mode */ > >> + .clock = "osc_ck", > > > > Still passing clock names around? > > Sorry, I'm not familiar with this. How should I fix it? This should be fixed with the clkdev alias, see omap24xx_clks[]. But we need to check how the fix affects other platforms for drivers/usb/musb/musb_core.c and send the patch via linux-usb. Maybe take a quick look, and if it looks like a bigger change, then leave out the tusb_data for now and let's do it in a separate patch? > Tony, do you want me to send v2? Sure, it's best that you update it. Tony