Re: [PATCHv3 00/20] OMAP ASoC changes in DMA utilization

[Jarkko Nikula <jhnikula@gmail.com>]

On Mon, 17 Aug 2009 11:22:30 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:

> On Thursday 13 August 2009 17:35:13 Valentin Eduardo (Nokia-D/Helsinki) wrote:
> > Hello again guys,
> >
> > Here is version 3 of these changes. I've changed just 2
> > things:
> > - all mcbsp instances are in element mode by default
> > - moved all mcbsp related code to omap-mcbsp.c
> > (although a single callback is still needed)
> >
> > Jarkko, I think we can add your patch for reading strings
> > for dma op mode later on.
> 
> In my opinion we can take this series as it is now, what do you think Jarkko?
> At least I don't see too (any?) big problems with it...
> 
Good to remind me. I was almost making a reviewing to this and Janusz's
patches yesterday but ended up testing the MUSB and watching some
aircrafts instead :-)

But shortly going through the 3rd version of the set, only major issue I
point that it's not based on top of my patch below so most probably
patches 4 and 18 don't apply. Also changed API of
omap_mcbsp_start/-stop would allow to remove new exported functions
omap_mcbsp_xmit_enable and omap_mcbsp_recv_enable.

commit c12abc012e18b362204345c323536f228d65c4db
Author: Jarkko Nikula <jhnikula@gmail.com>
Date:   Fri Aug 7 09:59:47 2009 +0300

    ARM: OMAP: McBSP: Fix ASoC on OMAP1510 by fixing API of
omap_mcbsp_start/sto 

Otherwise set looks fine since omap-mcbp.c and omap-pcm.c are not hard
glued together and the element mode is the default.


-- 
Jarkko