From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [RFC][PATCH 1/3] ARM: OMAP: DMA: Add support for DMA channel self linking on OMAP1510 Date: Mon, 17 Aug 2009 12:16:01 +0300 Message-ID: <20090817121601.2fdb0c0f.jhnikula@gmail.com> References: <200908101050.02530.jkrzyszt@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from ey-out-2122.google.com ([74.125.78.27]:25714 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757482AbZHQJOb (ORCPT ); Mon, 17 Aug 2009 05:14:31 -0400 In-Reply-To: <200908101050.02530.jkrzyszt@tis.icnet.pl> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Janusz Krzysztofik Cc: Tony Lindgren , Mark Brown , Peter Ujfalusi , "alsa-devel@alsa-project.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.arm.linux.org.uk" , "linux-kernel@vger.kernel.org" On Mon, 10 Aug 2009 10:50:00 +0200 Janusz Krzysztofik wrote: > Implement DMA channel self linking on OMAP1510 using AUTO_INIT and REPEAT > flags of the DMA CCR register. > > Created against linux-2.6.31-rc5. > > Tested on Amstrad Delta. > > Signed-off-by: Janusz Krzysztofik > Tony, I'm fine with this patch. Although the autoinitialization != channel linking, in SW point of view autoinitialization and channel linking with itself looks the same so it's better to re-utilize existing omap_dma_link_lch also for 1510 DMA autoinitialization than inventing own API for it. Acked-by: Jarkko Nikula