public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Eduardo Valentin <eduardo.valentin@nokia.com>,
	Takashi Iwai <tiwai@suse.de>,
	Linux-OMAP <linux-omap@vger.kernel.org>,
	ALSA-Devel <alsa-devel@vger.kernel.org>,
	"Nurkkala Eero.An (EXT-Offcode/Oulu)"
	<ext-Eero.Nurkkala@nokia.com>,
	"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCHv4 16/20] ASoC: OMAP: Enable DMA burst mode
Date: Mon, 17 Aug 2009 17:01:29 +0300	[thread overview]
Message-ID: <20090817140128.GY7278@atomide.com> (raw)
In-Reply-To: <20090817162500.f01772a9.jhnikula@gmail.com>

* Jarkko Nikula <jhnikula@gmail.com> [090817 16:23]:
> On Mon, 17 Aug 2009 14:51:15 +0300
> Eduardo Valentin <eduardo.valentin@nokia.com> wrote:
> 
> > From: Eduardo Valentin <eduardo.valentin@nokia.com>
> > 
> > Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
> > ---
> >  sound/soc/omap/omap-pcm.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> > index f769a52..f037db0 100644
> > --- a/sound/soc/omap/omap-pcm.c
> > +++ b/sound/soc/omap/omap-pcm.c
> > @@ -193,6 +193,9 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream)
> >  	omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ |
> >  				(cpu_is_omap1510() ? OMAP_DMA_LAST_IRQ : 0));
> >  
> > +	omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
> > +	omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
> > +
> >  	return 0;
> 
> This seems to be based on first version of Janusz's "[RFC] [PATCH 3/3]
> ASoC: OMAP: Enhance OMAP1510 DMA progress software counter".
> 
> I Attached a version which is based on "[PATCH 3/3 v3] ASoC: OMAP:
> Enhance OMAP1510 DMA progress software counter.

Needs also a patch description.

Tony

> 
> 
> -- 
> Jarkko

> From a5eb199316c4731c11c7f5f8d02612ede4de7199 Mon Sep 17 00:00:00 2001
> From: Eduardo Valentin <eduardo.valentin@nokia.com>
> Date: Mon, 17 Aug 2009 14:51:15 +0300
> Subject: [PATCH] ASoC: OMAP: Enable DMA burst mode
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
> ---
>  sound/soc/omap/omap-pcm.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index eab4533..b9633d5 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -195,6 +195,9 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream)
>  	else
>  		omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ);
>  
> +	omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
> +	omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
> +
>  	return 0;
>  }
>  
> -- 
> 1.6.3.3
> 


  reply	other threads:[~2009-08-17 14:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 11:50 [PATCHv4 00/20] OMAP ASoC changes in DMA utilization Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 01/20] OMAP: McBSP: Provide functions for ASoC frame syncronization Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 02/20] OMAP: McBSP: Add IRQEN, IRQSTATUS, THRESHOLD2 and THRESHOLD1 registers Eduardo Valentin
2009-08-17 13:53   ` Tony Lindgren
2009-08-17 14:13     ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 03/20] OMAP: McBSP: Use appropriate value for startup delay Eduardo Valentin
2009-08-17 13:56   ` Tony Lindgren
2009-08-17 14:09     ` [PATCHv5 " Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 04/20] OMAP: McBSP: Add transmit/receive threshold handler Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 05/20] OMAP: McBSP: Create and export max_(r|t)x_thres property Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 06/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1,3,4,5 Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 07/20] OMAP: McBSP: Rename thres sysfs symbols Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 08/20] OMAP: McBSP: Add link DMA mode selection Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 09/20] OMAP: McBSP: Wakeups utilized Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 10/20] OMAP: McBSP: Change wakeup signals Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 11/20] OMAP: McBSP: Retain McBSP FCLK clockactivity Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 12/20] OMAP: McBSP: Configure NO IDLE mode for DMA mode different of threshold Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 13/20] OMAP: McBSP: Do not enable wakeups for no-idle mode Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 14/20] OMAP: McBSP: Let element DMA mode hit retention also Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 15/20] ASoC: OMAP: Make DMA 64 aligned Eduardo Valentin
2009-08-17 14:00   ` Tony Lindgren
2009-08-17 14:35     ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 16/20] ASoC: OMAP: Enable DMA burst mode Eduardo Valentin
2009-08-17 13:25   ` Jarkko Nikula
2009-08-17 14:01     ` Tony Lindgren [this message]
2009-08-17 14:29       ` [PATCH] " Eduardo Valentin
2009-08-17 14:39       ` [PATCHv4 16/20] " Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 17/20] ASoC: Add runtime check for RFIG and XFIG Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 18/20] ASoC: Always syncronize audio transfers on frames Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 19/20] ASoC: OMAP: Use McBSP threshold to playback and capture Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 20/20] ASoC: OMAP: Use DMA operating mode of McBSP Eduardo Valentin
2009-08-17 14:02   ` Tony Lindgren
2009-08-17 14:19     ` Eduardo Valentin
2009-08-17 14:05 ` [PATCHv4 00/20] OMAP ASoC changes in DMA utilization Jarkko Nikula
2009-08-19  7:40   ` Eduardo Valentin
2009-08-19  7:48     ` Eduardo Valentin
2009-08-19  8:26       ` Mark Brown
2009-08-24 14:00         ` [alsa-devel] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090817140128.GY7278@atomide.com \
    --to=tony@atomide.com \
    --cc=alsa-devel@vger.kernel.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=eduardo.valentin@nokia.com \
    --cc=ext-Eero.Nurkkala@nokia.com \
    --cc=jhnikula@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox